From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E703EA09E4; Thu, 28 Jan 2021 12:31:36 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 637314067D; Thu, 28 Jan 2021 12:31:36 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id A52D14067B for ; Thu, 28 Jan 2021 12:31:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611833493; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=r18LURf/Zeaxzu1m6eP8gQZ2W1tau6xTHMA7uEjSpLo=; b=bUzSxlhXuQbcmFaSses0AnaXbjjOPUp2oN5xmEJHc47ZH8P7Y5T6xZ63Z16zSv++9h51Zn riuIKJo4Ue1K8S7h7XnfNJlXxwkxs7Dgj4o5CGYlmjRxHxIVn7jcdgtQEJgk6W1dvk/YiK xrVH8dDwn7fE0b0uJPrW6b+f2F2qZEU= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-116-4KlqywzPPVG0bMXIfhg-4A-1; Thu, 28 Jan 2021 06:31:32 -0500 X-MC-Unique: 4KlqywzPPVG0bMXIfhg-4A-1 Received: by mail-vs1-f70.google.com with SMTP id a21so607906vsq.5 for ; Thu, 28 Jan 2021 03:31:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=r18LURf/Zeaxzu1m6eP8gQZ2W1tau6xTHMA7uEjSpLo=; b=kDPvLkBk9h7BSPhT90Qoy/2Ba+3qK1jULzzDW+XiHGD6fMrIysrjQjSq5pY/NBXLLJ AfieJZl073S1NLV7rpeplIWDKBxlO8rwyLbky0j5qGdx/+nmqQ/ss/G/jtSstW57D2Al IkNQ8/xkvNOpXT2h1pIkllTN/CSIQKGxhmA85gWB/xjcsNHceDAvy/B+CzNisSsMJpH/ lZ9ECPcX90M4qGNXsKgsjG8ngoMeC1vCNr4hFdEYdI2LXefuvmL3aRclUW9pQJX3as7P 06i3mIVtBP9LWpZTUbdMEwVAMqUFBNT9E6P3NofnpD6v3gv1jPTXt3fO01QBh2OwLjjc dQjw== X-Gm-Message-State: AOAM533YwmfE6+d6prsCsgjSJ8GOxU+Jrfc6Jyev6n8uDa6fDN9DmatY alEx4I7foCEnAKVR1oRtQaOgxk8YehZ8ZEMDJz90yPcv0wVnqiM+900diYcWQwsw4OuL7IvYKyX ZkgiVYp2m6X6ng7HiQT0= X-Received: by 2002:ab0:2356:: with SMTP id h22mr10703489uao.86.1611833491673; Thu, 28 Jan 2021 03:31:31 -0800 (PST) X-Google-Smtp-Source: ABdhPJwkUKs7lCn7m1i4vrMeoMctRAP/aH5Mxy2liZ+2Y2ETr7WmJeuEZcqkRJKEVOuwAtsh+/rW/FD7LnwozUmJCi8= X-Received: by 2002:ab0:2356:: with SMTP id h22mr10703484uao.86.1611833491515; Thu, 28 Jan 2021 03:31:31 -0800 (PST) MIME-Version: 1.0 References: <20210114110606.21142-1-bruce.richardson@intel.com> <20210127173330.1671341-1-bruce.richardson@intel.com> <20210127173330.1671341-7-bruce.richardson@intel.com> <20210128112719.GD899@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20210128112719.GD899@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Thu, 28 Jan 2021 12:31:20 +0100 Message-ID: To: Bruce Richardson Cc: dev , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v6 6/8] buildtools/chkincs: add app to verify header includes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jan 28, 2021 at 12:27 PM Bruce Richardson wrote: > > > +# some ethdev headers depend on bus headers > > > +includes = include_directories('../../drivers/bus/pci', > > > + '../../drivers/bus/vdev') > > > > ethdev headers are fine now, afaics. > > So this comment can be changed to a more vague "some driver headers > > depend on bus headers". > > > Driver headers are not checked yet by the code, only lib ones, so I will > see if this block can be omitted until needed. I tried yesterday, iirc, you'll hit issues with eventdev driver headers. -- David Marchand