From: David Marchand <david.marchand@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: Bing Zhao <bingz@nvidia.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
"andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions
Date: Mon, 25 Oct 2021 11:51:09 +0200 [thread overview]
Message-ID: <CAJFAV8ws0zHAokkOhq5i8vMDTC8BdDT8U8ZnLC1tknmcMzMrbw@mail.gmail.com> (raw)
In-Reply-To: <2136748.9NGIIKDUHm@thomas>
On Mon, Oct 25, 2021 at 11:43 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> > Correctly behaving app should never call these stub functions and should never see these messages.
> > If your app ended up inside this function, then there something really wrong is going on,
> > that can cause app crash, silent memory corruption, NIC HW hang, or many other nasty things.
> > The aim of this stubs mechanism:
> > 1) minimize (but not completely avoid) risk of such damage to happen in case of
> > programming error within user app.
> > 2) flag to the user that something very wrong is going on within his app.
> > In such situation, possible slowdown of misbehaving program is out of my concern.
If correctly behaving app should not do this, why not put an assert()
or a rte_panic?
This way, the users will definitely catch it.
>
> There is a concern about getting efficient log report,
> especially when looking at CI issues.
+1.
The current solution with logs is a real pain.
--
David Marchand
next prev parent reply other threads:[~2021-10-25 9:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-22 21:14 Bing Zhao
2021-10-22 21:14 ` [dpdk-dev] [PATCH 2/2] ethdev: fix the race condition for fp ops reset Bing Zhao
2021-10-23 8:34 ` Thomas Monjalon
2021-10-23 11:39 ` Ananyev, Konstantin
2021-11-10 14:34 ` Ferruh Yigit
2021-11-10 14:37 ` Ananyev, Konstantin
2021-11-10 14:57 ` Thomas Monjalon
2021-11-10 15:24 ` Bing Zhao
2021-10-23 16:13 ` [dpdk-dev] " Stephen Hemminger
2021-10-24 5:54 ` Bing Zhao
2021-10-23 8:32 ` [dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions Thomas Monjalon
2021-10-23 11:46 ` Ananyev, Konstantin
2021-10-23 12:45 ` Bing Zhao
2021-10-24 11:48 ` Ananyev, Konstantin
2021-10-25 9:43 ` Thomas Monjalon
2021-10-25 9:51 ` David Marchand [this message]
2021-10-25 12:55 ` Ananyev, Konstantin
2021-10-25 13:27 ` Thomas Monjalon
2021-10-25 13:31 ` David Marchand
2021-10-25 20:29 ` Ananyev, Konstantin
2021-10-25 20:38 ` Thomas Monjalon
2021-10-26 12:38 ` Ananyev, Konstantin
2021-10-26 12:59 ` Thomas Monjalon
2021-10-26 3:18 ` Bing Zhao
2021-10-23 12:12 ` Bing Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8ws0zHAokkOhq5i8vMDTC8BdDT8U8ZnLC1tknmcMzMrbw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).