From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 62FFDA0C4B; Mon, 25 Oct 2021 11:51:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 24945407FF; Mon, 25 Oct 2021 11:51:25 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id AB02B4003E for ; Mon, 25 Oct 2021 11:51:24 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635155484; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mBH8xRJHOaGpEN/BzDfDQk171Y5pnlSHOzC+k2qnKw8=; b=YlZp3deA1sVyo7h6gfjXpeiNxLZwOl+0FUTyQW85Mqb54bZQHXZcfODJPQc8he2BY8AF3T wpyozvkRQIOcM3X48UAHtIshW5dt+W3H4zEcWOQ0VfIY+mq3HIjnG7ieb4s/kGLr4CInT/ 1xlvq0d2Z4BJJfhCjO7sRZ/WYOK8vIM= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-42-JtGSarG0Nry90h3jH0vkMw-1; Mon, 25 Oct 2021 05:51:23 -0400 X-MC-Unique: JtGSarG0Nry90h3jH0vkMw-1 Received: by mail-lj1-f200.google.com with SMTP id a20-20020a2eb554000000b0020de66f70bcso2510421ljn.1 for ; Mon, 25 Oct 2021 02:51:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mBH8xRJHOaGpEN/BzDfDQk171Y5pnlSHOzC+k2qnKw8=; b=RyOf0WIdE5iJw/Q+Hzo24LHzs+bL8M0seYwE/OqxyJHzgvs1YmQ17yNSgLxKpYpQ/l hl2xq7+F11mlrczU3M1vSKVMMG+s1ZforbIja1vW4RmyoCsGsbOShfFwvGIiD/0OUxpj 43ErBKiWhAv+WrOO9q8jDOUDjrAvAvVl9UoIuTg/YHoGLsshWXiKyEK/acijX0nu3QT+ nVvtQbAWO2bq9Anhp72k6lsb7nt5wlp+aTt4Sy95GF0u3o7PmJh6qHhTPxto6wJQih9T NiOQdpbKTaKxsKKoMxMGC2CB7RF41uEIY5wirTR3TsdDy21dc0lZyZ2709bbJE1Q1G0x Ex2Q== X-Gm-Message-State: AOAM533H3C/sLvyCSUvWtwQy2j1bovnYsPUq0JrWfRSGpbKYSUGAOhr8 JzrzwCBuuOtsDS3oKd7pUPQdrJfFMWHknz7haddQ3vpEDuW0XIJcaxyC8DCcKTOR2YUaAQSp/Dw 3VeUz4wvmnoomuzGCTT8= X-Received: by 2002:a05:6512:31c3:: with SMTP id j3mr16493692lfe.217.1635155481465; Mon, 25 Oct 2021 02:51:21 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxJFrI8jgJozmx6iUOYcJ+L+Lstw0T2hAvXxSiF1aYKj4JaRz+H9uxzfDlqFxOIoX60HJW9jRPkIEUlfRNOdMM= X-Received: by 2002:a05:6512:31c3:: with SMTP id j3mr16493664lfe.217.1635155481225; Mon, 25 Oct 2021 02:51:21 -0700 (PDT) MIME-Version: 1.0 References: <20211022211407.315068-1-bingz@nvidia.com> <2136748.9NGIIKDUHm@thomas> In-Reply-To: <2136748.9NGIIKDUHm@thomas> From: David Marchand Date: Mon, 25 Oct 2021 11:51:09 +0200 Message-ID: To: Thomas Monjalon , "Ananyev, Konstantin" Cc: Bing Zhao , "Yigit, Ferruh" , "andrew.rybchenko@oktetlabs.ru" , "dev@dpdk.org" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/2] ethdev: fix log level of Tx and Rx dummy functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 25, 2021 at 11:43 AM Thomas Monjalon wrote: > > Correctly behaving app should never call these stub functions and should never see these messages. > > If your app ended up inside this function, then there something really wrong is going on, > > that can cause app crash, silent memory corruption, NIC HW hang, or many other nasty things. > > The aim of this stubs mechanism: > > 1) minimize (but not completely avoid) risk of such damage to happen in case of > > programming error within user app. > > 2) flag to the user that something very wrong is going on within his app. > > In such situation, possible slowdown of misbehaving program is out of my concern. If correctly behaving app should not do this, why not put an assert() or a rte_panic? This way, the users will definitely catch it. > > There is a concern about getting efficient log report, > especially when looking at CI issues. +1. The current solution with logs is a real pain. -- David Marchand