From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DFAAFA034F; Fri, 12 Nov 2021 15:13:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF29D410E3; Fri, 12 Nov 2021 15:13:54 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E5E5A40692 for ; Fri, 12 Nov 2021 15:13:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636726432; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=R+WMWMiWsp4Un5NzzcPoUA9trVZPKVCYiZyOmg6XNjk=; b=Z71DdxO2yIUEOQlCkszjv74tylrD0MKQI1UEq4am8tRt72HvolatZCCtla6DA0o9pdaLpY npdH2cCBO9L5lRyXmsjVh/jL6uwXmOJwhnwHWkAf08G6PPSQRnMAyL1CRxnQCj3lYIL35Q XiVviY0sR8llMteE8H2LUfB3DGV+NHE= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-434-TzW_yxZmM-uqTuYfEFARsg-1; Fri, 12 Nov 2021 09:13:49 -0500 X-MC-Unique: TzW_yxZmM-uqTuYfEFARsg-1 Received: by mail-lf1-f72.google.com with SMTP id z12-20020a0565120c0c00b004037427efb7so3953761lfu.1 for ; Fri, 12 Nov 2021 06:13:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R+WMWMiWsp4Un5NzzcPoUA9trVZPKVCYiZyOmg6XNjk=; b=RMgh2sYcX61TscTUU8LLTNXGy3QzOkaYAppc7W9XfkXhPc+Fi+Rf4jhJkFvpZVJd+w axreltHuRicxIKhQbQQKrR/FSvgVeZ3G+igTMjMa4p9tYMN1rC89WEJsgxxWqAodY+wv O73cABiDTQz95uaobQyQWncIVp7DWytUJMTnOOHhn4KZLB3F3HPnnLYp0wDbQhG0bt5l bppgBZpSOgTsO+UM8x0WB6SAQ4nQ+W3q/8PUQW1ind0I0zIZhrpgmc3Yre+Ji2z6I+DX 9YDmLiXKxSQ0Q1BNfTQZhzo4gRWbycKCN7/qq53oP7oi6l24jpaITuvcaYVZIEECoy7I nsyA== X-Gm-Message-State: AOAM533LzlH19mbNX2TiqMErBWLufM21NZSM/OfaNN835rxKDBsvUUK/ l43Gm4wpJtMDPmsvhD8ZBqlEmAWWm9d0aC+4q+owOzpaPKbvzqw7k0LN0DL8NjrZq9EHsFLjpSn BQ8340T8Rxdoowa54ZFM= X-Received: by 2002:a2e:b8cf:: with SMTP id s15mr15135937ljp.297.1636726427501; Fri, 12 Nov 2021 06:13:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJw7TxkCSKl6GR9XsdnVKL8JTUAwpRP4oJfK2UljtMxW+ICHF1a1jnHRv1XGOxjH3Dux7rMDoGqTT/lnhpyefQs= X-Received: by 2002:a2e:b8cf:: with SMTP id s15mr15135909ljp.297.1636726427297; Fri, 12 Nov 2021 06:13:47 -0800 (PST) MIME-Version: 1.0 References: <20211112140111.922171-1-conor.walsh@intel.com> <20211112140111.922171-8-conor.walsh@intel.com> In-Reply-To: <20211112140111.922171-8-conor.walsh@intel.com> From: David Marchand Date: Fri, 12 Nov 2021 15:13:35 +0100 Message-ID: Subject: Re: [PATCH 7/7] lib/power: fix unused but set variables To: Conor Walsh Cc: "Yigit, Ferruh" , longfengx.liang@intel.com, dev , David Hunt , "Wang, Yipeng1" , "Gobriel, Sameh" , Bruce Richardson , Vladimir Medvedkin , Hemant Agrawal , Sachin Saxena , "Trahe, Fiona" , John Griffin , Deepak Kumar Jain , Van Haaren Harry , Ajit Khaparde , Somnath Kotur , Ziyang Xuan , Xiaoyun Wang , Guoyang Zhou , Shijith Thotton , Srisivasubramanian Srinivasan , heinrich.kuhn@corigine.com, Harman Kalra , Rasesh Mody , Devendra Singh Rawat , Jiawen Wu , Yong Wang , "Mcnamara, John" , Shreyansh Jain , santosh.shukla@caviumnetworks.com, Akhil Goyal , Fan Zhang , "Kusztal, ArkadiuszX" , michael.baucom@broadcom.com, Venkat Duvvuru , Lance Richardson , kishore.padmanabha@broadcom.com, Jerin Jacob , derek.chickles@caviumnetworks.com, ssrinivasan@caviumnetworks.com, mjatharakonda@oneconvergence.com, simon.horman@corigine.com, david.george@sophos.com, sony.chacko@qlogic.com, harish.patil@qlogic.com, Stephen Hemminger , Tomasz Kulasek , ian.betts@intel.com, Liang Ma , lei.a.yao@intel.com Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Conor, On Fri, Nov 12, 2021 at 3:02 PM Conor Walsh wrote: > > This patch removes the tot_ppi variable from the update_stats function > within empty poll in the power library as it is an unused but set > variable. About the commitlog, commenting on this patch, but it applies to other of the series. > > Bugzilla ID: 881 No need for an empty line between bugzilla and fixes lines. > > Fixes: 450f0791312c ("power: add traffic pattern aware power control") We will want those fixes in stable branches. Cc: stable@dpdk.org > > Signed-off-by: Conor Walsh > Reported-by: Liang Longfeng Reports come before signing off a fix :-) Now, on this specific patch, Jim already provided a fix for this issue, you can drop it from your series. https://patchwork.dpdk.org/project/dpdk/patch/20211105155351.350403-1-james.r.harris@intel.com/ -- David Marchand