From: David Marchand <david.marchand@redhat.com>
To: Michael Haeuptle <michael.haeuptle@hpe.com>
Cc: dev <dev@dpdk.org>, Xiao Wang <xiao.w.wang@intel.com>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] eal: Fixes VFIO/sysfs race condition
Date: Tue, 21 Apr 2020 18:19:08 +0200 [thread overview]
Message-ID: <CAJFAV8wsmEJ-NVkqYLaAzQnb0Bcu=QsYV61vGWWseNpCdCxUHw@mail.gmail.com> (raw)
In-Reply-To: <20200406222323.18609-1-michael.haeuptle@hpe.com>
On Tue, Apr 7, 2020 at 12:23 AM Michael Haeuptle
<michael.haeuptle@hpe.com> wrote:
>
> This fix treats a 0 return value from vfio_open_group_fd
> in vfio_get_group_fd as the intended error condition instead
> of putting an incorrect 0 file descriptor in the vfio_group table.
>
> Sometimes, the creation of device files in sysfs is not
> instantaneously causing vfio_open_groupfd to return 0.
> This has been observed when hot removing/adding multiple
> NVMe devices (>=4).
>
> Fixes: 340b7bb8d583 ("vfio: extend data structure for multi container")
> Cc: stable@dpdk.org
>
> Signed-off-by: Michael Haeuptle <michael.haeuptle@hpe.com>
Please submit with a revision next time.
Added back acks from first revision of the patch.
Applied, thanks.
--
David Marchand
next prev parent reply other threads:[~2020-04-21 16:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 22:23 Michael Haeuptle
2020-04-21 16:19 ` David Marchand [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-04-06 22:16 Michael Haeuptle
2020-03-31 16:56 Michael Haeuptle
2020-04-01 8:50 ` Stojaczyk, Dariusz
2020-04-02 10:10 ` Burakov, Anatoly
2020-04-06 13:25 ` David Marchand
2020-04-06 19:15 ` Haeuptle, Michael
2020-04-06 20:08 ` David Marchand
2020-03-31 16:51 Michael Haeuptle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8wsmEJ-NVkqYLaAzQnb0Bcu=QsYV61vGWWseNpCdCxUHw@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=michael.haeuptle@hpe.com \
--cc=stable@dpdk.org \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).