From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 384F7A0598; Tue, 21 Apr 2020 18:19:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 168CA1D502; Tue, 21 Apr 2020 18:19:24 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 1F42C1D445 for ; Tue, 21 Apr 2020 18:19:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587485962; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0t4JubNsRmoXBOb3OZzfQyFC4uxX8Y7pOcUSrAL+zu4=; b=cGVQLM5LAJInNyGvmStyvxIGeH+U6o4dNeIPFfyX/M/QR7WaMhxpYzI0oRSo+8DqWrYTWR 1T9vYQh3xmIpfEUkZtziVdvpKmKZamiqGTYCS605frA4nmB3B0erHVc8/bkGHiVLnkysYV J5u9G3yDs1fPf2QmPY1Mi+ogAqjlqms= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-440-QQpwdaAZNAye7L3UmivAbg-1; Tue, 21 Apr 2020 12:19:21 -0400 X-MC-Unique: QQpwdaAZNAye7L3UmivAbg-1 Received: by mail-vk1-f197.google.com with SMTP id u190so5553159vke.0 for ; Tue, 21 Apr 2020 09:19:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Huhg6tgL5yE9Ns6mjqwMda0h+mv+FA3p/wyU8Ul877I=; b=PuJ9Pe5wN2yAE0/qGIL6LVQIIJ7aNBxFHfbB9rh211qYjFPS2BWMmJNWj0XSehAWWh aUULPi2EoyrPKZelR7dtitd0kP5oltsoPPb8cBVwFepNNpuCTUG4MWZBVE+IlcddLieN MYiVOeV+Gv8PnZJumPLB2zUKAD4/T3hQS2uui+fFx/ipOCwqko2JygZCuopkgWkiNMg0 CIsfpS+X6oaPrLrWfpk4GeFy16oOEF6iFbC8kqZTSP6N8Dj1rda/PGiV9Sgsas3HDeS/ j8MBwcgOYUCL9Fj0yGe/onc8o04yK/tgiGvgHyHQUnRCvJHTLxLe0LBdXrb64uh+uB4m 3Cgg== X-Gm-Message-State: AGi0PuYIaU+F3bQcKoGHavjbdKWvfQ+fmr/IOpg/yxm75q8agRzmLHi7 p19jVxmKz81OCBn22MoRW7z9eqbMil1w/NdJ38w2vQHxDUhwUYnjIk6oMxQBGtLo/9NFtmroyax A/JQR6cvZ8B+KdxuEjKY= X-Received: by 2002:ab0:5ad1:: with SMTP id x17mr12316531uae.126.1587485959565; Tue, 21 Apr 2020 09:19:19 -0700 (PDT) X-Google-Smtp-Source: APiQypL7EfZn7+l5mF6juLgVF1pQ7AzTR1ZHuGQNWQnKiMx8PDJLBml/jTtFWaGy6F7DUpwV6Bx27gFpIDI2BezdHaM= X-Received: by 2002:ab0:5ad1:: with SMTP id x17mr12316511uae.126.1587485959321; Tue, 21 Apr 2020 09:19:19 -0700 (PDT) MIME-Version: 1.0 References: <20200406222323.18609-1-michael.haeuptle@hpe.com> In-Reply-To: <20200406222323.18609-1-michael.haeuptle@hpe.com> From: David Marchand Date: Tue, 21 Apr 2020 18:19:08 +0200 Message-ID: To: Michael Haeuptle Cc: dev , Xiao Wang , dpdk stable X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] eal: Fixes VFIO/sysfs race condition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Apr 7, 2020 at 12:23 AM Michael Haeuptle wrote: > > This fix treats a 0 return value from vfio_open_group_fd > in vfio_get_group_fd as the intended error condition instead > of putting an incorrect 0 file descriptor in the vfio_group table. > > Sometimes, the creation of device files in sysfs is not > instantaneously causing vfio_open_groupfd to return 0. > This has been observed when hot removing/adding multiple > NVMe devices (>=3D4). > > Fixes: 340b7bb8d583 ("vfio: extend data structure for multi container") > Cc: stable@dpdk.org > > Signed-off-by: Michael Haeuptle Please submit with a revision next time. Added back acks from first revision of the patch. Applied, thanks. --=20 David Marchand