From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6181D4601D; Wed, 8 Jan 2025 12:05:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DEF004014F; Wed, 8 Jan 2025 12:05:26 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 41C75400D6 for ; Wed, 8 Jan 2025 12:05:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736334324; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=trml50sw/T0GyuPoSlgvstnBQNAhlSOGbKtL2CjSR+c=; b=h00vFE5op6ceomxwANfg5IL7YTDxKkg0zwyBRwR7LubWH6Ad6xyy21H4lfaRbvOWNeIdCy yDZuHP6WM8Cxp9SYkRsHgiJSG1xpqeU7vHzzhqocwGq7tZAGfrQXCMvbqIjcFY06VaRck/ jQ1G3W2FMnA0XBdhApkfglXDE+3hcLA= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-574-hRQytyOoO0CqXcUV_l8BWA-1; Wed, 08 Jan 2025 06:05:23 -0500 X-MC-Unique: hRQytyOoO0CqXcUV_l8BWA-1 X-Mimecast-MFC-AGG-ID: hRQytyOoO0CqXcUV_l8BWA Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-53faf9e6195so332259e87.0 for ; Wed, 08 Jan 2025 03:05:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736334321; x=1736939121; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=trml50sw/T0GyuPoSlgvstnBQNAhlSOGbKtL2CjSR+c=; b=HDXy+IgXGX/6mA2/tYvVQS94pVj9qHXaPGEqajQnoYBkPw57DO61lz1H6oymMnw1pk TVmQEym1Djc47Ivc0idUwAV8ajiJjPJ8aswxYzSo14G4LpSaSiuspxrCs204lSfeCnk8 ODZlqaNj6dFQAb99CiQJukKDttWFoEiPgukFQLtQ6Qsf0vc7Wuc2h3z8fqXLCpy/xjKp 2fmxEt56ZK1n9INgaesAxLEBn8fvMaoFWUEdS6RWAKz21O3y8Arsw7lGJymdeOiIDCX5 dQjh89CxSTP5ICjLjFP7o72rrR4zchqPlsLUXgFLRIKqL3++NyCV6jAjBpTMv6xQH1an uPrA== X-Forwarded-Encrypted: i=1; AJvYcCXYllfLzuE/wpQDOQdOzNcDj4nbgbhuOpq37XA+kFg/3YS3JbBSfQ+mZmzaaO0MT6mhoBE=@dpdk.org X-Gm-Message-State: AOJu0YwScihlQvTF/ZzKmK7Dc8hQeBu0xPVdgYA5yHo6pRlwhZzVOFPK 9LEKVhsc6Yqba7oNU9fzVUUFWJXtt1o8zbKQKQQW3xpIaYflRXsNlyCa3WWDqLP1ryK2y7B5S/J hG2BOBRkwyv6ewy5pbpR9GMgIs05RpFi2G0+ymzgb0ePx+mhS7npoyQuXkmFb1zsCmKObmID/k3 v/EvxIbFZFqK1HyuY= X-Gm-Gg: ASbGnctWrvnFF0/JOlhgdndPidX138pBeQdVcTT51Ejdih7dKRZpyb/odH9CB5Lyoyu BND3aHDx8v8Ok7ku84zLDNUcf3yOFYIGlP20PQBko X-Received: by 2002:a05:6512:1396:b0:540:2fbb:22fe with SMTP id 2adb3069b0e04-54283df3080mr744924e87.26.1736334321306; Wed, 08 Jan 2025 03:05:21 -0800 (PST) X-Google-Smtp-Source: AGHT+IErAXdqBy3g5Kokpbn5v8Be7W++09fFNAb026Fx17V6br1ggOmeVgeV18z1dOj2EqQls/DQ5Kt4wG47tDVBRIQ= X-Received: by 2002:a05:6512:1396:b0:540:2fbb:22fe with SMTP id 2adb3069b0e04-54283df3080mr744881e87.26.1736334320875; Wed, 08 Jan 2025 03:05:20 -0800 (PST) MIME-Version: 1.0 References: <1710968771-16435-1-git-send-email-roretzla@linux.microsoft.com> <1735670291-23224-1-git-send-email-andremue@linux.microsoft.com> <1735670291-23224-3-git-send-email-andremue@linux.microsoft.com> In-Reply-To: <1735670291-23224-3-git-send-email-andremue@linux.microsoft.com> From: David Marchand Date: Wed, 8 Jan 2025 12:05:10 +0100 X-Gm-Features: AbW1kvYfcpBBd1kjYsAdLEWBSY_IddOsv32-Nj1SZOYV22Uc8Sxv5eEqG0HT15I Message-ID: Subject: Re: [PATCH v8 02/29] eal/include: add new packing macros To: Andre Muezerie Cc: roretzla@linux.microsoft.com, aman.deep.singh@intel.com, anatoly.burakov@intel.com, bruce.richardson@intel.com, byron.marohn@intel.com, conor.walsh@intel.com, cristian.dumitrescu@intel.com, david.hunt@intel.com, dev@dpdk.org, dsosnowski@nvidia.com, gakhil@marvell.com, jerinj@marvell.com, jingjing.wu@intel.com, kirill.rybalchenko@intel.com, konstantin.v.ananyev@yandex.ru, matan@nvidia.com, mb@smartsharesystems.com, orika@nvidia.com, radu.nicolau@intel.com, ruifeng.wang@arm.com, sameh.gobriel@intel.com, sivaprasad.tummala@amd.com, skori@marvell.com, stephen@networkplumber.org, suanmingm@nvidia.com, vattunuru@marvell.com, viacheslavo@nvidia.com, vladimir.medvedkin@intel.com, yipeng1.wang@intel.com X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: btyQRX8vo5hfROCb3_yqATl8hGokW4h3dx2CTWBj8V0_1736334321 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Dec 31, 2024 at 7:38=E2=80=AFPM Andre Muezerie wrote: > diff --git a/lib/eal/include/rte_common.h b/lib/eal/include/rte_common.h > index 4d299f2b36..40592f71b1 100644 > --- a/lib/eal/include/rte_common.h > +++ b/lib/eal/include/rte_common.h > @@ -99,13 +99,32 @@ typedef uint32_t unaligned_uint32_t; > typedef uint16_t unaligned_uint16_t; > #endif > > +/** > + * @deprecated > + * @see __rte_packed_begin > + * @see __rte_packed_end > + * > + * Force a structure to be packed > + */ > +#ifdef RTE_TOOLCHAIN_MSVC > +#define __rte_packed RTE_DEPRECATED(__rte_packed) > +#else > +#define __rte_packed (RTE_DEPRECATED(__rte_packed) __attribute__((__pack= ed__))) > +#endif > + We can't mark __rte_packed as deprecated so "early" in the series. Instead, this must be moved as a last patch, to avoid breaking compilations in the middle of the series. --=20 David Marchand