From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 171C4459AC; Mon, 16 Sep 2024 11:32:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0AAFE4025F; Mon, 16 Sep 2024 11:32:47 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 3ECD040041 for ; Mon, 16 Sep 2024 11:32:45 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1726479164; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QJwVh7DjzDlvXw4CM+QoBM3M65NTB/PoiQ6+4/jqbJ4=; b=Y08DtImwz06Oz+wDlSbeZ5/+WJrwknHEmi5h7Ils9X3smxbPclwzABGOg5Xd1+3yk6dKBo 7vHpmfadwTqovEFIZbogVYdu+SpUiysUHZf0BgmsZMqPO5XS0VAu+c3KXidZKwvt2Q6Ahl UgzjfpRoQOGd2DBUI/Po0Af1NcesUnU= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-575-Ef0BIciAMa-QAiuH-7Xhew-1; Mon, 16 Sep 2024 05:32:43 -0400 X-MC-Unique: Ef0BIciAMa-QAiuH-7Xhew-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2f75c8181c0so35264351fa.0 for ; Mon, 16 Sep 2024 02:32:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726479161; x=1727083961; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QJwVh7DjzDlvXw4CM+QoBM3M65NTB/PoiQ6+4/jqbJ4=; b=ekQ6aGTEQirN//42hLBIzQs3Mqxm9RVPYyCmN6ooeNpD/Wpdgk+Lvv3ALKRu011u0U LNJiNvKWwA3McQeCQP2WPavG+5/tnZTFhFWNTOGlHIVMAsKdgHnqwEPzp8t7R74iLUGd XtC6w7Rh3cxmt4Kdsi6aqXrdY2dUtk239jOFEiV406/c5sNVbgnbmbAY3BdcRiHTj90C gNgzk6gCksbV/lB539vy4uJ3urtxA9Tz3+bmHtejmpZPeorR3g6Kx57JGUfCj43yGXmS j4T/XlcQ5HKs7QogzgW3HpINVy0+ccBmXJKJ9Pm4RKC3gxl4phE5S7JQRBAmsKiJhMB0 OcYA== X-Gm-Message-State: AOJu0YxFFX6dkiqThU3oync3UF2XeQDMEsNiBr10413Gxp++9yjm0YI8 OzMjVnhPkBbohfvdKy2OmfUyadZ6ampdxueeIgKmSUG+x7Bk+UMnVPAEienvXqVvgvNw6m2qlHJ 1oaOJPFvyHHtSO/ZrZAdM16pxcjCn2hDi0fbEDHLNTmdM+tgZ1uBe3wvRqzpRr20nXwKEZIYnut FkU4t33C2dwFyeSQKK+dFSYHdpUL6E X-Received: by 2002:a2e:84a:0:b0:2f3:ed34:41c9 with SMTP id 38308e7fff4ca-2f7a3282758mr14891911fa.37.1726479161235; Mon, 16 Sep 2024 02:32:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEcCHkOGf7vNVPZbQ3B+5Jr0Q0FaM+RPCVKAh139oJomCoB7gWAttIenNfbzoMLLOu9jwNheNHpJDUAmZQdsw0= X-Received: by 2002:a2e:84a:0:b0:2f3:ed34:41c9 with SMTP id 38308e7fff4ca-2f7a3282758mr14891831fa.37.1726479160606; Mon, 16 Sep 2024 02:32:40 -0700 (PDT) MIME-Version: 1.0 References: <20240907145433.1479091-1-david.marchand@redhat.com> <20240912082643.1532679-1-david.marchand@redhat.com> In-Reply-To: <20240912082643.1532679-1-david.marchand@redhat.com> From: David Marchand Date: Mon, 16 Sep 2024 11:32:28 +0200 Message-ID: Subject: Re: [PATCH v2 00/14] Use RTE_LOG_LINE in drivers To: dev@dpdk.org, Patrick Robb X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Sep 12, 2024 at 10:27=E2=80=AFAM David Marchand wrote: > > This is a continuation of the cleanup effort in logging macros. > > As a reminder of what this series is about, RTE_LOG_LINE() has been > introduced to check that the format string does not contain a trailing \n= . > The goal was to prevent from: > - introducing multilines log messages (ugly and unhelpful for lambda > users), > - introducing double \n in logs, > - introducing missing \n in logs, > > I have built/maintained this series for fixing drivers/ since the > beginning of the year and I hope we can merge this series early in > 24.11. > > Some drivers are not converted because of multiple inconsistencies. > Those may be fixed later. > > As for the changes on lib/, new macros have been introduced so that > backports trigger a build error and force the backport to adjust the > patches containing logs accordingly. > > > Most of the changes have been done with some scripting, but it is likely > there are some errors and I hope driver maintainers will review in > depth. > > > A check is added for drivers/ in the hope that new drivers don't > introduce more mess. > > Yet, sometimes it is not possible to fix macros (a good example > is base/ drivers code...), so the check skips *osdep.h headers where > calls to RTE_LOG() may be accepted. One note, there is an issue with the crypto_perf_cryptodev_perf test in (legacy) DTS. It (non explicitly) relied on the presence of an extra empty line, and the fact that a line would not contain special chars like : (what a joy..). I posted a fix for DTS. https://patchwork.dpdk.org/project/dts/patch/20240916092515.1851927-1-david= .marchand@redhat.com/ --=20 David Marchand