From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E49CA009E for ; Sun, 27 Oct 2019 11:04:48 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B46321BF1B; Sun, 27 Oct 2019 11:04:46 +0100 (CET) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 692C61BF19 for ; Sun, 27 Oct 2019 11:04:45 +0100 (CET) Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AF82FC049E10 for ; Sun, 27 Oct 2019 10:04:44 +0000 (UTC) Received: by mail-vk1-f198.google.com with SMTP id a130so3397292vke.0 for ; Sun, 27 Oct 2019 03:04:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qwxUslhlTP8u2zvGIM0T4ylH5DTwMIYrtYuCZDEyp7M=; b=OfbC36iJi4dJ6r/QDygoKO28jY3FSVe0U8ccdqle++wyvsvZG+lMcv9YbDzVcMyV9q JtOVMV59V3Gb/aCYzss+cjhp1iPOgA+bdeswa2r476tBlNi/9hIJJgI0JfpoDNurHlnO JyAIbGI391E9R7x2Z5znz4O45sXdsyej6j3RI9xvAEq/he4M3OLXLyR7J/tEVX5Q/ih8 J0TiC61s3gocTgbFgcLzokqMGUNsVzLuMGsSocufZpLIq6KZ8/GwaEG+y+e1xe0Cyajv QNoCYJI4rFJB7cRGlvH50JZIxXSeL/+w2FZaUsjac6zEO1ayjZrsJSvWYM9KERduEQKi BWiw== X-Gm-Message-State: APjAAAXmLqXjY1HWNcxqnLbgPujH4Bs8MtV4150uTGrDayMKthc5d1F2 d6nCOX1NG3tomGHO1/O1Ad/o+s3ng+Ry7VRmZj+K5kCCVUVg0KmRxbNDV61Rz34SNFZ0KLO96Xq vJ9cYwCCqSLrzmqrbSHs= X-Received: by 2002:ab0:304e:: with SMTP id x14mr5920349ual.41.1572170683921; Sun, 27 Oct 2019 03:04:43 -0700 (PDT) X-Google-Smtp-Source: APXvYqy6zIAOo76IOWSiYew6J7/xM96jsnpcjOx9V4qAxEcfZlcy6gFkvYcGm1qnEi0lu2NHZjxeryENmy+DQ2ECNpo= X-Received: by 2002:ab0:304e:: with SMTP id x14mr5920338ual.41.1572170683576; Sun, 27 Oct 2019 03:04:43 -0700 (PDT) MIME-Version: 1.0 References: <1565807801-72546-1-git-send-email-drc@linux.vnet.ibm.com> <1565807801-72546-2-git-send-email-drc@linux.vnet.ibm.com> In-Reply-To: <1565807801-72546-2-git-send-email-drc@linux.vnet.ibm.com> From: David Marchand Date: Sun, 27 Oct 2019 11:04:32 +0100 Message-ID: To: David Christensen Cc: Maxime Coquelin , Tiwei Bie , dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/2] config: fix RHEL7.6 build errors on Power 9 systems X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Aug 14, 2019 at 8:37 PM David Christensen wrote: > > gcc 4.8.5 used on RHEL 7.6 can identify a Power 9 CPU but cannot generate > Power 9 code when the "-mcpu=native" command line argument is used. Test > whether the compiler can generate Power 9 code and adjust the machine > setting appropriately. > > Signed-off-by: David Christensen > --- > config/ppc_64/meson.build | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/config/ppc_64/meson.build b/config/ppc_64/meson.build > index 0e65f9d..495ef6f 100644 > --- a/config/ppc_64/meson.build > +++ b/config/ppc_64/meson.build > @@ -7,6 +7,16 @@ endif > dpdk_conf.set('RTE_ARCH', 'ppc_64') > dpdk_conf.set('RTE_ARCH_PPC_64', 1) > > +# RHEL 7.x uses gcc 4.8.X which doesn't generate code for Power 9 CPUs, > +# though it will detect a Power 9 CPU when the "-mcpu=native" argument > +# is used, resulting in a build failure. > +power9_supported = cc.has_argument('-mcpu=power9') > +if not power9_supported > + machine = 'power8' > + machine_args = ['-mcpu=power8', '-mtune=power8'] > + dpdk_conf.set('RTE_MACHINE','power8') Fixed indent. > +endif > + > # overrides specific to ppc64 > dpdk_conf.set('RTE_MAX_LCORE', 1536) > dpdk_conf.set('RTE_MAX_NUMA_NODES', 32) > -- > 1.8.3.1 > Applied, thanks. -- David Marchand