From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9754CA0524; Fri, 27 Nov 2020 10:26:17 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 64AB5C930; Fri, 27 Nov 2020 10:26:16 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 34BCCC90E for ; Fri, 27 Nov 2020 10:26:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606469172; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9LjXtxwr76xZGFuDGxWYKbvS6Cg0NgN5JnLCT34WaLA=; b=XFQYeUzQqJRLjx/ZxJZwzpC/hMNQIa4fa/7juIPH72KPOz0NKgjsLrjg6KSs1BRC78PPqt CPi6zd1Vkbp3HPthRTVLKyfrnbfW8lnYNBqMSsEjD2pjbOzEsUoXaNFUwnBQ/Krj8QSgz7 uSn9FEppGAtpnYMs1ojiLDGhRxb70NA= Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com [209.85.217.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-226-kGzhHiupOhuoLPk0au8YzA-1; Fri, 27 Nov 2020 04:26:08 -0500 X-MC-Unique: kGzhHiupOhuoLPk0au8YzA-1 Received: by mail-vs1-f72.google.com with SMTP id g3so572736vso.1 for ; Fri, 27 Nov 2020 01:26:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=9LjXtxwr76xZGFuDGxWYKbvS6Cg0NgN5JnLCT34WaLA=; b=tS9N9YyDcKTHH4taCMj2mxZ7xdBUl9tjNZO8UsXjRddQdJLBuJyMQwLnfDbbK3TKq/ T+yEwQWI/ZX+C+IgAXP+XghtX8jzMh2Wsfat7/qeaNyYVgWRbd2k1g+Yhas51PXhUHH+ mx5WLgKEihw6LPcVX4GZILymfkgTY3GvKuaCR+hd5MoUhAprp0zR3tVvqp/uEWvMn9UH jRdKJhazId0+Im9hF04hdR2mGYxhTKlmXASjrDaWSSNFJyKJN69wp0Z75Fb8c0MMglan Y7hq+lvLgtGWSPScJAWkdGKi7EYyiGu2/e0NmHDWXrYAfRbUDaqhP9uXhXlSGRzo3R/Z +8ZA== X-Gm-Message-State: AOAM530eqD04lPl1Era41u4Yc46u93yQWEowtdTVeOSdb2SXUXV1FHa9 iV5x5FVZnH6wew/3kT2irjJDE914YErO3ZVs3azFbAUl7vCphahh+lQt1CAO11JBSvFqYBaqgpr EPaCdDFFjKJDdJ/HJ0c0= X-Received: by 2002:a05:6102:4b6:: with SMTP id r22mr4684020vsa.10.1606469167989; Fri, 27 Nov 2020 01:26:07 -0800 (PST) X-Google-Smtp-Source: ABdhPJyP8Ncfh7h1wCflPVD16y7ZY9EMrTdGs0bMrNd6t58oUWwgA0It7a4LN8wMbUeXzkUQLaqh3OzvQNzG7ZUBO6k= X-Received: by 2002:a05:6102:4b6:: with SMTP id r22mr4684013vsa.10.1606469167783; Fri, 27 Nov 2020 01:26:07 -0800 (PST) MIME-Version: 1.0 References: <20201127080903.26817-1-ruifeng.wang@arm.com> <20201127080903.26817-2-ruifeng.wang@arm.com> In-Reply-To: From: David Marchand Date: Fri, 27 Nov 2020 10:25:56 +0100 Message-ID: To: Ruifeng Wang , Andrew Rybchenko Cc: Jerin Jacob , Honnappa Nagarahalli , dev , nd , Feifei Wang , Jerin Jacob Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 1/2] eal/arm: fix gcc build for optimization level 0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Nov 27, 2020 at 9:51 AM Jerin Jacob wrote: > > On Fri, Nov 27, 2020 at 2:09 PM David Marchand > wrote: > > > > On Fri, Nov 27, 2020 at 9:10 AM Ruifeng Wang wro= te: > > > > > > Gcc build with '-O0' on platforms with RTE_ARM_FEATURE_ATOMICS set > > > failed for: > > > ../lib/librte_efd/rte_efd.c > > > Assembler messages: > > > 3866: Error: selected processor does not support `crc32cb w0,w0,w1' > > > 3890: Error: selected processor does not support `crc32ch w0,w0,w1' > > > 3914: Error: selected processor does not support `crc32cw w0,w0,w1' > > > 3938: Error: selected processor does not support `crc32cx w0,w0,x1' > > > > > > This was caused by an architecture specifier added for Clang. > > > Unlike Clang, Gcc considers each inline assembly block to be dependen= t > > > and therefor, the architecture specifier impacts assemble of some > > > blocks require certain extension support. > > > > I reproduced this error with -O0 for config/arm/arm64_octeontx2_linux_g= cc. > > The patch looks simple enough and it only affects ARM builds. > > > > Jerin, > > Are you okay with this change for 20.11? > > Or should we wait 21.02? > > I could reproduce the issue with meson build -Dbuildtype=3Ddebug > --cross-file config/arm/arm64_octeontx2_linux_gcc > > This fix is OK. Request to merge for 20.11 > > Acked-by: Jerin Jacob Ruifeng, Andrew, I get a compilation error with this patch on sfc using gcc and config/arm/arm64_octeontx2_linux_gcc config + --buildtype=3Ddebug and/or -Dc_args=3D-O0 . aarch64-linux-gnu-gcc (GNU Toolchain for the A-profile Architecture 8.2-2019.01 (arm-rel-8.28)) 8.2.1 20180802 FAILED: drivers/common/sfc_efx/base/932d09a@@sfc_base@sta/efx_crc32.c.o aarch64-linux-gnu-gcc -Idrivers/common/sfc_efx/base/932d09a@@sfc_base@sta -Idrivers/common/sfc_efx/base -I../../dpdk/drivers/common/sfc_efx/base -Idrivers/common/sfc_efx -I../../dpdk/drivers/common/sfc_efx -I. -I../../dpdk/ -Iconfig -I../../dpdk/config -Ilib/librte_eal/include -I../../dpdk/lib/librte_eal/include -Ilib/librte_eal/linux/include -I../../dpdk/lib/librte_eal/linux/include -Ilib/librte_eal/arm/include -I../../dpdk/lib/librte_eal/arm/include -Ilib/librte_eal/common -I../../dpdk/lib/librte_eal/common -Ilib/librte_eal -I../../dpdk/lib/librte_eal -Ilib/librte_kvargs -I../../dpdk/lib/librte_kvargs -Ilib/librte_telemetry/../librte_metrics -I../../dpdk/lib/librte_telemetry/../librte_metrics -Ilib/librte_telemetry -I../../dpdk/lib/librte_telemetry -fdiagnostics-color=3Dalways -pipe -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Werror -g -include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-packed-not-aligned -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=3Darmv8.2-a+crc+crypto+lse -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation -Wdisabled-optimization -Waggregate-return -Wbad-function-cast -Wno-sign-compare -Wno-unused-parameter -Wno-unused-variable -Wno-empty-body -Wno-unused-but-set-variable -MD -MQ 'drivers/common/sfc_efx/base/932d09a@@sfc_base@sta/efx_crc32.c.o' -MF 'drivers/common/sfc_efx/base/932d09a@@sfc_base@sta/efx_crc32.c.o.d' -o 'drivers/common/sfc_efx/base/932d09a@@sfc_base@sta/efx_crc32.c.o' -c ../../dpdk/drivers/common/sfc_efx/base/efx_crc32.c In file included from ../../dpdk/lib/librte_eal/arm/include/rte_atomic.h:9, from ../../dpdk/lib/librte_eal/include/generic/rte_pause.h= :19, from ../../dpdk/lib/librte_eal/arm/include/rte_pause_64.h:= 19, from ../../dpdk/lib/librte_eal/arm/include/rte_pause.h:13, from ../../dpdk/lib/librte_eal/include/generic/rte_spinlock.h:25, from ../../dpdk/lib/librte_eal/arm/include/rte_spinlock.h:= 17, from ../../dpdk/drivers/common/sfc_efx/efsys.h:15, from ../../dpdk/drivers/common/sfc_efx/base/efx.h:11, from ../../dpdk/drivers/common/sfc_efx/base/efx_crc32.c:7: ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h: In function =E2=80=98__cas_128_relaxed=E2=80=99: ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h:81:20: error: function returns an aggregate [-Werror=3Daggregate-return] __ATOMIC128_CAS_OP(__cas_128_relaxed, "casp") ^~~~~~~~~~~~~~~~~ ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h:57:1: note: in definition of macro =E2=80=98__ATOMIC128_CAS_OP=E2=80=99 cas_op_name(rte_int128_t *dst, rte_int128_t old, rte_int128_t updated) = \ ^~~~~~~~~~~ ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h: In function =E2=80=98__cas_128_acquire=E2=80=99: ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h:82:20: error: function returns an aggregate [-Werror=3Daggregate-return] __ATOMIC128_CAS_OP(__cas_128_acquire, "caspa") ^~~~~~~~~~~~~~~~~ ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h:57:1: note: in definition of macro =E2=80=98__ATOMIC128_CAS_OP=E2=80=99 cas_op_name(rte_int128_t *dst, rte_int128_t old, rte_int128_t updated) = \ ^~~~~~~~~~~ ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h: In function =E2=80=98__cas_128_release=E2=80=99: ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h:83:20: error: function returns an aggregate [-Werror=3Daggregate-return] __ATOMIC128_CAS_OP(__cas_128_release, "caspl") ^~~~~~~~~~~~~~~~~ ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h:57:1: note: in definition of macro =E2=80=98__ATOMIC128_CAS_OP=E2=80=99 cas_op_name(rte_int128_t *dst, rte_int128_t old, rte_int128_t updated) = \ ^~~~~~~~~~~ ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h: In function =E2=80=98__cas_128_acq_rel=E2=80=99: ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h:84:20: error: function returns an aggregate [-Werror=3Daggregate-return] __ATOMIC128_CAS_OP(__cas_128_acq_rel, "caspal") ^~~~~~~~~~~~~~~~~ ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h:57:1: note: in definition of macro =E2=80=98__ATOMIC128_CAS_OP=E2=80=99 cas_op_name(rte_int128_t *dst, rte_int128_t old, rte_int128_t updated) = \ ^~~~~~~~~~~ cc1: all warnings being treated as errors If I waive those warnings: - next to fail is net/igc (fixed by next patch so ok) - and then next to fail is net/sfc. --=20 David Marchand