From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03F8A43C84; Mon, 11 Mar 2024 08:44:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 88304402DE; Mon, 11 Mar 2024 08:44:55 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 2D110402AE for ; Mon, 11 Mar 2024 08:44:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710143093; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hhRdmkr8Sf4YPrCwiyOaM5RCrI2Zc3M3iAqYBToKm9M=; b=PUU68PHl6+P0ZsWC3Ky34szNxKoiutRLTNod2pgOx0PSupg6rAOiFJBZ0faBqnxWkOvxd3 T1G1gUi2mvwoC8wUzV5duRYZ1LyzRBZR4/EVtszBqrU4I+Vry/JfbVWgl9X+QxuSXq+N1p hIMFzvbK/gf0+qzT7D/bMBpsmA1J/BQ= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-461-T63dmjiePmadZ_N1noM6FQ-1; Mon, 11 Mar 2024 03:44:52 -0400 X-MC-Unique: T63dmjiePmadZ_N1noM6FQ-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2d3fb557a1cso22282791fa.3 for ; Mon, 11 Mar 2024 00:44:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710143090; x=1710747890; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hhRdmkr8Sf4YPrCwiyOaM5RCrI2Zc3M3iAqYBToKm9M=; b=Aa1pQnV0mx3PYEtVH9AhFILrJMDutXR8FwKMK7NDtnekMaa1Z+YBeGuQdQVfQxGoMv Of+sfzanuQ/WZPG3hO0y3BB4+fPhZ4WITKigRbAvjLYnoqPWhskJWbT9FGdX9nBNtOb8 XU6Uqp0fmqTGzsoJtyYmeWtBWFvDmdHKyknILwGC0zekLgdU4Oy7fc+qBWO3PjBc2FWl m2uiZ8iQONh0jL1MJ60q8A1GK3dAklEQJQ5HRG7/P8vsgiYyBgM6LembnqZktQqB+Om3 4nNlqaJRD/YIlrf1UButYZR+JWrgg/PWjer5UC0QbNDyoLjDKNUw2BvH1IRVCyJFdj75 md8w== X-Forwarded-Encrypted: i=1; AJvYcCUeNo0QVAij0kJeA2dZozlmbwpYDy8tEQ1OGffPZYJGb7/uRHe4XWr49iA+PnvcViDPquVVap9i4jbPwic= X-Gm-Message-State: AOJu0Yw3NBiTHJItSWvL0sE8qsH5fHp2QlO7eeEHy4Up1mu2xq4Cq7rG 8znC3sacYRsFrKq3WCE7YClWH7OSHRRGH5zJDW8HWH/TAkmJ6mrp501+YRa7A8Kyc3kuLZLtCBs WItUL0C5qBv94AiEnzNy15Mc0l4Pb0e7Nw075Zy+dUEKImCi4IK9ReCwM7QpLcy73mBospe/tWM KGh2TPbTJ8eULQhZw= X-Received: by 2002:a2e:7e0a:0:b0:2d2:d3de:44fd with SMTP id z10-20020a2e7e0a000000b002d2d3de44fdmr3447895ljc.29.1710143090729; Mon, 11 Mar 2024 00:44:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGGhGUzcpa0AZf5U/svyu/lHttFRHucUX03vxyJTY62ltcyLRzArbUphL5LOXS73+gMRNikjK7+W4/8MtWXDLU= X-Received: by 2002:a2e:7e0a:0:b0:2d2:d3de:44fd with SMTP id z10-20020a2e7e0a000000b002d2d3de44fdmr3447889ljc.29.1710143090434; Mon, 11 Mar 2024 00:44:50 -0700 (PDT) MIME-Version: 1.0 References: <20230927150854.3670391-2-paul.szczepanek@arm.com> <20240307203943.188101-1-paul.szczepanek@arm.com> In-Reply-To: From: David Marchand Date: Mon, 11 Mar 2024 08:44:38 +0100 Message-ID: Subject: Re: [PATCH v7 0/4] add pointer compression API To: Honnappa Nagarahalli Cc: Paul Szczepanek , "dev@dpdk.org" , "thomas@monjalon.net" , "Mcnamara, John" , nd , Wathsala Wathawana Vithanage X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sun, Mar 10, 2024 at 8:35=E2=80=AFPM Honnappa Nagarahalli wrote: > > We mentionned during the weekly release meeting, it seemed too late > > for merging this work in the 24.03 release. > > > > Looking at v8, I have comments on this series: > > - rather than put a Depends-on: tag, take the lib: patch as part of > > your series, there is no need for this patch without the ptr_compress > > lib and it will avoid any CI issue (ovsrobot does not support > > Depends-on: patch- for example), > Agree, this is a better solution > > > - lib/ptr_compress/version.map is unneeded now, > > - lib/ptr_compress/, app/test/test_ptr_compress.c and > > doc/guides/prog_guide/ptr_compress_lib.rst need a MAINTAINERS entry, > > - prefer lowercase characters for mail addresses in commitlogs, > > - the documentation is not referenced in doc/guides/prog_guide/index.rs= t, > > - doxygen does not know of this new library, you must update > > doc/api/doxy-api-index.md and doc/api/doxy-api.conf.in, > > - a RN entry is missing, > Apologies for missing these. > > > > > There were also comments on the lib: patch. > Not sure which comments you are talking about. Your comments on V7 were a= ddressed in V8. http://inbox.dpdk.org/dev/ZemoDBHt6fMBUqne@bricha3-mobl1.ger.corp.intel.com= /T/#m665026fb0c7ed832d3e80b68b16d7549124f6880 --=20 David Marchand