From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63C30A0C48; Tue, 20 Jul 2021 14:14:36 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F3E5D40689; Tue, 20 Jul 2021 14:14:35 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 3DFE240140 for ; Tue, 20 Jul 2021 14:14:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626783273; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=YRKQjux+hTm+k0KXUzcVz576PhiYnGvxC/sA79p4CSs=; b=iBKYwe60EOnnpHVE2UZoLkbv6ZLb+UY7TLF9mN9Zg0LBwExaWWrsgz0PACX03y4HrajKke kiJQQMXkPCs3Xc2yqzNZgWMmUn8W7qq07p0JA9lHKlA97obSKBCOuB8b2b8p3vKgcnIB0b nwoe7/9vtt2+h7bkNJ4GarV6uVMOVKk= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-312-Lb286PJvOL6_MVFoaXfXMw-1; Tue, 20 Jul 2021 08:14:30 -0400 X-MC-Unique: Lb286PJvOL6_MVFoaXfXMw-1 Received: by mail-vk1-f200.google.com with SMTP id 5-20020a1f13050000b0290256e3ea37c1so3839321vkt.1 for ; Tue, 20 Jul 2021 05:14:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YRKQjux+hTm+k0KXUzcVz576PhiYnGvxC/sA79p4CSs=; b=ce/UUxHQuTZ35cnGnv3NxAOTQ87dynEo0tG2YJkZdxAiJEVif8vOgl+ou1pdVK1PXQ 7gmNeRQodjQmqmBIu4E4ApBJb4S8tyWTtgE6Nni28JZMDcHl6UGMcK502o+7gHJ+6KNC Ezosx5GyWfvfOcL/sCGqDAuOu96Xv4IMNhfRrtCdlwynEubxix3Va0p5zNkSTliKutCt hL1rB1nA1lR9y+CCMnfMuatdip6k+gfOiREWVWdhbcTo026dxfOs1GXnXO9ZuxUitmnq OESqaBntQqFnDNnotEQzKpVyl0B2oF6Fu7rCOx5fqTO3YF4aF1ts93l31uZj1q1zloj1 +C5Q== X-Gm-Message-State: AOAM532crmQexu/dE1UxKXvOIAuskuA8gmLs2EA2ch8SNOolEt+X6n+l 76lYln1FghKED48kV/TWy1uGYjG9QeajuNv+LLfgpO+VzEvj4l06+gAdOkGVlvA8ZJZ0LxW2Hy8 70ru+RnijTAod/NSqEzc= X-Received: by 2002:a1f:2608:: with SMTP id m8mr26173955vkm.17.1626783269930; Tue, 20 Jul 2021 05:14:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJykbHc9E7f0HLfNmXoDnc6k3fDVu0xzDka4azVR96px2EZkYWRVaTSOLVKHhBrkZmlEs/u7ahtey7v7PP1mmLQ= X-Received: by 2002:a1f:2608:: with SMTP id m8mr26173928vkm.17.1626783269643; Tue, 20 Jul 2021 05:14:29 -0700 (PDT) MIME-Version: 1.0 References: <2bd2c4be2295105b81843d31c1bcb4dab7e1aff7.1624481225.git.sthotton@marvell.com> In-Reply-To: From: David Marchand Date: Tue, 20 Jul 2021 14:14:18 +0200 Message-ID: To: Akhil Goyal Cc: Thomas Monjalon , Ray Kinsella , dev , Pavan Nikhilesh Bhagavatula , Anoob Joseph , Abhinandan Gujjar , Ankur Dwivedi , Jerin Jacob Kollanukkaran , Aaron Conole , dpdklab , Lincoln Lavoie , Shijith Thotton Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2 1/2] drivers: add octeontx crypto adapter framework X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jul 20, 2021 at 1:59 PM Akhil Goyal wrote: > > Hi David, > > > > > > deps += ['common_octeontx', 'mempool_octeontx', 'bus_vdev', > > > 'net_octeontx'] > > > > +deps += ['crypto_octeontx'] > > > > > > This extra dependency resulted in disabling the event/octeontx driver > > > in FreeBSD, since crypto/octeontx only builds on Linux. > > > Removing hw support triggers a ABI failure for FreeBSD. > > > > > > > > > - This had been reported by UNH CI: > > > http://mails.dpdk.org/archives/test-report/2021-June/200637.html > > > It seems the result has been ignored but it should have at least > > > raised some discussion. > > > > > This was highlighted to CI ML > > http://patches.dpdk.org/project/dpdk/patch/0686a7c3fb3a22e37378a8545b > > c37bce04f4c391.1624481225.git.sthotton@marvell.com/ > > > > but I think I missed to take the follow up with Brandon and applied the patch > > as it did not look an issue to me as octeon drivers are not currently built on > > FreeBSD. > > Not sure why event driver is getting built there. > > > > > > > > - I asked UNH to stop testing FreeBSD abi for now, waiting to get the > > > main branch fixed. > > > > > > I don't have the time to look at this, please can you work on it? > > > > > > Several options: > > > * crypto/octeontx is made so that it compiles on FreeBSD, > > > * the abi check is extended to have exceptions per OS, > > > * the FreeBSD abi reference is regenerated at UNH not to have those > > > drivers in it (not sure it is doable), > > > > Thanks for the suggestions, we are working on it to resolve this as soon as > > possible. > > We may need to add exception in ABI checking so that it does not shout if a > > PMD > > is not compiled. > Can we have below change? Will it work to disable compilation of > event/octeontx2 for FreeBSD? I believe this was done by mistake earlier > as all other octeontx2 drivers are compiled off on platforms other than Linux. > > diff --git a/drivers/event/octeontx2/meson.build b/drivers/event/octeontx2/meson.build > index 96ebb1f2e7..1ebc51f73f 100644 > --- a/drivers/event/octeontx2/meson.build > +++ b/drivers/event/octeontx2/meson.build > @@ -2,7 +2,7 @@ > # Copyright(C) 2019 Marvell International Ltd. > # > > -if not dpdk_conf.get('RTE_ARCH_64') > +if not is_linux or not dpdk_conf.get('RTE_ARCH_64') > build = false > reason = 'only supported on 64-bit' > subdir_done() I did not suggest this possibility. That's the same as for other octeon drivers, such change has been deferred to 21.11. https://patches.dpdk.org/project/dpdk/list/?series=15885 > > Or of this does not work, then we would need to add exception in ABI checking. > Any suggestions how to do this? Sorry, no good idea from me. -- David Marchand