From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8153423A2; Tue, 10 Jan 2023 12:27:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9372842D11; Tue, 10 Jan 2023 12:27:48 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D69AF40A8B for ; Tue, 10 Jan 2023 12:27:47 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673350067; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7KXlyzKZL7UIpTJoQQOnzqW0YxrVElm/6ImOeVqVDEc=; b=N2J3t4EaEg4dOG5r7FZIpZH3j/YH7f+uQR5qzSrg7GHQyEAjfYdl+dqP2EgiyXx5XtvU3c FJuBWkZ2JQHOswZ5Kr24lwzXLylB74XVmvgCEWXla9eRHo6RUOp4Yj4vPixda5tJUdwVa9 RfLy6MygmssfZO/pvvBbjI+0Uzxgi+Q= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-464-Gr5K1HrxPHKELp0phsCLVg-1; Tue, 10 Jan 2023 06:27:46 -0500 X-MC-Unique: Gr5K1HrxPHKELp0phsCLVg-1 Received: by mail-pj1-f72.google.com with SMTP id z4-20020a17090ab10400b002195a146546so9066583pjq.9 for ; Tue, 10 Jan 2023 03:27:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7KXlyzKZL7UIpTJoQQOnzqW0YxrVElm/6ImOeVqVDEc=; b=HkxaMzbMu4YYeSAY2IleRXxSB0c2OkyAFgwmUr6+/lfoAsboVmx6Pe9dOvPVb/yq9B gaDvkmNfBHsYFCpHj+wCqVeaPTEZCJS4KcRq/Hn7aUAHU+bDV/mXvjFMWcOv9X3p+A6j JUKDKJtNvQuEChNqvvWEEt9JiSCUN38N5LcL+U8hIYCTj4DC/6WR8nhqAAQO9C87wD6o FxM88E7zNQU4AmHNmzBcdp6mLcVXZcNy2fAvlWEYISzRUDGYeIbM1E6uBTRNcG1ROym3 DuZGr5bAEm5zaMccZqeyLCkDXI7j7swveTBc45o1B3kmpQrrdA76ixFTQTpH56VsNbUn RgWg== X-Gm-Message-State: AFqh2kqEabof/BHRzhHsIO/vkz0h/LTjiusGj8H15YLBO+YSPGL/CPVb MEmADdnUfLw1iYRVjo5wFQgYpmj7SrkglToq3Au0XeyAYGJNbTZ8Si33wlguCD3Dr3hZEkk6am7 xL/I9o3qyEPk3+tKF9zg= X-Received: by 2002:aa7:9584:0:b0:582:46a4:87dc with SMTP id z4-20020aa79584000000b0058246a487dcmr2823636pfj.2.1673350065145; Tue, 10 Jan 2023 03:27:45 -0800 (PST) X-Google-Smtp-Source: AMrXdXsx6s8ZUFxjmDhOLWHzqd3i1qdzHXcpkNJuk/I6UJMiyohNEE0kh/7D2VTEwU1C2svdNQdW4MMHWSzPbAcYbIo= X-Received: by 2002:aa7:9584:0:b0:582:46a4:87dc with SMTP id z4-20020aa79584000000b0058246a487dcmr2823632pfj.2.1673350064876; Tue, 10 Jan 2023 03:27:44 -0800 (PST) MIME-Version: 1.0 References: <20230109145448.278463-1-megha.ajmera@intel.com> In-Reply-To: <20230109145448.278463-1-megha.ajmera@intel.com> From: David Marchand Date: Tue, 10 Jan 2023 12:27:33 +0100 Message-ID: Subject: Re: [PATCH] sched: fix for tc_ov_enable flag position in subport structure. To: Megha Ajmera Cc: dev@dpdk.org, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, stable@dpdk.org, marcinx.danilewicz@intel.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jan 9, 2023 at 3:59 PM Megha Ajmera wrote: > > Current position of "tv_ov_enable" variable in tc_ov_enabled* > rte_sched_subport structure makes the "memory" variable unused. I did not enter the beast... but my understanding is that some object internal to rte_sched_subport currently shares location with this tc_ov_enabled field. So please find a better title and describe the impact. > > Fixes: f5e60154ade ("sched: enable traffic class oversubscription conditionally") > CC: marcinx.danilewicz@intel.com This is stable@dpdk.org material, isn't it? > Signed-off-by: Megha Ajmera > --- > lib/sched/rte_sched.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c > index c91697131d..eaecd7ceb4 100644 > --- a/lib/sched/rte_sched.c > +++ b/lib/sched/rte_sched.c > @@ -202,6 +202,9 @@ struct rte_sched_subport { > uint32_t qsize_add[RTE_SCHED_QUEUES_PER_PIPE]; > uint32_t qsize_sum; > > + /* TC oversubscription activation */ > + int tc_ov_enabled; > + > struct rte_sched_pipe *pipe; > struct rte_sched_queue *queue; > struct rte_sched_queue_extra *queue_extra; > @@ -210,8 +213,6 @@ struct rte_sched_subport { > struct rte_mbuf **queue_array; > uint8_t memory[0] __rte_cache_aligned; > > - /* TC oversubscription activation */ > - int tc_ov_enabled; > } __rte_cache_aligned; > > struct rte_sched_port { -- David Marchand