From: David Marchand <david.marchand@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>,
Akhil Goyal <gakhil@marvell.com>
Cc: dev@dpdk.org, Fan Zhang <fanzhang.oss@gmail.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] crytodev: make logtype internal
Date: Thu, 21 Dec 2023 10:28:34 +0100 [thread overview]
Message-ID: <CAJFAV8wwh7we9DcB1i-r2mTOL0q3JTJm7Pw6LWy47-_hzkckwg@mail.gmail.com> (raw)
In-Reply-To: <20231212164118.61936-1-stephen@networkplumber.org>
On Tue, Dec 12, 2023 at 5:41 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> The logtype does not need to be exported as API.
The CDEV_* macros are exported in the public header.
If some external users use them and we take this patch, the user
binary will point at a symbol for which we have no safety barrier (wrt
symbol removal / changes).
Moving those macros to cryptodev_pmd.h is a prerequisite.
--
David Marchand
prev parent reply other threads:[~2023-12-21 9:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 16:41 Stephen Hemminger
2023-12-21 9:28 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wwh7we9DcB1i-r2mTOL0q3JTJm7Pw6LWy47-_hzkckwg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=fanzhang.oss@gmail.com \
--cc=gakhil@marvell.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).