From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46FD84374F; Thu, 21 Dec 2023 10:28:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C984240A4B; Thu, 21 Dec 2023 10:28:51 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id ABC23406B8 for ; Thu, 21 Dec 2023 10:28:50 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703150930; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=r3OKdJQZRxpY+46llmcMAJTcjl01GAtfHSjVoD00YDw=; b=RejpI9xbCMTmNS2RaPwKFibCxJuYI/pqmLoF0rUT1heW7afUYa8Lm62Lyxm5iIhBUOleVL wMP7D8j86fPUZ0lBWsPL++oEOFpzmDcsSZ9pn2dANMr3gy7LzfL1rWzPesjAHCta3+z8qG RKm+Wa7uLkOUmH9+KUcycMRKTDAaS6I= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-604-IbQIPpl6N7aIRTN5t7j7ug-1; Thu, 21 Dec 2023 04:28:47 -0500 X-MC-Unique: IbQIPpl6N7aIRTN5t7j7ug-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-50e2a3a1706so469896e87.1 for ; Thu, 21 Dec 2023 01:28:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703150926; x=1703755726; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r3OKdJQZRxpY+46llmcMAJTcjl01GAtfHSjVoD00YDw=; b=TBseIsggtDx2Zmp0lN4KXmq0RfdlpfjvEhLc4+uuUUHv9F1lc2CSMKzaJSL5vMIYkl YMoeVYNEo/CMKiB6JOuAzEPYSk114qSNbsfF0bWkip2mFeoTaJmxVfhLnE54VU31VOHW WYTMSL04E+IFCEmkO4TgXGmY4k+XCE5H4Qiz8190VrxgU2lI2533ubb8NBv7PdPLyfNL KY9vp6yPhFBkUGQOiFJ2ey/vcVVNhYFw7YNyvyqASo7oECZGmfQWc3Jn1JU0FBmEadIJ pVDKEcBaIA5m1LYczgjHJQb4/L613qBQwGLVnDiQZrJ1KTfwaCfKtC3XeXF1mdWuw4Mc Mt2A== X-Gm-Message-State: AOJu0YzCjLqDZEp32xlBJObU+udXP1x4vJrDvcODVxVebtwLcrh5/e4Y R6HhRuc2qdR/os25x7I7wxeMv1Q9Wd/DzMGALFWMg/L6RLY4Om7BX6TmY7DbVxweyqzZc4POiPe Gele3oTWwcz5YMzRqAbs= X-Received: by 2002:a05:6512:3082:b0:50e:3e42:7422 with SMTP id z2-20020a056512308200b0050e3e427422mr3519963lfd.114.1703150926392; Thu, 21 Dec 2023 01:28:46 -0800 (PST) X-Google-Smtp-Source: AGHT+IHzagH2DiVuogqxSusgUlFyckt7yE8OU+jI3Pv/JnSKDG9mhpdiU4U/oFe+YthtJ4A9CveUAT+ShaFz2wurE7k= X-Received: by 2002:a05:6512:3082:b0:50e:3e42:7422 with SMTP id z2-20020a056512308200b0050e3e427422mr3519951lfd.114.1703150926096; Thu, 21 Dec 2023 01:28:46 -0800 (PST) MIME-Version: 1.0 References: <20231212164118.61936-1-stephen@networkplumber.org> In-Reply-To: <20231212164118.61936-1-stephen@networkplumber.org> From: David Marchand Date: Thu, 21 Dec 2023 10:28:34 +0100 Message-ID: Subject: Re: [PATCH] crytodev: make logtype internal To: Stephen Hemminger , Akhil Goyal Cc: dev@dpdk.org, Fan Zhang , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Dec 12, 2023 at 5:41=E2=80=AFPM Stephen Hemminger wrote: > > The logtype does not need to be exported as API. The CDEV_* macros are exported in the public header. If some external users use them and we take this patch, the user binary will point at a symbol for which we have no safety barrier (wrt symbol removal / changes). Moving those macros to cryptodev_pmd.h is a prerequisite. --=20 David Marchand