From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id BB97B433B5;
Fri, 24 Nov 2023 08:57:14 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 4598F402E1;
Fri, 24 Nov 2023 08:57:14 +0100 (CET)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.133.124])
by mails.dpdk.org (Postfix) with ESMTP id 55B13402B3
for <dev@dpdk.org>; Fri, 24 Nov 2023 08:57:12 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1700812631;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=GgAGceCRdoSHMZGzC9YyX8Nmy880gQdkgJRGMKm+BiE=;
b=EW3LU+XCpe3iGrFn/xiq1zaKcK3sDr63uhnu88VCzIGgJzNmxVX6dGh6TIQPRjiEO07WbZ
gJAzUvwEZNU6Kyo/ukNUzBrQoYP4NlRmD4v4bTjW5T2aFT4qpFJQkMI+pbEppdY/mosCtt
uG+fj2nQ6zg9+tlUiL80fCgKcQGSl38=
Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com
[209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS
(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id
us-mta-86-KsjY1aHBMW2bMHUuYZaRWQ-1; Fri, 24 Nov 2023 02:57:10 -0500
X-MC-Unique: KsjY1aHBMW2bMHUuYZaRWQ-1
Received: by mail-lj1-f198.google.com with SMTP id
38308e7fff4ca-2c8872d92edso12985601fa.2
for <dev@dpdk.org>; Thu, 23 Nov 2023 23:57:09 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1700812628; x=1701417428;
h=content-transfer-encoding:cc:to:subject:message-id:date:from
:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=GgAGceCRdoSHMZGzC9YyX8Nmy880gQdkgJRGMKm+BiE=;
b=EyqI4zBb55RQkJbhONz2df8DxWVUQCabylb9K7SONHiI6xOxFAkOoNoDxQjEUhIHVS
c28URPQP82eA42b0n8lSUPKC8Cl0pbtGZ0M3QfX9jwg57nB5I9keGt2DOnMCw4hB4p4F
ckjIFLV8TnD5vo5xLT9m4HacIR12dU3PsWjUL3RPopMx2saaP/7fMLrA+IsyjBVdz6vC
xZOh8HDBF7hKLLJcDo7kdcM8XTbdsRcP4XN1MFziPkxIdLHJjdKmaSz15yHbUxTmsyhb
CqRpxtwstcsrmXX4iQesldYNTcuLeGxhqFf7URAqFhYvsewrtSP/wg4NBHT/TYiJwBk/
2lEA==
X-Gm-Message-State: AOJu0Yzh+ZcrSjTo5HNQd0x6WXYuTMpeDJU1Y6mrCV31xqEH+rva2A61
qauvL4Kfthj6KEaCZmPyWCNgK/zEhSdOXED0DukPMEPVr0Yg3q6Wil4+cB1vsXcz0q6BTH22YkO
BfrXv1nhtdeUfWDoMuGw=
X-Received: by 2002:a2e:98cf:0:b0:2c5:5926:de4c with SMTP id
s15-20020a2e98cf000000b002c55926de4cmr1323458ljj.32.1700812628595;
Thu, 23 Nov 2023 23:57:08 -0800 (PST)
X-Google-Smtp-Source: AGHT+IGEj1y6vWQ+FCkqCo9n2172DqKbqVhQ0KL/B3C5mIteMaxg9izND0sM9nmFr0v31mXvd7KLkB4iJd8ihAWQbx8=
X-Received: by 2002:a2e:98cf:0:b0:2c5:5926:de4c with SMTP id
s15-20020a2e98cf000000b002c55926de4cmr1323440ljj.32.1700812628203; Thu, 23
Nov 2023 23:57:08 -0800 (PST)
MIME-Version: 1.0
References: <20231114080446.3574237-1-tduszynski@marvell.com>
In-Reply-To: <20231114080446.3574237-1-tduszynski@marvell.com>
From: David Marchand <david.marchand@redhat.com>
Date: Fri, 24 Nov 2023 08:56:56 +0100
Message-ID: <CAJFAV8wxCFwVRtv9hdWH+EmtbmjC0TLWC628KQQE9TFnD3MjPA@mail.gmail.com>
Subject: Re: [PATCH] raw/cnxk_bphy: switch to dynamic logging
To: Tomasz Duszynski <tduszynski@marvell.com>
Cc: dev@dpdk.org, Jakub Palider <jpalider@marvell.com>, jerinj@marvell.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Hello,
On Tue, Nov 14, 2023 at 9:05=E2=80=AFAM Tomasz Duszynski <tduszynski@marvel=
l.com> wrote:
[snip]
> @@ -15,6 +16,11 @@
> #include "cnxk_bphy_irq.h"
> #include "rte_pmd_bphy.h"
>
> +extern int bphy_rawdev_logtype;
> +
> +#define BPHY_LOG(level, fmt, args...) \
> + rte_log(RTE_LOG_ ## level, bphy_rawdev_logtype, "%s(): " fmt "\n"=
, __func__, ##args)
> +
> static const struct rte_pci_id pci_bphy_map[] =3D {
> {RTE_PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, PCI_DEVID_CNXK_BPHY)},
> {
> @@ -81,7 +87,7 @@ bphy_rawdev_selftest(uint16_t dev_id)
> goto err_desc;
> if (descs !=3D 1) {
> ret =3D -ENODEV;
> - plt_err("Wrong number of descs reported\n");
> + BPHY_LOG(ERR, "Wrong number of descs reported\n");
I think it is the only occurence in this patch, please remove trailing
\n since BPHY_LOG appends one.
Thanks.
--=20
David Marchand