From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D17C0A04B5; Tue, 12 Jan 2021 12:17:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 96514140E66; Tue, 12 Jan 2021 12:17:22 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 1982A140E65 for ; Tue, 12 Jan 2021 12:17:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610450240; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UvxvYuyrOzp54vRgWTC/QW6MMKvxKyB8KQku4ZBI30w=; b=dglih46m4n1OrZePjB7RwJJLR9cdsoZ5bS6cbLczmuduMFoJxxRiw5NjE06HqRIXP1jYAm faQ2kKnkCdMS6YqY0OunjH16zZfKhWGAimX/duMbq4osE1Mwc0Gwikq/SC3APxfb4wdHIK suEYrtZMexWrDVmG/Mm4p6PWoiC8gRI= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-437-AKwFZSEENoeEtzvI4Awk1A-1; Tue, 12 Jan 2021 06:17:18 -0500 X-MC-Unique: AKwFZSEENoeEtzvI4Awk1A-1 Received: by mail-vk1-f197.google.com with SMTP id h21so838343vke.22 for ; Tue, 12 Jan 2021 03:17:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UvxvYuyrOzp54vRgWTC/QW6MMKvxKyB8KQku4ZBI30w=; b=diRABSatRl+rP4INRxsRZq17DrGS7DD6vD2d3WakVDbPRyffNFz0mtfO/RnYheFy/u wOsacAKhTAijh/rz3yXlfmkFmf6obgwER/2ZELUKLSC01p2XQFxkc2GPK6EgMWmqscwB yRTdP3NUlRsJlAKgftJKaybKHtH9XW0SIlNa+o3vRUneQKfS4qFHGdi2s5BQgIgF+ILU +U4CV3ktDurwnF3loWBrP4qVq4X7Wm7sREoNPliogzVlzk3Hm9iiEOWSB+Tk/iVgVW7Y ICJ5Fq0yC2ZjMhiInFH6NIfqvUIsMFxmbRmaSM91Z893/bcV5lmhmYIrL11N2ITq73Od wASw== X-Gm-Message-State: AOAM533pqXjp9cM94jG+ldSULtMhSx1c3qP74kbc8pV0k7gQ4EWUPKgo 3Wga3inxZeWu7iFlfn5W6Ss8PEPbIkNOGm1mpmRpW9M/SIo9oEJokdw+ZoxH9Q2Xbj9UMoWIgWK ZblXhE5zmebIsiRbECwM= X-Received: by 2002:a67:f80b:: with SMTP id l11mr3102861vso.27.1610450238377; Tue, 12 Jan 2021 03:17:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJxdnbhT6z/0wZ0tYZ0UQEI+J8H+u+ANfe+tVpj3WD58ciAalv4B9pqQ4mBP5bUeV7EjH5c7f0D/jo/lAHf0shQ= X-Received: by 2002:a67:f80b:: with SMTP id l11mr3102847vso.27.1610450238179; Tue, 12 Jan 2021 03:17:18 -0800 (PST) MIME-Version: 1.0 References: <11a0d8735a3ee33d02bc57dc702995486051f5d6.1605022892.git.anatoly.burakov@intel.com> In-Reply-To: <11a0d8735a3ee33d02bc57dc702995486051f5d6.1605022892.git.anatoly.burakov@intel.com> From: David Marchand Date: Tue, 12 Jan 2021 12:17:07 +0100 Message-ID: To: Anatoly Burakov Cc: dev , michallinuxstuff@gmail.com Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 21.02] eal/linux: improve no hugepages logging X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 10, 2020 at 4:41 PM Anatoly Burakov wrote: > > When no hugepages are found, we log a message about it, but we never > specify on which node. We also implicitly declare the page size based > on the directory name, but that's not very user friendly. > > Fix both by changing the text of the message to note the NUMA node (if > applicable) and explicitly mention page size in kilobytes. Not sure it is worth aligning but another log uses bytes. >From my tests (after unmounting 2M hugetlbfs mountpoint): EAL: 512 hugepages of size 2097152 reserved, but no mounted hugetlbfs found for that size > > Signed-off-by: Anatoly Burakov The rest lgtm. Reviewed-by: David Marchand -- David Marchand