From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90A40A0548; Thu, 4 Nov 2021 11:34:07 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F53A410D5; Thu, 4 Nov 2021 11:34:07 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4D4AB40DFD for ; Thu, 4 Nov 2021 11:34:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636022045; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aLjK8uf9sBHjdqOxSn5vNfFIBhv2gMEI2TWV7zVT0xg=; b=E8hSrtV+2eCwvO2d5ZYOACkIEWqtrVWJfIcWifR5Of+oT5iZFJWEP8LhgcyDwH/f8RQmzC SXUXcajrOg5o59U91GeDI1wIufGsaMdxlatx6P2JFuMM25sAZCOJ/cfIGwO2oLgDnxNMLt P2O9ab5Chx7pDN313M8MR3u6Ff9ZyG4= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-169-zhO9gWUoMZq6esmT_bFzqQ-1; Thu, 04 Nov 2021 06:34:03 -0400 X-MC-Unique: zhO9gWUoMZq6esmT_bFzqQ-1 Received: by mail-lj1-f200.google.com with SMTP id 23-20020a2e0917000000b002175b5dc52fso2122227ljj.0 for ; Thu, 04 Nov 2021 03:34:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aLjK8uf9sBHjdqOxSn5vNfFIBhv2gMEI2TWV7zVT0xg=; b=V6Wvdc7PB+ophPy9F1GFMt+Pctb685OXIcPx0nC08J2zp/19aiMa9mxVqU/0jkaxUJ iMIQzU9LNCmfOs4LhSN9Vas5VXy8u8vz7t/fyVlIMCCikPAEodPwRVxcZidfTP7IfD7z SxFPnmM+uDFd+tGlevz5SRNa7yqnrHlyjJwTEsmsB8Vni4r82SHZtPmfufJh3mTn5B1N HmQv95iJDMCRP1q7QmE8OiGx1lvZrD/TMhCoCwJD6/LOr6UK/uGtyFRH1ciDDsm6OrI3 mA7zY67Ce1cu4aO52cA5xesRczxUUGti0gxY4Rl6R3HO5mjABf6Hrj5ovD8BZsMTe1oK YscQ== X-Gm-Message-State: AOAM53128jyGKhtBJo9PpKeB2EQMunHRV8QBO/7xIYZ3C5fXZrF3kssv LT/kn1E3zJHUUnjfVMw9o/dECxqiY2xlWsQQsrxlTr+Cq/ueDZ33EC0kQ3dICiTb5+edpIZBVcp 0L8v/RpgJn4pDAGYd9uI= X-Received: by 2002:ac2:5d68:: with SMTP id h8mr46104576lft.217.1636022041562; Thu, 04 Nov 2021 03:34:01 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxrUlh75YPRxb/eMZc4KBcy8pHnwf60fugm9X6jW6NtUgY0wCOu74cB1YQ9Fonf42qCviX4y3zErNVxROJF7sA= X-Received: by 2002:ac2:5d68:: with SMTP id h8mr46104562lft.217.1636022041338; Thu, 04 Nov 2021 03:34:01 -0700 (PDT) MIME-Version: 1.0 References: <20211029105348.10885-1-vsrivast@xilinx.com> In-Reply-To: From: David Marchand Date: Thu, 4 Nov 2021 11:33:49 +0100 Message-ID: To: "Xueming(Steven) Li" , "vijay.srivastava@xilinx.com" Cc: "dev@dpdk.org" , "andrew.rybchenko@oktetlabs.ru" , "praveenj@xilinx.com" , "vsrivast@xilinx.com" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eal: fix device iterator issue to find device for class type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 2, 2021 at 7:13 AM Xueming(Steven) Li wrote: > On Fri, 2021-10-29 at 16:23 +0530, Vijay Srivastava wrote: > > devarg parser rte_devargs_layers_parse() does not configures > devargs->bus_str for class type. rte_dev_iterator_init is not > setting devargs->bus_str to NULL before passing it to devarg parser. > It results junk value for bus_str and due to this device > iterator is unable to find device for class type. > > Bugzilla ID: 862 > Fixes: 9a1a9e4a2ddd (devargs: support path value with global device syntax) > > Signed-off-by: Vijay Srivastava > > --- > lib/eal/common/eal_common_dev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/eal/common/eal_common_dev.c b/lib/eal/common/eal_common_dev.c > index 148a238..4efdd8e 100644 > --- a/lib/eal/common/eal_common_dev.c > +++ b/lib/eal/common/eal_common_dev.c > @@ -577,6 +577,8 @@ static int cmp_dev_name(const struct rte_device *dev, const void *_name) > struct rte_class *cls = NULL; > struct rte_bus *bus = NULL; > > + memset(&devargs, 0, sizeof(devargs)); > + > /* Having both bus_str and cls_str NULL is illegal, > * marking this iterator as invalid unless > * everything goes well. > > Thanks for the fix, I sent a fix earlier for same issue: > https://patches.dpdk.org/project/dpdk/patch/20211027082221.693957-1-xuemingl@nvidia.com/ I'll go with Xueming fix, referencing the opened bz. Thanks. -- David Marchand