From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 95990A052A; Tue, 2 Feb 2021 13:54:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 586992402BD; Tue, 2 Feb 2021 13:54:10 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 3B2E62402B5 for ; Tue, 2 Feb 2021 13:54:08 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1612270448; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NKYA+9C/y9b6fcZnX1j18MMq4ENJdySsEgmZ3snmHjY=; b=SUe4wkGLWvW0TKZT3QxSnCGBQ/GPJN80VBlfF0AmYo9zqTNQQtXUVCNGInaEnNcEPh81xB m79FaCxl+3Ek8fbEbrbQy2Ak6KdDLSe1Z2uT4NRu2t0pgSR6pYUOFGZcND5Hzqko6POQOP cuCC85MbQyd0veSCUGxyVxw7EzepNmc= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-243-LwO6GT7HPbu4TsQXUDJnug-1; Tue, 02 Feb 2021 07:54:05 -0500 X-MC-Unique: LwO6GT7HPbu4TsQXUDJnug-1 Received: by mail-vs1-f71.google.com with SMTP id u187so2246939vsb.13 for ; Tue, 02 Feb 2021 04:54:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NKYA+9C/y9b6fcZnX1j18MMq4ENJdySsEgmZ3snmHjY=; b=q2SWXgEyDwQMGA+SLCgpg3FIcQ73LDwqMe8P1v8CJc7ohAVDUMgyOR2GQRPzdQEVo8 BuKHiQQ0+t6Od2npDwg154J+HClADLnNdEHRlnURI1C25IlWmlOvKV7945uOMzrr7HCO NI7ddeygNuijB31AXpf1KkbEJJBftPxsL9FRORSF4hv31BxUt9tXmabLvCvJoxauBaaG rAWTC8Oy9VhSQqqrvL60jupyF2l999utyHC7AWbaSFUlZ0E6+IOt00Qli0egE7fTaBnG 9YuSbjNJKZKJpRF4CLXKI8iskbuZK7icvwe5WBuwmbtkZqA+robpBrFolZ0ARGhMz0Ah AghQ== X-Gm-Message-State: AOAM530IF5zmjoiN5g2n4OnW6nuVMtmAFF3P/olqPcZh5PZXUV5zErf2 wgCfPr/+OyHigpOhbivH3wPVY1sTqlGnbTElKdM+2TdbvgpTMcgfKUf+kH6g/DMqv+ON/4ECk4E QqwuWnH0+f1LG378Nw6Q= X-Received: by 2002:a9f:2628:: with SMTP id 37mr11614467uag.87.1612270445154; Tue, 02 Feb 2021 04:54:05 -0800 (PST) X-Google-Smtp-Source: ABdhPJwtfJuunhhIEuil9jdu73hCbnOzus3ufj+n5KfTn3Ejg4HyQu152jC1kAKADQfdm2LXa856PAaPeV4MUUXkgXE= X-Received: by 2002:a9f:2628:: with SMTP id 37mr11614450uag.87.1612270444830; Tue, 02 Feb 2021 04:54:04 -0800 (PST) MIME-Version: 1.0 References: <20210202070652.145861-1-haiyue.wang@intel.com> In-Reply-To: From: David Marchand Date: Tue, 2 Feb 2021 13:53:53 +0100 Message-ID: To: "Wang, Haiyue" Cc: dev , "pvalerio@redhat.com" , Aaron Conole , "Zhang, Qi Z" , "Rong, Leyi" , "Tu, Lijuan" , dpdk stable , "Guo, Jia" , "Richardson, Bruce" , "Ananyev, Konstantin" , Jerin Jacob Kollanukkaran , "Ruifeng Wang (Arm Technology China)" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v1] net/ixgbe: adjust error for UDP with zero checksum X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Feb 2, 2021 at 1:42 PM Wang, Haiyue wrote: > > If the driver/hw can't report a valid checksum hint, it should > > announce it does not know if the checksum is valid (neither bad, nor > > good). > > > > So the workaround for udp packets (on this hw model) would be to > > report PKT_RX_L4_CKSUM_UNKNOWN. > > The sw application will then have to recompute the checksum itself if needed. > > > > Make sense, but not sure the vector path can handle this more easily. Will try. Refining this a bit. It looks like hw correctly reports "good" checksums, so maybe instead report PKT_RX_L4_CKSUM_UNKNOWN only for reports of "bad" checksums from the hw? -- David Marchand