From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6D25445B13; Fri, 11 Oct 2024 11:30:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5B0114028E; Fri, 11 Oct 2024 11:30:03 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id AAD5F4028B for ; Fri, 11 Oct 2024 11:30:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1728639001; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZMvyvQyvv5ffE9LjKcTxD6b62UlweJU1NkIu+ppfBsM=; b=ZZIOSieG7r/KeXhN9h1Owwj5glIf9cUE637+nAv9lfY0oaZ1kbCs3E/xB2HPm9ZY6JGEVt 1Gj3qcLapIdlsEyV9twT4YnhOIs8sAt/ug40jcdSWeaO3SzGIJn5nsDBvsqsEP1PyWk1te D+6P4C36T17eDlIlXPsygllpbSIHka0= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-462-UT2yE1i_Oc-0lywnmFn-DQ-1; Fri, 11 Oct 2024 05:29:59 -0400 X-MC-Unique: UT2yE1i_Oc-0lywnmFn-DQ-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-5399a4f3a48so2167512e87.0 for ; Fri, 11 Oct 2024 02:29:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728638998; x=1729243798; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZMvyvQyvv5ffE9LjKcTxD6b62UlweJU1NkIu+ppfBsM=; b=eo/VDKz8TpGVdx3gwWvGs0Y9If+2NMiLHZlkXOYEtsJ8B61v5YMLnLttl2TJIOqh0L yCBRcIJI8xVsl48AJH266b96U+0TCW3tCYR5VPJoWUpOSCWo21NZwRQoGE2rBke9TTuG YG05ABh4+gt/4rr4lkAbnkGvoKhQHuOfGk0pbrvpoZtB6aRFG2iFnTSyAwfg/Fc3j+hE RBEZuoMr0tGPL9oo5ZOPhfgTIn5mJ84n1UyXYJOD2E+NdgEzHVPlJxs1DmwNUxXKqEWR r2l1ZEki4lc2Trjej4fjpGxjxGGCwAHYVQIwipyxBb9IgpwavdUAWkP/Z3Pus9fU4vKS 7WoQ== X-Gm-Message-State: AOJu0Yzg8mScLbCid1RUO1rdpemgB996qWx0nEU34XK899JGbUPS7dbb /CKRYj3WLNCbFrqlWfdvAqEjo5LKgsqTBLZw3UVt8IZvy6JmqA99Wf9oazruCITgAZISCO5f7+N e+l6OQ+W9e7ed9MxsFovr5NNC+enyFjTPPBBKnoVm/s3cc2HbNHRK+WV5x73GrYyAaVs1z95SA2 b2Uq6aQbYYz+Ot7Q8= X-Received: by 2002:a05:6512:1587:b0:539:8876:5555 with SMTP id 2adb3069b0e04-539da4cd035mr1077434e87.29.1728638998282; Fri, 11 Oct 2024 02:29:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFJn0Vujb8wlGtpWMGRxaUZJiQCYtHIkLJSy4rp68NnaC9c+gGvTJuW63N+KPZZBsq7Sbve4EO5d3xsIjoVuKs= X-Received: by 2002:a05:6512:1587:b0:539:8876:5555 with SMTP id 2adb3069b0e04-539da4cd035mr1077422e87.29.1728638997878; Fri, 11 Oct 2024 02:29:57 -0700 (PDT) MIME-Version: 1.0 References: <20241008173136.441340-1-vladimir.medvedkin@intel.com> In-Reply-To: <20241008173136.441340-1-vladimir.medvedkin@intel.com> From: David Marchand Date: Fri, 11 Oct 2024 11:29:46 +0200 Message-ID: Subject: Re: [PATCH] fib6: add runtime checks for vector lookup To: Vladimir Medvedkin , Bruce Richardson , "Mcnamara, John" Cc: dev@dpdk.org, stable@dpdk.org, Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 8, 2024 at 7:31=E2=80=AFPM Vladimir Medvedkin wrote: > > AVX512 lookup function requires CPU to support RTE_CPUFLAG_AVX512DQ and > RTE_CPUFLAG_AVX512BW. Add runtime checks of these two flags when deciding > if vector function can be used. > Fixes: 1e5630e40d95 ("fib6: add AVX512 lookup") > Cc: stable@dpdk.org > > Signed-off-by: Vladimir Medvedkin Reviewed-by: David Marchand I wish we had a build check for those. Or maybe a tool/script that would look at libraries/drivers, catch _mmXXXXX intrinsics and warn if such a library/driver has no call to corresponding runtime check. That would save us from having to go to https://www.intel.com/content/www/us/en/docs/intrinsics-guide/index.html ... Could someone from Intel work on this? In any case, adjusted indent, fixed Fixes: tag, removed superfluous parenthesis, and applied, thanks. --=20 David Marchand