Re: [PATCH 1/6] vhost: fix vduse device creation error handling

[David Marchand <david.marchand@redhat.com>]

On Wed, Oct 23, 2024 at 5:16 PM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
> This patch fixes missing reconnection log unmapping
> miss in the error path at VDUSE creation time.
>
> Coverity issue: 445525
> Fixes: da79cc7fda76 ("vhost: add reconnection support to VDUSE")
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>

VDUSE* in the title, for consistency please.

Reviewed-by: David Marchand <david.marchand@redhat.com>

One comment below.

> ---
>  lib/vhost/vduse.c | 24 +++++++++++++-----------
>  1 file changed, 13 insertions(+), 11 deletions(-)
>
> diff --git a/lib/vhost/vduse.c b/lib/vhost/vduse.c
> index f9ac317438..89bc29a33f 100644
> --- a/lib/vhost/vduse.c
> +++ b/lib/vhost/vduse.c
> @@ -488,7 +488,7 @@ vduse_device_create(const char *path, bool compliant_ol_flags)
>         struct vduse_dev_config *dev_config = NULL;

dev_config could be allocated on the stack, rather than the heap.

But at least, move dev_config declaration in the block where it is
used, this will limit the chance a future change introduces a leak.



>         const char *name = path + strlen("/dev/vduse/");
>         char reconnect_file[PATH_MAX];
> -       struct vhost_reconnect_data *reconnect_log = NULL;
> +       struct vhost_reconnect_data *reconnect_log = MAP_FAILED;
>         bool reconnect = false;
>
>         if (vduse.fdset == NULL) {


-- 
David Marchand