From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9BAA845A9F; Wed, 2 Oct 2024 20:26:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6610A402D3; Wed, 2 Oct 2024 20:26:25 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 6562F40299 for ; Wed, 2 Oct 2024 20:26:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727893583; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FmsPp+uHeXSrM42j1VBNiQSjG/uFeu7I5AMo2cuBKRs=; b=SdZhR93Xgs01aNVdZFOnXZrP/dkU+gw9gP+hrmRT2l88PYhxaTY0MwYSWd3O7G+3Q6lylI YSFp9L/rYuGdKrI8rhfs58xG/GoqSYjDDzhQqbGKn2V4nOzxHaI/02itlF20yFGhgpqfxo b+s+9rCfANvI5vj5LnSrdktfWq736Fo= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-659-HG2fwSBAP_aGyYRECPIUrA-1; Wed, 02 Oct 2024 14:26:21 -0400 X-MC-Unique: HG2fwSBAP_aGyYRECPIUrA-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-53987fc3625so32626e87.0 for ; Wed, 02 Oct 2024 11:26:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727893580; x=1728498380; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FmsPp+uHeXSrM42j1VBNiQSjG/uFeu7I5AMo2cuBKRs=; b=gz1fsQpxDCgGNIwoI1wiiOettDfJangUDIfj24t0i/JWYPAn9/ZhKgXN9XFOLq4t0T QUnhnEssKw/yXwAWJOX6DlR7pKZdnX25iOOMAPP6vIvehXKNxE3OU0AUIzpGRrjZOZxw X2jNpE+yrbdQj19HI0XYXP9tyefdesQnFieZejPwaK1PBdSMIa2gyqoZbWbxhg84umw0 R/I0iq2OaD09iOBj0irGpYFYl9fk15/QV2CmG20+AowpISO7jBS6GbNvWdyx5613gOyB wcdsgMc6l8sRnns6RJ6kFlxHjM/rWneA7vfFTj4WKLC+cDv9Hin5q+FtcVmRAU73DAnH 2Jaw== X-Gm-Message-State: AOJu0Yy+xhQIkzAAW2QaF5IbLaqCmuNveZdJ8c+TUJUCRW+BDnH5EHtD i9eICWGQKySzzgDQinAgF27FTvFReTtdmc0xO5dmplZ7q1cDRKIA52J+vmBH8/lU+bWbTFF29Sf 1RqjbSq01r96G77VDJfIh9pEZWv2O+S+Y/JRo+BtKn727SfTHTS6BK/4L/y70U4q7S7IYCtSYqA 4xLTSmclXqSOjxvFQ= X-Received: by 2002:a2e:a99d:0:b0:2fa:c49b:d161 with SMTP id 38308e7fff4ca-2fae10246d9mr29282081fa.4.1727893580306; Wed, 02 Oct 2024 11:26:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGlVw5i2SBMvumxJy6inl/jPQRlii5anrNdykjfvXilMyoEYzoldw/DdI0l8yQrybF8m36bDHWG6JbOCCIO2wA= X-Received: by 2002:a2e:a99d:0:b0:2fa:c49b:d161 with SMTP id 38308e7fff4ca-2fae10246d9mr29281931fa.4.1727893579878; Wed, 02 Oct 2024 11:26:19 -0700 (PDT) MIME-Version: 1.0 References: <20240809202539.590510-1-mattias.ronnblom@ericsson.com> <20240909191103.697554-1-mattias.ronnblom@ericsson.com> In-Reply-To: <20240909191103.697554-1-mattias.ronnblom@ericsson.com> From: David Marchand Date: Wed, 2 Oct 2024 20:26:08 +0200 Message-ID: Subject: Re: [PATCH v2] service: extend service function call statistics To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: dev@dpdk.org, hofors@lysator.liu.se, harry.van.haaren@intel.com, Stefan Sundkvist X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Mattias, On Mon, Sep 9, 2024 at 9:28=E2=80=AFPM Mattias R=C3=B6nnblom wrote: > @@ -46,9 +49,21 @@ testsuite_teardown(void) > static int32_t dummy_cb(void *args) > { > RTE_SET_USED(args); > - service_tick++; > + > + service_calls++; > + > + switch (rte_rand_max(3)) { > + case 0: > + return 0; > + case 1: > + service_idle_calls++; > + return -EAGAIN; > + default: > + service_error_calls++; > + return -ENOENT; > + } > + > rte_delay_ms(SERVICE_DELAY); > - return 0; > } > > static int32_t dummy_mt_unsafe_cb(void *args) Coverity flagged this patch with issue #445158. rte_delay_ms() is now unreachable. I suppose this delay is not that important for the unit test and we can remove it, but as I am not sure I'll let you have a look and send a fix. Thanks. --=20 David Marchand