From: David Marchand <david.marchand@redhat.com>
To: thomas@monjalon.net, Kevin Traynor <ktraynor@redhat.com>
Cc: i.maximets@samsung.com, dev@dpdk.org, maxime.coquelin@redhat.com,
tiwei.bie@intel.com, zhihong.wang@intel.com,
ferruh.yigit@intel.com, ian.stokes@intel.com,
bruce.richardson@intel.com
Subject: Re: [dpdk-dev] [PATCH v3 0/2] IOPL related fixes
Date: Tue, 27 Nov 2018 15:05:19 +0100 [thread overview]
Message-ID: <CAJFAV8wzLjfbemXQT83Z0LXvdZg9K9XZkbjwWP+dV6sRmu6Vpg@mail.gmail.com> (raw)
In-Reply-To: <5128156.OEWx9KzbiF@xps>
On Sun, Nov 25, 2018 at 11:42 AM Thomas Monjalon <thomas@monjalon.net>
wrote:
> 23/11/2018 23:29, Thomas Monjalon:
> > 23/11/2018 21:07, Kevin Traynor:
> > > On 11/23/2018 04:25 PM, Maxime Coquelin wrote:
> > > > On 11/23/18 4:53 PM, Ilya Maximets wrote:
> > > >> On 23.11.2018 18:41, Maxime Coquelin wrote:
> > > >>> On 11/23/18 4:39 PM, Ilya Maximets wrote:
> > > >>>> Patches primary targeted to fix OVS unit test failures with
> > > >>>> DPDK 18.11 due to following error:
> > > >>>> 'IOPL call failed - cannot use virtio PMD'.
> > > >>>
> > > >>> You mention v18.11, do you mean this is a regression?
> > > >>
> > > >> Kind of. But not really a bug. It's just a message that shows up
> > > >> every time you starting the app as a non-root user.
> > > >>
> > > >> The message itself was introduced long time ago, but it wasn't
> > > >> printed for unclear reasons. It's probably some change in logging
> > > >> subsystem uncovered it.
> > > >>
> > > >> I just checked and found that message appears starting from v18.02.
> > > >> But OVS stuck with 17.11 LTS where this message exists, but not
> > > >> printed for some reason. That's why this wasn't an issue previously.
> > > >
> > > > Thanks for the clarification.
> > > > In that case, we may want it in v18.11 LTS, but I think it can wait
> or
> > > > v18.11.1.
> > >
> > > It would be better if it can be in 18.11. Upstream OVS will point at a
> > > release tarball, and at present an 18.11.1 release is not due until
> > > mid-January. If it's too late for 18.11, alternatively we could do an
> > > earlier 18.11.1 release.
> >
> > I won't take any risk at this stage.
> > The memory of the headaches we had in the past with iopl is too much
> strong.
> > The real change of this patch is to register the PMD even without
> successful iopl.
> > I would like to be sure it won't cause any regression.
>
> After more thinking, I decide to take the risk.
> Take it as a gift to OVS :-)
>
Just for the record, this log is visible by default since 18.02 with commit:
0062818856c3 ("net/virtio: implement dynamic logging")
So probably worth backporting in 18.08 at least.
--
David Marchand
next prev parent reply other threads:[~2018-11-27 14:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20181123141748eucas1p132a221972a87ec82b50d4a6c83bd9646@eucas1p1.samsung.com>
2018-11-23 14:17 ` [dpdk-dev] [PATCH] net/virtio: avoid annoying IOPL call related errors Ilya Maximets
[not found] ` <CGME20181123143625eucas1p1def3421fa13b5aec7204549932c75bb7@eucas1p1.samsung.com>
2018-11-23 14:36 ` [dpdk-dev] [PATCH v2] " Ilya Maximets
2018-11-23 15:02 ` David Marchand
[not found] ` <CGME20181123153936eucas1p13bfbe13fcda92de7760ac768fcab43c5@eucas1p1.samsung.com>
2018-11-23 15:39 ` [dpdk-dev] [PATCH v3 0/2] IOPL related fixes Ilya Maximets
[not found] ` <CGME20181123153947eucas1p169a2b7cec02b2edd7258aef11b1c1e2e@eucas1p1.samsung.com>
2018-11-23 15:39 ` [dpdk-dev] [PATCH v3 1/2] eal/bsd: fix possible IOPL fd leak Ilya Maximets
2018-11-23 17:32 ` Maxime Coquelin
[not found] ` <CGME20181123153951eucas1p1218331b7e51db8eae3073fa6a14f3bcd@eucas1p1.samsung.com>
2018-11-23 15:39 ` [dpdk-dev] [PATCH v3 2/2] net/virtio: avoid annoying IOPL call related errors Ilya Maximets
2018-11-23 17:34 ` Maxime Coquelin
2018-11-23 15:41 ` [dpdk-dev] [PATCH v3 0/2] IOPL related fixes Maxime Coquelin
2018-11-23 15:53 ` Ilya Maximets
2018-11-23 16:25 ` Maxime Coquelin
2018-11-23 20:07 ` Kevin Traynor
2018-11-23 22:29 ` Thomas Monjalon
2018-11-25 10:42 ` Thomas Monjalon
2018-11-26 9:49 ` Kevin Traynor
2018-11-27 14:05 ` David Marchand [this message]
2018-11-23 17:15 ` [dpdk-dev] [PATCH v2] net/virtio: avoid annoying IOPL call related errors Timothy Redaelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wzLjfbemXQT83Z0LXvdZg9K9XZkbjwWP+dV6sRmu6Vpg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=i.maximets@samsung.com \
--cc=ian.stokes@intel.com \
--cc=ktraynor@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=thomas@monjalon.net \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).