From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by dpdk.org (Postfix) with ESMTP id B5AAF2C01 for ; Tue, 27 Nov 2018 15:05:31 +0100 (CET) Received: by mail-pl1-f193.google.com with SMTP id z23so15674573plo.0 for ; Tue, 27 Nov 2018 06:05:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=L+k1dCeYOaB1uOIG0urE2Xfg2wnoiJ3GEU/l/vcvfZU=; b=TOQX/X2rh8/xBTJ0majkPm+Vny2Rzrq0GI0OO219QmTUNeWW75uB5mpnK8PL0ZLsUt u7vlgkY89RtZJa2+f4L9VKyEvOVYrk2JOeArpMg9loC1RoeG0sUSmM7co2HAGnL+z6L+ Kx1769X7eJkulcAJ86qeP/WuBjta23mbdvWoOKjxkNUAxFUxpzQqod94B9PFgoqmTIqX tVsK4ZiT/m1gapSB80sxJK+WmgIvprCXtvhRnONk2eTGAVQ+Zi/+o+vmzVqqq19Ig4gS rQOnnIa52TtTJTJ2iEwJfZPpDjSyAuw2EhyZdKhYEGtTsnNgF8swz0h9ymUHsw5EWJtv ci4w== X-Gm-Message-State: AA+aEWYqfiy9C4udQrba1feT7D+KEVz874y/o4tPnfG1fZsfhZz+aj14 scSI6WpnVe9jMn5AZLBvuVYzql47USde1CQbhUCaQQ== X-Google-Smtp-Source: AFSGD/X37HeVYOHpD00+iZBz2c7DINVHLjCkRF9CI2qzHKpj0dm3VZyB6muLyZ9FSBiN7tphvaT4uk7zANveneu9B4s= X-Received: by 2002:a17:902:29ab:: with SMTP id h40mr32422344plb.238.1543327530954; Tue, 27 Nov 2018 06:05:30 -0800 (PST) MIME-Version: 1.0 References: <20181123143620.10480-1-i.maximets@samsung.com> <2f95ce88-8f61-10c0-9131-49e2a5d10048@redhat.com> <2699010.cjLPUA7OeM@xps> <5128156.OEWx9KzbiF@xps> In-Reply-To: <5128156.OEWx9KzbiF@xps> From: David Marchand Date: Tue, 27 Nov 2018 15:05:19 +0100 Message-ID: To: thomas@monjalon.net, Kevin Traynor Cc: i.maximets@samsung.com, dev@dpdk.org, maxime.coquelin@redhat.com, tiwei.bie@intel.com, zhihong.wang@intel.com, ferruh.yigit@intel.com, ian.stokes@intel.com, bruce.richardson@intel.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 0/2] IOPL related fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2018 14:05:32 -0000 On Sun, Nov 25, 2018 at 11:42 AM Thomas Monjalon wrote: > 23/11/2018 23:29, Thomas Monjalon: > > 23/11/2018 21:07, Kevin Traynor: > > > On 11/23/2018 04:25 PM, Maxime Coquelin wrote: > > > > On 11/23/18 4:53 PM, Ilya Maximets wrote: > > > >> On 23.11.2018 18:41, Maxime Coquelin wrote: > > > >>> On 11/23/18 4:39 PM, Ilya Maximets wrote: > > > >>>> Patches primary targeted to fix OVS unit test failures with > > > >>>> DPDK 18.11 due to following error: > > > >>>> 'IOPL call failed - cannot use virtio PMD'. > > > >>> > > > >>> You mention v18.11, do you mean this is a regression? > > > >> > > > >> Kind of. But not really a bug. It's just a message that shows up > > > >> every time you starting the app as a non-root user. > > > >> > > > >> The message itself was introduced long time ago, but it wasn't > > > >> printed for unclear reasons. It's probably some change in logging > > > >> subsystem uncovered it. > > > >> > > > >> I just checked and found that message appears starting from v18.02. > > > >> But OVS stuck with 17.11 LTS where this message exists, but not > > > >> printed for some reason. That's why this wasn't an issue previously. > > > > > > > > Thanks for the clarification. > > > > In that case, we may want it in v18.11 LTS, but I think it can wait > or > > > > v18.11.1. > > > > > > It would be better if it can be in 18.11. Upstream OVS will point at a > > > release tarball, and at present an 18.11.1 release is not due until > > > mid-January. If it's too late for 18.11, alternatively we could do an > > > earlier 18.11.1 release. > > > > I won't take any risk at this stage. > > The memory of the headaches we had in the past with iopl is too much > strong. > > The real change of this patch is to register the PMD even without > successful iopl. > > I would like to be sure it won't cause any regression. > > After more thinking, I decide to take the risk. > Take it as a gift to OVS :-) > Just for the record, this log is visible by default since 18.02 with commit: 0062818856c3 ("net/virtio: implement dynamic logging") So probably worth backporting in 18.08 at least. -- David Marchand