From: David Marchand <david.marchand@redhat.com>
To: "Juraj Linkeš" <juraj.linkes@pantheon.tech>,
"Bruce Richardson" <bruce.richardson@intel.com>,
"Ciara Power" <ciara.power@intel.com>
Cc: Aaron Conole <aconole@redhat.com>,
Michael Santana <maicolgabriel@hotmail.com>, dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] ci: fix telemetry dependency in Travis
Date: Thu, 9 Apr 2020 10:00:51 +0200 [thread overview]
Message-ID: <CAJFAV8wzS7_7KM8gLMu5qPy3jtz0zyPGq_cfvRHdAiu5m4qJeQ@mail.gmail.com> (raw)
In-Reply-To: <1586350164-26429-1-git-send-email-juraj.linkes@pantheon.tech>
Hello,
On Wed, Apr 8, 2020 at 2:49 PM Juraj Linkeš <juraj.linkes@pantheon.tech> wrote:
>
> libjansson4 is not enough to build telemetry. Replace it with
> libjansson-dev.
Thanks for the patch Juraj.
Just a little comment, for the v2, there was no significant change and
you could have kept Aaron and Ruifeng review tags.
I just want others' opinion, since there is a work on removing the
dependency on libjansson for telemetry.
This current patch is a fix for the CI, that could be worth
backporting to 19.11.
Hence I am for taking it in master.
Then when the telemetry rework is merged, this rework will remove the
dependency.
--
David Marchand
next prev parent reply other threads:[~2020-04-09 8:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 12:45 [dpdk-dev] [PATCH] " juraj.linkes
2020-04-03 14:41 ` Aaron Conole
2020-04-03 15:08 ` Ruifeng Wang
2020-04-08 12:49 ` [dpdk-dev] [PATCH v2] " Juraj Linkeš
2020-04-08 13:10 ` Aaron Conole
2020-04-09 8:00 ` David Marchand [this message]
2020-04-09 9:23 ` Bruce Richardson
2020-04-09 9:30 ` David Marchand
2020-04-10 8:06 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8wzS7_7KM8gLMu5qPy3jtz0zyPGq_cfvRHdAiu5m4qJeQ@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=aconole@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=ciara.power@intel.com \
--cc=dev@dpdk.org \
--cc=juraj.linkes@pantheon.tech \
--cc=maicolgabriel@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).