Re: [dpdk-dev] [PATCH v10 0/8] Enhancements for PMD power management

[David Marchand <david.marchand@redhat.com>]

On Fri, Jul 9, 2021 at 6:08 PM Anatoly Burakov
<anatoly.burakov@intel.com> wrote:
>
> This patchset introduces several changes related to PMD power management:
>
> - Changed monitoring intrinsics to use callbacks as a comparison function, based
>   on previous patchset [1] but incorporating feedback [2] - this hopefully will
>   make it possible to add support for .get_monitor_addr in virtio
> - Add a new intrinsic to monitor multiple addresses, based on RTM instruction
>   set and the TPAUSE instruction
> - Add support for PMD power management on multiple queues, as well as all
>   accompanying infrastructure and example apps changes
>
> v10:
> - Added missing changes to NIC feature .ini files
>
> v9:
> - Added all missing Acks and Tests
> - Added a new commit with NIC features
> - Addressed minor issues raised in review
>
> v8:
> - Fixed checkpatch issue
> - Added comment explaining empty poll handling (Konstantin)
>
> v7:
> - Fixed various bugs
>
> v6:
> - Improved the algorithm for multi-queue sleep
> - Fixed segfault and addressed other feedback
>
> v5:
> - Removed "power save queue" API and replaced with mechanism suggested by
>   Konstantin
> - Addressed other feedback
>
> v4:
> - Replaced raw number with a macro
> - Fixed all the bugs found by Konstantin
> - Some other minor corrections
>
> v3:
> - Moved some doc updates to NIC features list
>
> v2:
> - Changed check inversion to callbacks
> - Addressed feedback from Konstantin
> - Added doc updates where necessary
>
> [1] http://patches.dpdk.org/project/dpdk/list/?series=16930&state=*
> [2] http://patches.dpdk.org/project/dpdk/patch/819ef1ace187365a615d3383e54579e3d9fb216e.1620747068.git.anatoly.burakov@intel.com/#133274
>
> Anatoly Burakov (8):
>   eal: use callbacks for power monitoring comparison
>   net/af_xdp: add power monitor support
>   doc: add PMD power management NIC feature
>   eal: add power monitor for multiple events
>   power: remove thread safety from PMD power API's
>   power: support callbacks for multiple Rx queues
>   power: support monitoring multiple Rx queues
>   examples/l3fwd-power: support multiq in PMD modes

Overall, the series lgtm.

I still have a comment on the opaque pointer passed in callbacks.
This is not blocking, we can still go with followup patches in this release.

It would be great if drivers maintainers could implement this new ops
in their driver or give feedback on what should be enhanced.

Series applied, thanks.


-- 
David Marchand