From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B6D642C3E; Tue, 6 Jun 2023 11:30:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C89B040A84; Tue, 6 Jun 2023 11:30:27 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 2489940697 for ; Tue, 6 Jun 2023 11:30:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686043825; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rnF7+RroS47/Z/TcT/815KodZlUD1LboxRv3FIqyoRo=; b=GsIUOGrYgPTYgAEqsCziuyohWpi5ZeWb+vu1vBHc6WQchE7KTS2O1iQljfqJ9Rs+xORF/5 454jKoM1xK9gbdLzzvsh/qnCZYxGHqVjqjOOY4y2QQrdZqCshF96y/TFQkqY/9kRuox4zf EUYWg4XSy7nzGvg/Y6kXuyqEjq3g8Ss= Received: from mail-oi1-f200.google.com (mail-oi1-f200.google.com [209.85.167.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-111-ieODbsLIOO2loMGJZubI0Q-1; Tue, 06 Jun 2023 05:30:24 -0400 X-MC-Unique: ieODbsLIOO2loMGJZubI0Q-1 Received: by mail-oi1-f200.google.com with SMTP id 5614622812f47-39a9cefa414so2668036b6e.0 for ; Tue, 06 Jun 2023 02:30:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686043824; x=1688635824; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rnF7+RroS47/Z/TcT/815KodZlUD1LboxRv3FIqyoRo=; b=cWd61WuIp2OdIq1VH/6iPsSXiQsR8lBM9XrFfpsf50hQ0RJDsi+xy6DtYk2uznK964 crCW5mFN9h80rlOP7AL/N2Onqm+UWxEnW15MaZwTLKLGR3Cwkl0wmJDNsdRDhSH8JYBB ixYoRuxyilhI8jr7bQbyTIzIz7PbVEOdhw4ag0Zvbo86BjcT3LPk5Er0SD0nVfyrNIhp 52ZmNI4zNlxXLFtRTRqA3vjK8sFpH178PGpABGhu4k8za9OaQfMmcxRbDpRPBhQ1FNu7 NWtur39wBvPlf7qIh7RNL38exaHqJ2cUu1UuYU8iNTW3figVy10BQYFvs9v2HdGZaC+p hSZg== X-Gm-Message-State: AC+VfDwCJeZx/a5ll3FkBsDV728IC6q4NUkncoPYkccXgqmaB3J9eTgo +IHjr6oaqdGTFQLM4SNXKaR0kykbfT8uiRKTxx2CB3Z3pzvaV1uGffpHEB8PLUAVSKT76f752v/ OBAY8GRiHf+gw9KdmN1Q= X-Received: by 2002:a05:6358:c113:b0:129:d475:15d3 with SMTP id fh19-20020a056358c11300b00129d47515d3mr2461699rwb.12.1686043823814; Tue, 06 Jun 2023 02:30:23 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ71yxWCnd1YYKQxYTixGavj4rTtVIawg3F+1lQhT+m9EOG90PJRoM08BAOAOjfWElEIpHtJCpnX4I5orakvSzE= X-Received: by 2002:a05:6358:c113:b0:129:d475:15d3 with SMTP id fh19-20020a056358c11300b00129d47515d3mr2461529rwb.12.1686043820766; Tue, 06 Jun 2023 02:30:20 -0700 (PDT) MIME-Version: 1.0 References: <20230124140746.594066-1-nipun.gupta@amd.com> <20230605132624.8626-1-nipun.gupta@amd.com> <20230605132624.8626-4-nipun.gupta@amd.com> In-Reply-To: <20230605132624.8626-4-nipun.gupta@amd.com> From: David Marchand Date: Tue, 6 Jun 2023 11:30:09 +0200 Message-ID: Subject: Re: [PATCH v6 3/4] bus/cdx: add support for MSI To: Nipun Gupta Cc: dev@dpdk.org, thomas@monjalon.net, hkalra@marvell.com, anatoly.burakov@intel.com, stephen@networkplumber.org, ferruh.yigit@amd.com, harpreet.anand@amd.com, nikhil.agarwal@amd.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jun 5, 2023 at 3:27=E2=80=AFPM Nipun Gupta wr= ote: > +/* set up interrupt support (but not enable interrupts) */ > static int > -cdx_rte_vfio_setup_device(int vfio_dev_fd) > +cdx_vfio_setup_interrupts(struct rte_cdx_device *dev, int vfio_dev_fd, I had dropped a bit too much of the hunk in my previous comment, but see be= low: [snip] > +static int > +cdx_vfio_setup_device(struct rte_cdx_device *dev, int vfio_dev_fd, > + int num_irqs) cdx_rte_vfio_setup_device() is renamed to cdx_vfio_setup_device(). Such a rename is unneeded noise, cdx_vfio_setup_device() should be used from the start, in patch1. If there is no further comment on the series, I can fix this when applying. --=20 David Marchand