From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dmarchan@redhat.com>
Received: from mail-ua1-f50.google.com (mail-ua1-f50.google.com
 [209.85.222.50]) by dpdk.org (Postfix) with ESMTP id 424CA1B4CB
 for <dev@dpdk.org>; Fri, 15 Feb 2019 19:31:51 +0100 (CET)
Received: by mail-ua1-f50.google.com with SMTP id j3so3546525uap.3
 for <dev@dpdk.org>; Fri, 15 Feb 2019 10:31:51 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=aoD9ecyc5q+qwZlno8eRhiT17tSYEeqHmCOt/LLasCQ=;
 b=Ear36rzlWX/l3EKG+qfAtHHy1nTeMJYdWwIMTCsTriJR+o2K2epGLTU9UpxuwE7gFD
 lRMW4TXipbXzyx6yjC/c9FGci+wPfMS6ow+Ruk66+onOxYU4IjR2rw8dDgozNFbN66iB
 v3yocF0N1hnEdkOZz2zySbq2HKaid/R6Z0T0E8YtznEVW6tePhxL+7UPW2fgitEhcvms
 RlHyJNraLumNezlU6geqw0zlEyFAP9C2draE3zISFgVIb2E9mruUHFLxVlQ7Xa0jiqts
 oDAdlqGvRi2a3cxJz8XCqcx77AMYpOzKuV/XoyCV/NYrfcGBU4F/hk0cVnSaEvnt9ieA
 xYJQ==
X-Gm-Message-State: AHQUAuZ/aB4R1N6Y/D/dVZDbeejhgbJ0vF8o6CMShtxhe+Y2iLBBd95Z
 4b8gTq7qN4+yh7IHLY5eDIHRFZ6fMY5jHtT79CVHVA==
X-Google-Smtp-Source: AHgI3IaxXKwYHIMhTBFtfgxGvOq8mwub7uYcHqF+rqzVAecWbG8Cia/cNBIh7fE/PP/KgtNDjXna9Xw6lEq+5h3DLtM=
X-Received: by 2002:ab0:3484:: with SMTP id c4mr5550547uar.39.1550255510592;
 Fri, 15 Feb 2019 10:31:50 -0800 (PST)
MIME-Version: 1.0
References: <1550158972-21895-1-git-send-email-david.marchand@redhat.com>
 <20190215140526.GB790616@bricha3-MOBL.ger.corp.intel.com>
 <CAJFAV8zYYQEV5xcuyvqh0by_DXtRwPhdb1+Z=bgzsdgip1YC-Q@mail.gmail.com>
 <1551030.Hp446SNAY3@xps>
 <CAJFAV8yyaGTy=V4w=jeGn-Yorkkmc=tO0EG=CsiU-f0ONTqL0g@mail.gmail.com>
 <2601191342CEEE43887BDE71AB977258012413A4C0@irsmsx105.ger.corp.intel.com>
In-Reply-To: <2601191342CEEE43887BDE71AB977258012413A4C0@irsmsx105.ger.corp.intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Fri, 15 Feb 2019 19:31:39 +0100
Message-ID: <CAJFAV8wzk+DmkK7AoRJ47GZbrtsYK9uXOWC4_4riYmV3c9MSew@mail.gmail.com>
To: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, "Richardson,
 Bruce" <bruce.richardson@intel.com>, 
 "dev@dpdk.org" <dev@dpdk.org>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, 
 "Wu, Jingjing" <jingjing.wu@intel.com>, "Iremonger,
 Bernard" <bernard.iremonger@intel.com>, 
 Maxime Coquelin <mcoqueli@redhat.com>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>, "Wiles,
 Keith" <keith.wiles@intel.com>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH 3/5] app/testpmd: add missing transmit errors
	stats
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 15 Feb 2019 18:31:51 -0000

On Fri, Feb 15, 2019 at 7:15 PM Ananyev, Konstantin <
konstantin.ananyev@intel.com> wrote:

> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Marchand
> > I am also for option 2 especially because of this.
> > A driver that refuses a packet for reason X (which is a limitation, or an
> > incorrect config or whatever that is not a transient condition) but gives
> > it back to the application is a bad driver.
>
> Why? What.s wrong to leave it to the upper layer to decide what to
> do with the packets that can't be sent (by one reason or another)?
>

How does the upper layer know if this is a transient state or something
that can't be resolved?


-- 
David Marchand