From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31B504389F; Fri, 12 Jan 2024 09:03:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F8034068A; Fri, 12 Jan 2024 09:03:01 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D74704064A for ; Fri, 12 Jan 2024 09:02:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1705046578; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PFASZNT+kL2SpssGYCS7oDFKg1PZev51x6G8jikA/hQ=; b=QGxS1JVRvlWVAsYr6RJgQv5e27WG3b1Ag584Wwf64tbOyGS0/q2yp01e6FkKvNDDSsY61P HWjygbTGSb7t8/fllS4q5JZtUkoUVSFDbNf44j5fCRRPHku73Lr9n00A6hRhEMjPp+WYid jvlhr7WL/bwQALoN1Ff4WJAAqewsYJg= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-215-nVD_vPgfNV21HgLei4GLHA-1; Fri, 12 Jan 2024 03:02:57 -0500 X-MC-Unique: nVD_vPgfNV21HgLei4GLHA-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2cccd597158so52371201fa.2 for ; Fri, 12 Jan 2024 00:02:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705046575; x=1705651375; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PFASZNT+kL2SpssGYCS7oDFKg1PZev51x6G8jikA/hQ=; b=cxHNVGTQkm1wZccmM4l/Kk7RRHBo5EH4KAx+WMglo3MK1Pt2dTPOo1yePVnm2d7xgE ktvRCmyz30DtGfQKnF1tx15TMUjjVY9INQdz5zeTK22W4WdlXxek7OyEJsc8gcbQ9btY hbwQTpp6D6Sy8mdWVJtI3J8aXklM2mup0BrKjTgGDixPB1x6qfPf1/U2xOsuK2XO+KJC wQjU5+X/OvVRz7vwwZJsiiWH1g991+z4GlWxhtI/hmnIJZJnyYYI5PvaRACVz4gXsG09 g9rAQAIA9zC/r5dzgZhPOsYshq9NdCnjqEhpcxg5sonQZ5TJFoF3kDxdTj9SEap4chmZ 2omQ== X-Gm-Message-State: AOJu0Yzl5JhZO/idHAaWnUQTiOC8325NvNJkRBGI/xJ6UUqGNlR8MP8U go+jG+ltLaHcSgQTwt9BZgVp/WD5jaxaiKjWKLhvIIWFOONIgZR5PSPIpmRUixCrXgpSqy0kYlC Y62VtMnSxflyp0zgrzQh8Va9AYp4= X-Received: by 2002:a2e:a1ca:0:b0:2cc:db17:64af with SMTP id c10-20020a2ea1ca000000b002ccdb1764afmr451974ljm.93.1705046575572; Fri, 12 Jan 2024 00:02:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IGZTVR5ueuZen8m7AcVlTpwUYnMIGd74lXo8C7F/AZxVy3lken22RWVZ6IF8AynAAInQ4k3cwXo/hT83v6c3Cs= X-Received: by 2002:a2e:a1ca:0:b0:2cc:db17:64af with SMTP id c10-20020a2ea1ca000000b002ccdb1764afmr451949ljm.93.1705046575244; Fri, 12 Jan 2024 00:02:55 -0800 (PST) MIME-Version: 1.0 References: <20231219172948.3909749-1-jerinj@marvell.com> <20240111151745.3800170-1-jerinj@marvell.com> In-Reply-To: <20240111151745.3800170-1-jerinj@marvell.com> From: David Marchand Date: Fri, 12 Jan 2024 09:02:42 +0100 Message-ID: Subject: Re: [dpdk-dev] [v1] ethdev: support Tx queue used count To: jerinj@marvell.com Cc: dev@dpdk.org, Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , ferruh.yigit@xilinx.com, ajit.khaparde@broadcom.com, aboyer@pensando.io, beilei.xing@intel.com, bruce.richardson@intel.com, chas3@att.com, chenbo.xia@intel.com, ciara.loftus@intel.com, dsinghrawat@marvell.com, ed.czeck@atomicrules.com, evgenys@amazon.com, grive@u256.net, g.singh@nxp.com, zhouguoyang@huawei.com, haiyue.wang@intel.com, hkalra@marvell.com, heinrich.kuhn@corigine.com, hemant.agrawal@nxp.com, hyonkim@cisco.com, igorch@amazon.com, irusskikh@marvell.com, jgrajcia@cisco.com, jasvinder.singh@intel.com, jianwang@trustnetic.com, jiawenwu@trustnetic.com, jingjing.wu@intel.com, johndale@cisco.com, john.miller@atomicrules.com, linville@tuxdriver.com, keith.wiles@intel.com, kirankumark@marvell.com, oulijun@huawei.com, lironh@marvell.com, longli@microsoft.com, mw@semihalf.com, spinler@cesnet.cz, matan@nvidia.com, matt.peters@windriver.com, maxime.coquelin@redhat.com, mk@semihalf.com, humin29@huawei.com, pnalla@marvell.com, ndabilpuram@marvell.com, qiming.yang@intel.com, qi.z.zhang@intel.com, radhac@marvell.com, rahul.lakkireddy@chelsio.com, rmody@marvell.com, rosen.xu@intel.com, sachin.saxena@oss.nxp.com, skoteshwar@marvell.com, shshaikh@marvell.com, shaibran@amazon.com, shepard.siegel@atomicrules.com, asomalap@amd.com, somnath.kotur@broadcom.com, sthemmin@microsoft.com, steven.webster@windriver.com, skori@marvell.com, mtetsuyah@gmail.com, vburru@marvell.com, viacheslavo@nvidia.com, xiao.w.wang@intel.com, cloud.wangxiaoyun@huawei.com, yisen.zhuang@huawei.com, yongwang@vmware.com, xuanziyang2@huawei.com, cristian.dumitrescu@intel.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi Jerin, On Thu, Jan 11, 2024 at 4:32=E2=80=AFPM wrote: > > From: Jerin Jacob > > Introduce a new API to retrieve the number of used descriptors > in a Tx queue. Applications can leverage this API in the fast path to > inspect the Tx queue occupancy and take appropriate actions based on the > available free descriptors. > > A notable use case could be implementing Random Early Discard (RED) > in software based on Tx queue occupancy. > > Signed-off-by: Jerin Jacob > --- > doc/guides/nics/features.rst | 10 ++++ > doc/guides/nics/features/default.ini | 1 + > lib/ethdev/ethdev_driver.h | 2 + > lib/ethdev/ethdev_private.c | 1 + > lib/ethdev/ethdev_trace_points.c | 3 ++ > lib/ethdev/rte_ethdev.h | 74 ++++++++++++++++++++++++++++ > lib/ethdev/rte_ethdev_core.h | 7 ++- > lib/ethdev/rte_ethdev_trace_fp.h | 8 +++ > lib/ethdev/version.map | 3 ++ > 9 files changed, 108 insertions(+), 1 deletion(-) We need some libabigail suppression rule for the reserved2 field update. Looking at some previous rules, something like below can do the trick. diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore index 21b8cd6113..ba240f74d5 100644 --- a/devtools/libabigail.abignore +++ b/devtools/libabigail.abignore @@ -33,3 +33,6 @@ ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; ; Temporary exceptions till next major ABI version ; ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;; +[suppress_type] + name =3D rte_eth_fp_ops + has_data_member_inserted_between =3D {offset_of(reserved2), end} --=20 David Marchand