From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 0F700A0579;
Thu, 8 Apr 2021 14:58:34 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 9EF28140F7E;
Thu, 8 Apr 2021 14:58:33 +0200 (CEST)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.133.124])
by mails.dpdk.org (Postfix) with ESMTP id 9734D40698
for <dev@dpdk.org>; Thu, 8 Apr 2021 14:58:32 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1617886712;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=uJicGLQF0/09OhtxiBjaPc/EkiLnoyE+AIUScMV3gdE=;
b=iXERVgYtmxJmTVUCyX2dyqjT3PJaHzh4HAjRIgO3Hbf3F4IuzrqCI7gTmIGFQZeVfIvJQy
QW7pp86d09Cv4K1tjzvZmSXdLUnVUTPxbU4IAGBb+7BFDzoxdHRiibqc51l88reN0s9HjE
Tba5as1e3dI/QMIFmzIxwN80xb9FwUE=
Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com
[209.85.208.198]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-244-ofz2WbJYNd6crCLwtBIwAg-1; Thu, 08 Apr 2021 08:58:30 -0400
X-MC-Unique: ofz2WbJYNd6crCLwtBIwAg-1
Received: by mail-lj1-f198.google.com with SMTP id a24so677884ljp.16
for <dev@dpdk.org>; Thu, 08 Apr 2021 05:58:30 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=uJicGLQF0/09OhtxiBjaPc/EkiLnoyE+AIUScMV3gdE=;
b=kdELNWIAaDiihpHtoacGvcGIY0bWHRqSBMXdZlBX9LmDCGqlK8ivq03tiYiegjjcqi
H5aSH6/o5yLrpbgNfO8Ti0t+lc4BVancO+vLfnP67mGHfHTTwMk+Tce3SUE6ViSEfUqg
QLlOoMWhcHl1C0AvXOTUXUgkulP2rQnr94Av4t7bhP80+XK5swTUZGkRqe6waUHS11lV
a620amEabApBhdrCWT9jI/Itb1LRWVCjTle7o6h7R1S/KmqzSkcvcE1/FTkKpibDNHJk
dDSlCzZTVhvDvMtzE+Dvapw7IFeqeDwvawL4bjRMlhuZ+r0IAaTxgaYsxzLexfvcqJci
yacA==
X-Gm-Message-State: AOAM530Q9bBg0IVY0jze8PIb44UcuYwIQBZ3Z7JeYUK10IXS1Rgeg3Yk
TVylWs90EsMt3/CR8WVmPjc7uHolF9z18QWPysEe9MoBcBybZ/RNRKBC2RlspFbcYXZ5VoXUFN/
ZuJ4dd7fH8LbZIRCDb6A=
X-Received: by 2002:a2e:a589:: with SMTP id m9mr5829158ljp.134.1617886708999;
Thu, 08 Apr 2021 05:58:28 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzp1BJCRgBXgSGnAMxI6WnLwWLj0uIveHlhP9e1l4cZWEt6cfZ9ZO2vysEOgg2sE5zSGELyFdciGq/zQX6hL6U=
X-Received: by 2002:a2e:a589:: with SMTP id m9mr5829144ljp.134.1617886708695;
Thu, 08 Apr 2021 05:58:28 -0700 (PDT)
MIME-Version: 1.0
References: <20210407090656.29176-1-david.marchand@redhat.com>
<BYAPR11MB3143848E1C8A3A884BC6D712D7749@BYAPR11MB3143.namprd11.prod.outlook.com>
In-Reply-To: <BYAPR11MB3143848E1C8A3A884BC6D712D7749@BYAPR11MB3143.namprd11.prod.outlook.com>
From: David Marchand <david.marchand@redhat.com>
Date: Thu, 8 Apr 2021 14:58:17 +0200
Message-ID: <CAJFAV8x+NUJX7r1j1z=zyB4Wb6EMXJOE+-SKXfkVhZNPmu6zOA@mail.gmail.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>,
Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>,
Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Authentication-Results: relay.mimecast.com;
auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH] service: clean references to removed symbol
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Thu, Apr 8, 2021 at 2:54 PM Van Haaren, Harry
<harry.van.haaren@intel.com> wrote:
>
> > -----Original Message-----
> > From: David Marchand <david.marchand@redhat.com>
> > Sent: Wednesday, April 7, 2021 10:07 AM
> > To: dev@dpdk.org
> > Cc: stable@dpdk.org; Van Haaren, Harry <harry.van.haaren@intel.com>; Ray
> > Kinsella <mdr@ashroe.eu>; Neil Horman <nhorman@tuxdriver.com>; Pavan
> > Nikhilesh <pbhagavatula@caviumnetworks.com>
> > Subject: [PATCH] service: clean references to removed symbol
> >
> > rte_service_get_id() was removed in v17.11 but the API description
> > still referenced it and a version node was still present in EAL map.
> >
> > Fixes: 8edc9aaaf217 ("service: use id in get by name function")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> For rte_service.h doc changes I'm all fine.
>
> For ABI consistency, this removes a function from the DPDK_21 version map that didn't exist in
> the shared object itself. I'm not sure if that's an ABI break or not... I see ABI experts on CC,
> and will let them comment on that topic.
The symbol is not in the API anymore.
Applications can't have a reference to this symbol without a definition.
--
David Marchand