From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7136A42C99; Mon, 12 Jun 2023 16:55:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6423D41138; Mon, 12 Jun 2023 16:55:48 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id AD05840698 for ; Mon, 12 Jun 2023 16:55:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686581746; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RkVNEnQweM/yoMDO3vU77n4S45/CEAYKeHwaNjdQFP0=; b=GR356D91iyyWCn71db+Wl+MJ4DgyV7fzt4ajKFNbDS3FFz3GuRHYVnulgH578Zv827LMh/ dHgoa6R4pCVOdRkvyP360LaQpxbYegWYs75b/Z0bF2xxSzIkcndxo3W5dTVcoSJJ4dKcr4 yMzJAtlHUmHTfhy52Ht3H5PbPycP1QI= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-426-3U4rJYpAOPeB--sY4aXMVg-1; Mon, 12 Jun 2023 10:55:45 -0400 X-MC-Unique: 3U4rJYpAOPeB--sY4aXMVg-1 Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-256719f2381so3015828a91.0 for ; Mon, 12 Jun 2023 07:55:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686581744; x=1689173744; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RkVNEnQweM/yoMDO3vU77n4S45/CEAYKeHwaNjdQFP0=; b=XIzmSwFdod8lVqmSJ/l1XFZ/XzdtXQPVFTDulBrDMsuEEILFGNCjKAZw2+he9Ey1iG JsvWMz4rDg1pPTlr+N6nQlzkMclG4p0ZaqFPgZR+R0eIuumrgAH4wfXjc8RbJ0iGTRzH ng1gW06xFvHgV3RJZTS5nHy6Vt01dfM6felDUbKwavErCjaVBo0vDQwo8gPTaS8GvApk nFbvjRBHdHETFFORP33z9b2qNW4jB2jgu52P2ZD1W0sVUQqPGAFKHn3OoPMvmOutrg4q +VRGNY3ieeV0+ttRVRKYzfPYyiU4F7rh+rTOIlmJo5VClaXLSZ2ZLi+ucXfPkT1PzPgx jO9A== X-Gm-Message-State: AC+VfDy/o1fEQTfPEeLhKKmFT0gecoHZv0vayuLqaiA4dSGYdPhLR/tw yfu0SVzEDd/WwQjZ5B792oPkLSafhSJ37nRPIWy78ez5EBA2DXo/b7WofOlcV5k2cQe6JqyPrR+ hzUZo64cEDuhOwE9Z6gQ= X-Received: by 2002:a17:90a:b8f:b0:25b:f764:580a with SMTP id 15-20020a17090a0b8f00b0025bf764580amr1423270pjr.12.1686581744166; Mon, 12 Jun 2023 07:55:44 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5kXrwaJ9C/Vm8B3nuGlnAcnrrULoNEVuTfHPRYqrtROQr+8sOkNXBK/36ceSWR7MFR9Lunr3OH1vAXu/Na1zU= X-Received: by 2002:a17:90a:b8f:b0:25b:f764:580a with SMTP id 15-20020a17090a0b8f00b0025bf764580amr1423254pjr.12.1686581743904; Mon, 12 Jun 2023 07:55:43 -0700 (PDT) MIME-Version: 1.0 References: <20230608095759.1800617-1-zhirun.yan@intel.com> <20230608151844.1823783-1-zhirun.yan@intel.com> In-Reply-To: From: David Marchand Date: Mon, 12 Jun 2023 16:55:32 +0200 Message-ID: Subject: Re: [PATCH v11 00/16] graph enhancement for multi-core dispatch To: "Yan, Zhirun" Cc: Jerin Jacob , Thomas Monjalon , "dev@dpdk.org" , "jerinj@marvell.com" , "kirankumark@marvell.com" , "ndabilpuram@marvell.com" , "stephen@networkplumber.org" , "pbhagavatula@marvell.com" , "Liang, Cunming" , "Wang, Haiyue" , "mattias.ronnblom" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jun 9, 2023 at 5:48=E2=80=AFPM Yan, Zhirun w= rote: > > > Compilation is broken at patch 1 because of the file rename... > > > I hope I won't find anything else broken. > > > > Afaics, header exports are incorrect. I did not look further. > > > > About headers exports: if a public header (declared in headers meson > > var) includes sub_headerA,B,C, those sub headers must be listed either = in > > headers or indirect_headers meson variables. > > Otherwise those sub headers won't be distributed for external applicati= ons > > consumption. > > > The changed public header is used by lib/node/*, l3fwd-graph and graph-te= st. > > Actually the first patch rename the public header, and then 2nd patch cha= nge it back. > It caused the broken at 1. > > Patch 01 and 02 are split as 2 patches because I want to retain more git = history and make > git log clean. > I think it could be fixed by changing the used public header to the new n= ame in patch 01, > and change them back in patch 02. Is that a good way? Another option was to keep a (almost empty) rte_graph_worker.h header in patch 1 that includes the new _common header. Then update in patch 2, etc... > > > > For checking, I recommend running: > > git rebase -i origin/main -x 'DPDK_ABI_REF_VERSION=3Dv23.03 > > DPDK_BUILD_TEST_EXAMPLES=3Dall DPDK_BUILD_TEST_DIR=3D$HOME/builds/main > > ./devtools/test-meson-builds.sh' However, the v12 revision that got posted does not fix the other point I reported. If you split a public header, *all* sub headers must be exported as public headers too. I wrote some new test for the CI, and put the v12 series on top of it. As expected, inclusion of the graph header is broken out of dpdk. See the graph example compilation: https://github.com/david-marchand/dpdk/actions/runs/5244846217/jobs/9471420= 118#step:18:12092 --=20 David Marchand