From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E40A431FB; Wed, 25 Oct 2023 13:41:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 66684402F2; Wed, 25 Oct 2023 13:41:04 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E585C4029A for ; Wed, 25 Oct 2023 13:41:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698234062; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l/fsXtmNkiZ8jVemfKcVstHigGd37Zb9kHufm11ciF4=; b=TbMNA9Esc1DPwJZwYnBUqhWFTjwNnthD020IMIphgtTt+0wNYNLi/EeJtlE9UEMyUPz05N EOGK/IbKexSpJYOweqDxJNAY3F8ziUqdiz9xE/MCicC5VY0WaygJY0jXoSXBmbKOEU/3tS aojdg9gV3V7fBQ6lCPjZ/Zath2UPMxo= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-152-bqqLBdpYM_yw3ywuW3hrpw-1; Wed, 25 Oct 2023 07:40:53 -0400 X-MC-Unique: bqqLBdpYM_yw3ywuW3hrpw-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2c50255b905so51414671fa.0 for ; Wed, 25 Oct 2023 04:40:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698234051; x=1698838851; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l/fsXtmNkiZ8jVemfKcVstHigGd37Zb9kHufm11ciF4=; b=ve1oDljwODgcFGrx9WU/E9ctUS5u1Mi+EJMRindkITfdZdoVHM4B7xpkcLFaZ5ZOx9 lwhOlJ7TEktOC+6w/nVP3HnuCk3hGsfMunRGxwNbALqvwA6ShOSIVs6tzelvzkTsSik6 +NTg4vok8IVyg6cIZ33UCKwjZBqNomBAXMxBFjRXBqrIUCMexhYrmv/3kWQteC8hOi3m MyMYzqUfLZFPYoBbuiem4rfBnU/hPhkR3zVoWmDzMoXverHYAQdE/ymd+1lpM/QSxhlm fa0UWOLr3pQa1ORBpZ8wEptiqYG88wL3tH9DHi9fMiiFfWH4kkXPiUjLrh3pWGtdTnO9 gbNw== X-Gm-Message-State: AOJu0Yw/YAHbEENvsqwXewpF1UN0qELhhKO4bbqh4ZfgKvPbF8vDXC9C D6RMSInQYJA2xGlELeYWq/nvJkTYSME6TSU8RVkf/uxKvEkXo3EfJ3JzrUKBVG+Q4gcOwdR4pBW p7Z4W8IXlJAL0rtaWbao= X-Received: by 2002:a05:651c:2211:b0:2c5:3139:2d04 with SMTP id y17-20020a05651c221100b002c531392d04mr11742185ljq.47.1698234051558; Wed, 25 Oct 2023 04:40:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE7XTltwKSIDgAwocCDEfqd9550/xN4icQ0W+V52dZKipj1QZc27B9Py6GTiK9CUyctt6HYWdd87YUu0geBYNk= X-Received: by 2002:a05:651c:2211:b0:2c5:3139:2d04 with SMTP id y17-20020a05651c221100b002c531392d04mr11742172ljq.47.1698234051249; Wed, 25 Oct 2023 04:40:51 -0700 (PDT) MIME-Version: 1.0 References: <20231020084804.3625099-1-maxime.coquelin@redhat.com> In-Reply-To: <20231020084804.3625099-1-maxime.coquelin@redhat.com> From: David Marchand Date: Wed, 25 Oct 2023 13:40:39 +0200 Message-ID: Subject: Re: [PATCH v2 0/7] vhost: ensure virtqueue access status is checked To: Maxime Coquelin Cc: dev@dpdk.org, chenbo.xia@outlook.com, fengli@smartx.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Oct 20, 2023 at 10:48=E2=80=AFAM Maxime Coquelin wrote: > > Li Feng initially reported segmentation fault in rte_vhost_vring_call() > because of not checking the virtqueue metadata can be accessed. > > This should be achieved by checking the access_ok status field of > the virtqueue. > > This series also takes the opportunity to fix the other APIs. > This is split in multiple patches to ease LTS maintainers backports, > but could be squashed if preferred. > > Changes in v2: > -------------- > - Rebased to apply on -rc1 (David) > - Add Fixes tag in patch 1 (David) > - Fix various typos in commit logs (David) > > Maxime Coquelin (7): > vhost: fix missing vring call check on virtqueue access > vhost: fix missing check on virtqueue access > vhost: fix checking virtqueue access when notifying guest > vhost: fix check on virtqueue access in async registration > vhost: fix check on virtqueue access in in-flight getter > vhost: fix missing lock protection in power monitor API > vhost: fix checking virtqueue access in stats API > > lib/vhost/vhost.c | 92 +++++++++++++++++++++++++++++++++++++++++++---- > 1 file changed, 85 insertions(+), 7 deletions(-) For the series, Acked-by: David Marchand --=20 David Marchand