From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EA31F41BE7; Mon, 6 Feb 2023 09:12:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8633F42B71; Mon, 6 Feb 2023 09:12:57 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 83A5540FAE for ; Mon, 6 Feb 2023 09:12:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675671176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=j6bCTz1uOpsZIOjdsL+iChQIRA+aUtWAr43fOLewD6Y=; b=fE4mExe4L6V9yt9pJTsDxnJZ+nn1iEsvNwrW7ZbLcVPIiFfcVqkoJ7NRFg9k71mQk/CQmt Kdq2zgGcXs7/XlUMY9h4QzClDZthS41Wn+wdzNNiHDs4NVm8MSjiCJFLMvupndeYvxbQZ7 aIg9mKTqqQmeAzLzYQQuNzvJijjcDFQ= Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-665-KGKpIlhMOpav_Ehvl0XvGQ-1; Mon, 06 Feb 2023 03:12:53 -0500 X-MC-Unique: KGKpIlhMOpav_Ehvl0XvGQ-1 Received: by mail-pf1-f199.google.com with SMTP id z7-20020aa79587000000b00593f19705d5so6113324pfj.10 for ; Mon, 06 Feb 2023 00:12:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=j6bCTz1uOpsZIOjdsL+iChQIRA+aUtWAr43fOLewD6Y=; b=qBDyX/aV910qoc2805/1hKDggLKQqR7VifpfvIb8XSzulRRbo0BlpFu+9Gx9QxNufC hfJI0SgKVUKezFs0xIj4t0560A31YLg6KqG12bod9XoJ2Dc7eBDlQRJeKNjGskM1mi42 PvTrAVB+3TcEwZDO2cnqnzKIIhrBNuvaohDzACIa54lJ53xRjub0SSwxYr0zx/uyzez9 9IAHVIo8bVg/x23VppZQGLfIF9fp8rB4nX2Lx/uQFZw8wBQkY5XHy4jgUIfT6QAdF2Bx yltHUNefX4ZMgZHE7NjLBDE3ngUaHAWct7edFyHVVAybB1fCWl72n7ndWSzyqrKnLQqu GGSg== X-Gm-Message-State: AO0yUKWgxXineOl8oTmNnDmRwTqfPeoOZYAwTd3VC2UWSOmUL5S54lYS k0TjpRxTIEhSmNIeSZ2uSiSH05xp5oRiTlTMOQiYNNvSGgqR7MVchJmFDSerkvgjeiM29yn4dXl LCe5tDjqMpIv7xExTf0Q= X-Received: by 2002:a17:90a:9f91:b0:230:b57f:5229 with SMTP id o17-20020a17090a9f9100b00230b57f5229mr606991pjp.68.1675671172706; Mon, 06 Feb 2023 00:12:52 -0800 (PST) X-Google-Smtp-Source: AK7set9bFWDyZsH7WfGIjzE8h5tD3GAXO1pgQqdzLcJzncHEUbbn4rCxBNHmOfgtudq/ICX7qfD4AzXiAziTFalIjOA= X-Received: by 2002:a17:90a:9f91:b0:230:b57f:5229 with SMTP id o17-20020a17090a9f9100b00230b57f5229mr606973pjp.68.1675671172298; Mon, 06 Feb 2023 00:12:52 -0800 (PST) MIME-Version: 1.0 References: <20220328121758.26632-1-david.marchand@redhat.com> <20230201111411.1509520-1-david.marchand@redhat.com> <20230201111411.1509520-2-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Mon, 6 Feb 2023 09:12:41 +0100 Message-ID: Subject: Re: [PATCH v5 1/9] eal: annotate spinlock, rwlock and seqlock To: "Tu, Lijuan" Cc: "Chen, Zhaoyan" , sys_stv , "dev@dpdk.org" , "Coquelin, Maxime" , "stephen@networkplumber.org" , "Xia, Chenbo" , "Hu, Jiayu" , "Wang, YuanX" , "Ding, Xuan" , "mb@smartsharesystems.com" , "Burakov, Anatoly" , "mattias.ronnblom" , David Christensen , "Richardson, Bruce" , Konstantin Ananyev , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, On Mon, Feb 6, 2023 at 2:02 AM Tu, Lijuan wrote: > > I received this report: > > http://mails.dpdk.org/archives/test-report/2023-February/345705.html > > > > FAILED: doc/api/html > > /usr/bin/python3 ../doc/api/generate_doxygen.py doc/api/html > > /usr/bin/doxygen doc/api/doxy-api.conf > > /root/UB2204-64_K5.15.0_GCC11.3.0/x86_64-native-linuxapp- > > doc/26733/dpdk/lib/eal/include/rte_seqlock.h:218: > > error: Found ')' without opening '(' for trailing return type ' -> lock)...' (warning > > treated as error, aborting now) Traceback (most recent call last): > > File "/root/UB2204-64_K5.15.0_GCC11.3.0/x86_64-native-linuxapp- > > doc/26733/dpdk/x86_64-native-linuxapp-doc/../doc/api/generate_doxygen.py", > > line 13, in > > subprocess.run(doxygen_command, check=True, stdout=out) > > File "/usr/lib/python3.10/subprocess.py", line 524, in run > > raise CalledProcessError(retcode, process.args, > > subprocess.CalledProcessError: Command '['/usr/bin/doxygen', 'doc/api/doxy- > > api.conf']' returned non-zero exit status 1. > > > > This error is what the patch 1 in this series (with the doc/api/doxy-api.conf.in > > update) tries to avoid. > > > > I tested my series in a fresh Ubuntu 22.04 container and I can't reproduce this > > error. > > Please share how this test was run in your lab so I can replicate. > > Sorry, bothered you. There is no error with this series. > > The error is caused by the CI doesn't apply any changes with doc/*. > Community decided to exclude doc/*, as doc/* change frequently, > especially the release notes, cause a lot of conflict with main tree. > > Here is command we used: > git pw series apply 26733 --exclude=doc/** > > We will raise a discussion for this in community CI meeting. > My thought is to narrow down exclude scope to doc/guides or > doc/guides/rel_notes/* Ok, thanks for the analysis. - I was not aware of such behavior (I probably missed it in CI minutes). Is this something that only Intel CI does? At least for GHA, I am sure it is not the case. - What is the point of calling the documentation generation target if doc/ updates are ignored? -- David Marchand