Re: [dpdk-dev] [PATCH] ci: increase unit test timeout

[David Marchand <david.marchand@redhat.com>]

On Thu, Jan 30, 2020 at 12:03 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 28/01/2020 21:53, Aaron Conole:
> > Ferruh Yigit <ferruh.yigit@intel.com> writes:
> >
> > > Timeout multiplier was 3, which gives 30 seconds for unit test but still
> > > some unit test was timing out time to time and travis reporting false
> > > positive failures.
> > >
> > > Increasing the multiplier to 10, which makes timeout duration
> > > 100seconds.
> > >
> > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > > ---
> >
> > It's okay to me.  I thought there was an effort to split out performance
> > part of this test from the functional part, but that seems to not have
> > gone anywhere.
> >
> > Acked-by: Aaron Conole <aconole@redhat.com>
>
> NACK
> The fix should be to split perf tests out of fast-tests.
>
> The following patch is splitting hash_readwrite_autotest:
>         https://patchwork.dpdk.org/patch/58726/
> But we are still waiting for a patch splitting hash_readwrite_lf_autotest.
> Please consider working on unit tests as a HIGH PRIORITY (using uppercase ;).
> We should not have to wait so long to see performance tests removed
> from fast unit tests (while keeping the functional coverage).

Just applied series
https://patchwork.dpdk.org/project/dpdk/list/?series=8401&state=*.
So marking this patch as rejected.

Thanks.


-- 
David Marchand