From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0AC80A046B for ; Wed, 26 Jun 2019 15:54:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0F0B72B82; Wed, 26 Jun 2019 15:54:16 +0200 (CEST) Received: from mail-ua1-f65.google.com (mail-ua1-f65.google.com [209.85.222.65]) by dpdk.org (Postfix) with ESMTP id 0A04FF04 for ; Wed, 26 Jun 2019 15:54:15 +0200 (CEST) Received: by mail-ua1-f65.google.com with SMTP id j21so788703uap.2 for ; Wed, 26 Jun 2019 06:54:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wXg8kp4y9tKStMTwwe0+kgEwPLuja8XIEbyx/R6Wz8w=; b=ntYxljBPPPraZEUEFSU5+mtwPCsLLen7X8fcJWCnM6iO3CPtkRrDHURqekl7YC5cUt UmbnuvQnJxHn0kf2Mh7KtzkzhUm1+bsB1V15Wsh8JL9JIk377GQ1SkvX5rZh/gJFXuwW WRh7H0C0TszrBm1Ih4lqui6GNDu8WzCk0bX44unObIRdU8ZaYOAfsiA1bDIMR+dJnf3u 6UPXvq01RiEy8MiR0U0RwBY3GQlhRoUIa9AStCEZ/9dQ00Y6g2OVTSFgeh1XEqB5Ve0/ e/kvtQmCAGacTazKVzyaY9hLVmK0npF4MdhH+x+Xv95iw9PDn67fa3Z0LvL0sEXV5h3r yhCQ== X-Gm-Message-State: APjAAAWnLswx0o3/t/u695mlJpBA4psBDQtxcGL+vDaYb/a6HJdv3arz G4eZ+NXDUIpXodETkCb8xt+KMjFmnHRK0yr+McZi4w== X-Google-Smtp-Source: APXvYqx+8CT7evf2PBfpOOhsgDLfF5F93Nhvq1nvTzgXZxCAUs20/vDEaYTyjgqzr9l5P6vpUl3kWqJ6VSFSS90QaQo= X-Received: by 2002:ab0:b99:: with SMTP id c25mr2626332uak.53.1561557254373; Wed, 26 Jun 2019 06:54:14 -0700 (PDT) MIME-Version: 1.0 References: <1560519475-9666-1-git-send-email-pallantlax.poornima@intel.com> <1561556725-6671-1-git-send-email-pallantlax.poornima@intel.com> In-Reply-To: <1561556725-6671-1-git-send-email-pallantlax.poornima@intel.com> From: David Marchand Date: Wed, 26 Jun 2019 15:54:03 +0200 Message-ID: To: Pallantla Poornima Cc: dev , "Pattan, Reshma" , "Burakov, Anatoly" Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2] test/eal: add ut cases for in-memory and single-file-segment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jun 26, 2019 at 3:47 PM Pallantla Poornima < pallantlax.poornima@intel.com> wrote: > Added unit test case for eal command line 'in-memory' option > which will cover below functions. > get_seg_memfd() > test_memfd_create() > pagesz_flags() > > Added unit test case for eal command line 'single-file-segments' option > which will cover resize_hugefile(). > > Signed-off-by: Pallantla Poornima > Reviewed-by: Anatoly Burakov > --- > v2: Removed snprintf as suggested > --- > app/test/test_eal_flags.c | 66 +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 66 insertions(+) > > diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c > index 9112c96d0..85f4fc64a 100644 > --- a/app/test/test_eal_flags.c > +++ b/app/test/test_eal_flags.c > @@ -1010,6 +1010,24 @@ test_file_prefix(void) > const char *argv4[] = {prgname, "-c", "1", "-n", "2", "-m", > DEFAULT_MEM_SIZE, "--file-prefix=" memtest2 }; > > + /* primary process with inmemory mode */ > + const char * const argv5[] = {prgname, "-c", "1", "-n", "2", "-m", > + DEFAULT_MEM_SIZE, "--in-memory" }; > + > + /* primary process with memtest1 and inmemory mode */ > + const char * const argv6[] = {prgname, "-c", "1", "-n", "2", "-m", > + DEFAULT_MEM_SIZE, "--in-memory", > + "--file-prefix=" memtest1 }; > + > + /* primary process with parent file-prefix and inmemory mode */ > + const char * const argv7[] = {prgname, "-c", "1", "-n", "2", "-m", > + DEFAULT_MEM_SIZE, "--in-memory", "--file-prefix", prefix }; > + > + /* primary process with memtest1 and single-file-segments mode */ > + const char * const argv8[] = {prgname, "-c", "1", "-n", "2", "-m", > + DEFAULT_MEM_SIZE, "--single-file-segments", > + "--file-prefix=" memtest1 }; > + > Same comment than http://patchwork.dpdk.org/patch/55169/ Please drop -n and -c options if there is no requirement for the tests to run. -- David Marchand