From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E5ED45A82; Wed, 2 Oct 2024 21:09:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0C03D402A7; Wed, 2 Oct 2024 21:09:03 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C717040299 for ; Wed, 2 Oct 2024 21:09:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727896141; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NgnGvdyGhS3wVD+fk0F035AILaToOzpOgeYc+ufR64c=; b=YGYyJz/NqsOCypBGxC/he6TQWfGuJko56OipGSeKa/fprbCY0GBgnHWUyDe2+NqdRz5BzY 29tVC4q5RSeByvGIThZhl0BRh/KCz5JnctZqGg920cntlZTnqMepQKlHP0qBYSdXy37SnS K5Hm5IXMq1DXcVPVC5cX56k7NP95EKU= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-132-Y92Z_i3SObesKkWfLKHCvw-1; Wed, 02 Oct 2024 15:09:00 -0400 X-MC-Unique: Y92Z_i3SObesKkWfLKHCvw-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2fac0c2d49fso1014771fa.1 for ; Wed, 02 Oct 2024 12:09:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727896139; x=1728500939; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NgnGvdyGhS3wVD+fk0F035AILaToOzpOgeYc+ufR64c=; b=O2NWCC3FdJF/viabn+aEhO50lRtYLo5+saqz1cHfS05ED9LPc4VufpghWoMknoWWRr +jKFMURveVLjrPw+8AklDJuq6deT4se0tvywckmwn44llvAtoOLPzFpuFRaaCU4Qhdjt eeoE3RXDtQMcVGjDuccw67GiYRWWV1+xhEXkhSTH0t+tExsjPYKlI/H9ygaVeHmHqEiB Zg9SueoqxUzfUm+CATrgxY62oCwCf/u/2faexJMeQj/UhqH4xtCc9J8Nb4AFcI4WqzfX exdOLsS81FiLYJZzY1BOK5qAkEeiJLbXMUPc0ycoGhvSyNhs3qcUMFvVquHwawm4mePL Kd0A== X-Forwarded-Encrypted: i=1; AJvYcCWfQV8E4ADrAuOEjitcsdHh1ZBdmTEe4NHXghiIMi4MMbI2xqNVyTJDq+Vfekfw6s2WeDk=@dpdk.org X-Gm-Message-State: AOJu0Yy0/uGGqqqap535lNc/wpZM1jTxnPayUKxQ6IHve3fOE87zV6Vv Fb6em4XYMyrYF4TTSqUuSucWxtz0tpOdK02mHJ2cpaJqOhP9wKQllwWErESPdTYeypCdu6Ea1Lq XlgY7yjEqLzk3D8WDFNf1q8q8zdQTmj+qVn6yUSol2iCZNyNcc+d73RXGpGKwsC4hOi+1I+yNbf Esqfo3luspE/RNqqY= X-Received: by 2002:a05:651c:508:b0:2f6:1d35:1491 with SMTP id 38308e7fff4ca-2fae1013f1fmr26793691fa.15.1727896138654; Wed, 02 Oct 2024 12:08:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH2lk06w0teyrLrMklpk3ARIKUhBmSqm6hF1Rlum6EM8tB96AdrfcoAGJhxAWsWHDiIq1wVlIRAMVkJrcxYhyY= X-Received: by 2002:a05:651c:508:b0:2f6:1d35:1491 with SMTP id 38308e7fff4ca-2fae1013f1fmr26793531fa.15.1727896138218; Wed, 02 Oct 2024 12:08:58 -0700 (PDT) MIME-Version: 1.0 References: <20240809202539.590510-1-mattias.ronnblom@ericsson.com> <20240909191103.697554-1-mattias.ronnblom@ericsson.com> In-Reply-To: From: David Marchand Date: Wed, 2 Oct 2024 21:08:47 +0200 Message-ID: Subject: Re: [PATCH v2] service: extend service function call statistics To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , dev@dpdk.org, harry.van.haaren@intel.com, Stefan Sundkvist X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 2, 2024 at 8:57=E2=80=AFPM Mattias R=C3=B6nnblom wrote: > > Coverity flagged this patch with issue #445158. > > rte_delay_ms() is now unreachable. > > > > I suppose this delay is not that important for the unit test and we > > can remove it, but as I am not sure I'll let you have a look and send > > a fix. > > > > It works without it I think, but I would keep it, and add it to the > "case 0" branch. > > Let me know if you want a v2. Unfortunately, coverity is run only for merged stuff. So the report we got is for merged patch in the main repo. Please send a fix. --=20 David Marchand