From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44D00A0C46; Fri, 17 Sep 2021 13:55:32 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB464406B4; Fri, 17 Sep 2021 13:55:31 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 08D7440689 for ; Fri, 17 Sep 2021 13:55:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631879729; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ifzUHBBrvuxYd8QUh+r3Hk62eHYY7aJZybtAtQYCOc0=; b=R9tVAOzELnCoRqSZA19qMaSKtdTNJMvcLBZJw/LNlMyfStRW8k9mQ8vbI093GbdEcceCgt qUY/7HJMTWz2xVctcwCu6KrxHL8EnnGMrKWav/WtMY6kqm6au1Of3YGXlkYxoojcK1ei9S D1wgUOsdNTy2yGEQxlYE/SSQg1l+h8c= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-286-S_cajTuMMiSwMMHy20dKFQ-1; Fri, 17 Sep 2021 07:55:28 -0400 X-MC-Unique: S_cajTuMMiSwMMHy20dKFQ-1 Received: by mail-lf1-f71.google.com with SMTP id q5-20020ac25fc5000000b003d9227d9edcso6539088lfg.2 for ; Fri, 17 Sep 2021 04:55:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ifzUHBBrvuxYd8QUh+r3Hk62eHYY7aJZybtAtQYCOc0=; b=LRln135Ipo+LU+elDHGuSQZS89uI/+BRKw4pLfgm1HYZ7V0HsnNhtzibUIBGRv7QNF DkV7OxOvqNV/Ux1OZVZq+kRlEMve3QvRSJjr34B3933JjCt08uuoer/GSDYRiyReFC+9 raK5Bxfn5tSiM+SH/wJ39Vx8hszC8KmPt44myRDHM1SL/brh5VK1Y81BhL9Nm4SawSbs lxnsImu01Rul1P3qp0SjUWrSmEL2KZ8JUe2Fkjl31+fCufJ7kjsEMfFF6FOHe/AvU/gd aKdR8B1DhThpyfirvSjQU4V9dyctBhsltUUY5TRUKsSSEBG/OQM38CtbI133bR9FVtes 3MRg== X-Gm-Message-State: AOAM531oU4uC86IBbSBhweJ9i+Dt+sX/xfC86bfF+o96j0ASP1Kf6qHA exEjYiPbwICQXJ3xd2CY8v6JQpDpBPIsC2IRogA1BQ+KdIFN2fGzSAPioSbDr/9WlrBFWcRiron UDPo/ht5/5oHj3zvvYFU= X-Received: by 2002:a05:6512:31c3:: with SMTP id j3mr1123141lfe.217.1631879726511; Fri, 17 Sep 2021 04:55:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy9supWJkKUA+iaGLOfVXnX+etb9z+04vo+XzsrSC3OCVZp66zWJvY/2MtSA0OquU66EX7q7iUZFWK3/c8XRBc= X-Received: by 2002:a05:6512:31c3:: with SMTP id j3mr1123126lfe.217.1631879726257; Fri, 17 Sep 2021 04:55:26 -0700 (PDT) MIME-Version: 1.0 References: <20210910022402.26620-1-chenbo.xia@intel.com> <20210910022402.26620-7-chenbo.xia@intel.com> In-Reply-To: From: David Marchand Date: Fri, 17 Sep 2021 13:55:14 +0200 Message-ID: To: "Xia, Chenbo" , "Yigit, Ferruh" Cc: dev , "Dumitrescu, Cristian" , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 6/8] examples/ip_pipeline: remove setting of PCI ID and address X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Chenbo, On Fri, Sep 17, 2021 at 5:09 AM Xia, Chenbo wrote: > > > PCI ID and address in structure rte_kni_conf are never used and > > > will be removed in kni library. So remove the setting of them > > > first in the example. > > > > > > Signed-off-by: Chenbo Xia > > > > (forgot to Cc: Ferruh in previous comment) > > Ditto patch 5. > > > > I would tag with a Fixes: on ethtool removal. > > Plus, this is the same kind of cleanup wrt kni, you can squash those > > two patches together. > > A question about squash patch 5 and 6, then how should I title the combined > patch? Because there're both test change and example change. I'd like know > your suggestion. > > This is a cleanup on unused fields wrt KNI. "kni: remove unused PCI info from test and example" lgtm. Ferruh, opinion? And mark with: Fixes: ea6b39b5b847 ("kni: remove ethtool support") -- David Marchand