From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3540DA04F3; Fri, 20 Dec 2019 15:43:39 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BE1E71C01; Fri, 20 Dec 2019 15:43:37 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 655A9235 for ; Fri, 20 Dec 2019 15:43:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576853015; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=atLwKjdmI+DjBOq/muQhPaDT5OCepmrJ78BLgNPdFPs=; b=Qcp+uDNTP5RDfnyxCyGxYSwgtq4zviRFZvx9bIOHSS1DT+fIlkhWa0F1oVrxQbyDlzKIEY ZIeKlH1E6T1YgXwMm5DucZiOqXoX4TsjrQIvFfQ28BSiCMohqhSF9c1f16E3RRZFu8MYr5 mcqNLMZMvnVKOKNFrQv4qd+yqQF50Lg= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-185-cmXYFF9JOuKJGYiEFHYNPg-1; Fri, 20 Dec 2019 09:43:32 -0500 Received: by mail-vk1-f199.google.com with SMTP id s205so4020031vka.17 for ; Fri, 20 Dec 2019 06:43:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fA1U9dIgzGYc9NRTcBOMpS4UxsTgOIeikKJbm9IA250=; b=KbC9yl2QiyX51Y5Bhd74D4zMHcB6+QWH0wnHPvO9ECW/kdhI3Unts65aV8LElnZ1sv ktkDemtSDPKaS4uAA9B5FRFvMbgHnAmI4hUh2DeQZuRKqGMvPHk3VZaOVQn5xKFSg2fE laePvQGdKBM+CIRCi8bn7EcGdFERhyxBWc9xvr0G0eWq4qyn31MnDDAUmveK2Pxe03XH IjBo29hmQZ7NdNjX2MdInrJ8ilzSPr27DL42bwzeqtnkFog6iJazDeXl72Sfd4FgNnXZ ZkpiADqwoyWCpIGikKQ2HO48W0rryz+2DdW4m/2bYy0QMfkINePZTfIiXoOkhhwZuOBn q2WQ== X-Gm-Message-State: APjAAAXaHDgiUFj3dnq3e7J/EUiAR5xPwbTFws0qdgYqtPm/zXdEFkYR wenefUi9jePS1sJY1PxTixTNQaZtajSxKY5mVmUpKRPxTmw9JFi8GmpQP3/6SggeFw/9QbGqiVl E6UcWtCQpwhQZMrDbn7A= X-Received: by 2002:a1f:72c3:: with SMTP id n186mr9769083vkc.12.1576853011924; Fri, 20 Dec 2019 06:43:31 -0800 (PST) X-Google-Smtp-Source: APXvYqxSlPvWGKvup9uoiGhTCFzSQZjzVd3gDC2XEWcwWb9JbbsIycYRjIXw6N2eJOFG273ADRQ4BKRTuz2V+rC6Djc= X-Received: by 2002:a1f:72c3:: with SMTP id n186mr9769070vkc.12.1576853011668; Fri, 20 Dec 2019 06:43:31 -0800 (PST) MIME-Version: 1.0 References: <20191204205241.5691-1-david.marchand@redhat.com> <20191220140149.1043-1-david.marchand@redhat.com> In-Reply-To: <20191220140149.1043-1-david.marchand@redhat.com> From: David Marchand Date: Fri, 20 Dec 2019 15:43:20 +0100 Message-ID: To: dev Cc: Aaron Conole , dpdk stable X-MC-Unique: cmXYFF9JOuKJGYiEFHYNPg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] test/common: fix log2 check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Dec 20, 2019 at 3:02 PM David Marchand wrote: > > We recently started to get random failures on the common_autotest ut with > clang on Ubuntu 16.04.6. > > Example: https://travis-ci.com/DPDK/dpdk/jobs/263177424 > > Wrong rte_log2_u64(0) val 0, expected ffffffff > Test Failed > > The ut passes 0 to log2() to get an expected value. > > Quoting log2 / log(3) manual: > If x is zero, then a pole error occurs, and the functions return > -HUGE_VAL, -HUGE_VALF, or -HUGE_VALL, respectively. > > rte_log2_uXX helpers handle 0 as a special value and return 0. > Let's have dedicated tests for this case. > > Fixes: 05c4345ef5c2 ("test: add unit test for integer log2 function") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > Acked-by: Aaron Conole Applied with mentioned fix. --=20 David Marchand