From: David Marchand <david.marchand@redhat.com>
To: Eli Britstein <elibr@nvidia.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
Asaf Penso <asafp@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH V2 1/1] eal: fix build with conflicting libc variable memory_order
Date: Thu, 15 Oct 2020 18:49:15 +0200 [thread overview]
Message-ID: <CAJFAV8x25DzLSfOmutUKWjZdc-d=bKUy7vnf=A-FQCZYA9E9kA@mail.gmail.com> (raw)
In-Reply-To: <20201015151017.8060-1-elibr@nvidia.com>
On Thu, Oct 15, 2020 at 5:10 PM Eli Britstein <elibr@nvidia.com> wrote:
>
> The cited commit introduced functions with 'int memory_order' argument.
> The C11 standard section 7.17.1.4 defines 'memory_order' as the
> "enumerated type whose enumerators identify memory ordering constraints".
>
> A compilation error occurs:
> error: declaration of 'memory_order' shadows a global declaration
> [-Werror=shadow]
> rte_atomic_thread_fence(int memory_order)
>
> This issue was hit when trying to compile OVS with gcc 4.8.5. This
> compiler version does not provide stdatomic.h, so enum memory_order is
> redefined in OVS code.
> In another case, if the compiler does provide stdatomic.h header,
> passing -Wsystem-headers in the CFLAGS will also cause that failure.
>
> Fix it by changing the argument name 'memory_order' to 'memorder'.
>
> Fixes: 672a15056380 ("eal: add wrapper for C11 atomic thread fence")
>
> Signed-off-by: Eli Britstein <elibr@nvidia.com>
Please, report previous review/acks, and thread replies with original.
Reviewed-by: Asaf Penso <asafp@nvidia.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: David Marchand <david.marchand@redhat.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2020-10-15 16:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-15 15:10 Eli Britstein
2020-10-15 16:46 ` Honnappa Nagarahalli
2020-10-15 16:49 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8x25DzLSfOmutUKWjZdc-d=bKUy7vnf=A-FQCZYA9E9kA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=asafp@nvidia.com \
--cc=dev@dpdk.org \
--cc=elibr@nvidia.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).