From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28111A046B for ; Thu, 25 Jul 2019 21:07:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 98A391C390; Thu, 25 Jul 2019 21:07:29 +0200 (CEST) Received: from mail-ua1-f66.google.com (mail-ua1-f66.google.com [209.85.222.66]) by dpdk.org (Postfix) with ESMTP id DAA361C390 for ; Thu, 25 Jul 2019 21:07:28 +0200 (CEST) Received: by mail-ua1-f66.google.com with SMTP id o19so20284968uap.13 for ; Thu, 25 Jul 2019 12:07:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XVqowcMqz5BWpxyH6Lmdh+n5hvHhgiwboNzV7wW21ZE=; b=Z83wyTEEji491VLLt+6Q2a+HKYBPdZCF8pXHovJA77gTgXi0qqda4Wj4Pnooo9dTaD uUXfZt+uipOFE0Osnu47Kr2j4JZPwRDPrRFmvSPiXfAIQ0mDdTtwh2ba3zLlfUjJIGZO ln4ex5Os2izVl8KegV/uYIlputn7cWnuj3aICuBEQX5MKoaFzwr1yPgdgeNbAMYxa7V1 7gxap3gQOggArkl9hk4KEqh+5EQX9G6YnqSVVVXa29ZzzxOkzx4YJP4nKz3s13psYzER 2ZKZ3eiu0FUj5Yl7FCSaUw/nH9KzX8roJKP5N8AXTtnvVAjS4V3jF5u76Chpl0wrKxtF UeKw== X-Gm-Message-State: APjAAAXin1usOR58LXfyTFcJkXc7YQQlQDTE4VVWijOIc3Y1ZVbevJR1 So7P8uBgAWaWDqOWq+iXs35QlEdAx0zYcWKrcH1QOCCJ X-Google-Smtp-Source: APXvYqw70L771H+pN5MtrwPukN1ocHPlU6YHnnyWHnpzE7elNTbZTW9nPQ4JXGNQF8ka8/FlY3zClKX9g/mDtOusVCw= X-Received: by 2002:ab0:3003:: with SMTP id f3mr48686741ual.86.1564081648270; Thu, 25 Jul 2019 12:07:28 -0700 (PDT) MIME-Version: 1.0 References: <1564046068-21905-1-git-send-email-david.marchand@redhat.com> <1564046068-21905-6-git-send-email-david.marchand@redhat.com> <2cab227c-5e9d-00e1-a6c7-e8f02eb0f6e4@intel.com> In-Reply-To: <2cab227c-5e9d-00e1-a6c7-e8f02eb0f6e4@intel.com> From: David Marchand Date: Thu, 25 Jul 2019 21:07:17 +0200 Message-ID: To: Ferruh Yigit Cc: dev , dpdk stable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 5/8] net/kni: do not count unsent packets as errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 25, 2019 at 6:12 PM Ferruh Yigit wrote: > > On 7/25/2019 10:14 AM, David Marchand wrote: > > err_pkts reflects the number of packets that the driver did not manage to > > send. > > This is a temporary situation, those packets are not freed and the > > application can still retry to send them later. > > Hence, we can't count them as transmit failed. > > 'err_pkts' seems calculated wrong both in Rx & Tx and KNI PMD, looks like we can > remove it completely, what do you think? On the rx side, I agree that err_pkts makes little sense. On the tx side, it can be seen as a "tx full" counter. So not sure about the tx side, but I sure can remove the rx part (in a separate patch?). -- David Marchand