From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A3F2BA04DD; Wed, 28 Oct 2020 09:55:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AA47CBE49; Wed, 28 Oct 2020 09:55:19 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 2CCFEBE3F for ; Wed, 28 Oct 2020 09:55:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603875315; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Wxq77g6YRbrks/hguj6OejRJUxuMqi7Ccau5PY0qhi4=; b=g1DlNRU9APUlqRr/gb2772x1yqsWFH99FiaFqvlxuhKeIG+ld5IqUbj0ce27YScvjCHebv HQaeigBWiylnkWa4yyc3dnkKhtAaVdeeKoaxrPF6vtF+KZsQqNdrqGQtFl14cVOjKQlykp udJQ88INB0eb8iOLIsHzlYI11z3QsPk= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-214-M4Jd0t4zNZaCPOw1Qbg_kw-1; Wed, 28 Oct 2020 04:55:13 -0400 X-MC-Unique: M4Jd0t4zNZaCPOw1Qbg_kw-1 Received: by mail-ua1-f71.google.com with SMTP id 36so387167uaw.18 for ; Wed, 28 Oct 2020 01:55:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Wxq77g6YRbrks/hguj6OejRJUxuMqi7Ccau5PY0qhi4=; b=iJp++WL9gE33XbW0KqxD4tFoinDrABCqWLIg8xwsVW6hVhPlMNUnschFehgeuV8QTt zDBt8Q02Hw3o7GhpnFFzFLB2vqaHYPzMeBf5tmlaQLE7BIEY2rbLse+E1wzcR4mMB3y/ RIMn7wez2P/AfpLwZX4vZ4D2JtJ0yruw5VQGXnoD3DG/0RNZJQ/uFQ/6dWIBNVOMGje+ YEhuuO3Un66JSZvaCQz0QjPCBtgtQtnUKOkvW4zrdtuojSrtX3Gibal7r6eqd4dnU94+ HWdhco31nAwZFoVvdGryEMXb+F92gC9EifIjUujoCAj7dDdf5zL/FPYyNAyQxM0YTiVF StPw== X-Gm-Message-State: AOAM531+lydE1kaHMTe1UQMkOxmISjKDoNs487j0X6d5D8T+NYImJ/vX 2tgQx+o3iX+wlgNd90izsYCpeeO1lChYNpXPBTUMmXxSkwd0Qtya7ECc238uZZbC9JAry7OiG9d sfuFO6ZZVeI3gQg1t/94= X-Received: by 2002:a67:f954:: with SMTP id u20mr4477203vsq.5.1603875312736; Wed, 28 Oct 2020 01:55:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzDronBqnGN2/hXiNWghlxZ5ZkTi3TcD2ZVhUd/Z/DRrAvjqAdQjqJvBou7P5ou6y5wDeiofrdzRp1WUEjhCoQ= X-Received: by 2002:a67:f954:: with SMTP id u20mr4477187vsq.5.1603875312374; Wed, 28 Oct 2020 01:55:12 -0700 (PDT) MIME-Version: 1.0 References: <20201027221343.28551-1-david.marchand@redhat.com> <20201027221343.28551-8-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Wed, 28 Oct 2020 09:55:01 +0100 Message-ID: To: Jerin Jacob Cc: "McDaniel, Timothy" , dpdk-dev , Jerin Jacob , Pavan Nikhilesh , Liang Ma , Peter Mccarthy , Harry van Haaren , Ray Kinsella , Neil Horman Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 7/8] event: switch sequence number to dynamic field X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 28, 2020 at 8:27 AM Jerin Jacob wrote: > > diff --git a/app/test-eventdev/test_order_common.h b/app/test-eventdev/test_order_common.h > > index 9e3415e421..d4ad31da46 100644 > > --- a/app/test-eventdev/test_order_common.h > > +++ b/app/test-eventdev/test_order_common.h > > @@ -89,9 +89,10 @@ order_process_stage_1(struct test_order *const t, > > { > > const uint32_t flow = (uintptr_t)ev->mbuf % nb_flows; > > /* compare the seqn against expected value */ > > - if (ev->mbuf->seqn != expected_flow_seq[flow]) { > > + if (*rte_event_test_seqn(ev->mbuf) != expected_flow_seq[flow]) { > > evt_err("flow=%x seqn mismatch got=%x expected=%x", > > - flow, ev->mbuf->seqn, expected_flow_seq[flow]); > > + flow, *rte_event_test_seqn(ev->mbuf), > > + expected_flow_seq[flow]); > > t->err = true; > > rte_smp_wmb(); > > } > > # Since rte_event_test_seqn_dynfield_register() is the public API, I > would like to limit the scope > only to self test so that rte_event_test_seqn_dynfield_register() > need not be exposed. > Could you have a separate application-specific dynamic field here? > # Also this patch used in fastpath, better to have offset stored in > fastpath cache line. > see http://mails.dpdk.org/archives/dev/2020-October/189588.html Ack for a test app dynamic field. On the second comment, I'll wait for Thomas respin. > > diff --git a/lib/librte_eventdev/version.map b/lib/librte_eventdev/version.map > > index 8ae8420f9b..e49382ba99 100644 > > --- a/lib/librte_eventdev/version.map > > +++ b/lib/librte_eventdev/version.map > > @@ -138,4 +138,6 @@ EXPERIMENTAL { > > __rte_eventdev_trace_port_setup; > > # added in 20.11 > > rte_event_pmd_pci_probe_named; > > + rte_event_test_seqn_dynfield_offset; > > + rte_event_test_seqn_dynfield_register; > > Could you change symbol name to rte_event_dev_selftest_seqn_dynfield_offset() > to limit the scope only to self test. also, it is not required to expose > rte_event_test_seqn_dynfield_register() in that case. How about moving this to rte_eventdev_pmd.h and make it a pmd only API? => rte_event_pmd_ prefix I would mark it rte_internal too. -- David Marchand