From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1AA4EA3168 for ; Wed, 16 Oct 2019 12:55:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 57F041E925; Wed, 16 Oct 2019 12:55:45 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 498F81E910 for ; Wed, 16 Oct 2019 12:55:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571223343; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2AphQcffHPOy8eI62zSinye6DXqXZNpjT2Q54b+ruoM=; b=U/RHyl8Swp3WA7whr9Ethl+NOLOD8C1heqMmTIAF8TnwqfB+osUyZlyhYuxUyaxhPxaYY5 TdsbWKGn2XSP04jNIumnbsU5A7ZXjSo1CFCHQ/bPj+KpmVjj204/1INTNIffEeLzrx2N+y 7ya7hTuLVzZuKtRGCYBFLvUkiTsYLOU= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-35-mgkDUTf8PZmYK4oTU5wF5w-1; Wed, 16 Oct 2019 06:55:40 -0400 Received: by mail-vk1-f198.google.com with SMTP id q84so9474310vkb.12 for ; Wed, 16 Oct 2019 03:55:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9ZWlM5lRyGpWzJ+iNRjR5qMeBRtx4ti4UYC0LQC5t7M=; b=Sk0Yh78dzcSbRsPZy9byWRM++v2Y5SQd4GAtH+Khy87fX4fahaoF68ltl7Q71ls5w9 1UgIMJBa66HI9TXQ+4AZBAIYdwOpWixiJ5NHXGwv7Ti4Nh+FRMvJTauhpC4WeSCxmXvo e7rIzdh+bF1uakqrmKPo7mNg60E0wqvQYpYilWCIpQuG1KF7+YwP1m39kIO3/OVjjuib fH3gK2eu5bcyGXwmMgNHoQ+P+r12yG4krik5tAN5a6QCCQbu7MVoHaAXyzKv8ggZK/7Z CJH4+uzXqR1Xo9dXuV4ftyavpkXCHTufRLqlK+WIHiK71icbrqt5/43yt0Uo2wpTKqsF L1qg== X-Gm-Message-State: APjAAAX/g8yUIMDxjOHiGp9xsy1wrplMAapVEFBB1KLvvf2KTxaYj5VW j/I3yD35xWM8ohJaE0VHKdedAdpi2AmRw7DDe3fjGj/C36bddCa9NkiSbmU06r+j2CpRsofLW7p DlBBZviookXU6qMgdID0= X-Received: by 2002:a1f:3811:: with SMTP id f17mr20781059vka.56.1571223340020; Wed, 16 Oct 2019 03:55:40 -0700 (PDT) X-Google-Smtp-Source: APXvYqxA/L383xmf5Sj8HTm0FxfzjXc8sl8Jk+YTKTbBHtlRtm+dWcnyQrtxqR37EwbUYyp8cVRFfA7roYZjCE7ym3k= X-Received: by 2002:a1f:3811:: with SMTP id f17mr20781053vka.56.1571223339611; Wed, 16 Oct 2019 03:55:39 -0700 (PDT) MIME-Version: 1.0 References: <20190919112257.85337-1-iryzhov@nfware.com> <6c6e0326-46fa-8454-2f40-8173fee96858@intel.com> In-Reply-To: From: David Marchand Date: Wed, 16 Oct 2019 12:55:27 +0200 Message-ID: To: Ferruh Yigit Cc: Igor Ryzhov , dev X-MC-Unique: mgkDUTf8PZmYK4oTU5wF5w-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] kni: add ability to set min/max MTU X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 16, 2019 at 12:43 PM Ferruh Yigit wrot= e: > > On 10/16/2019 7:40 AM, David Marchand wrote: > > On Fri, Oct 11, 2019 at 6:16 PM Ferruh Yigit w= rote: > >> > >> On 9/19/2019 12:22 PM, Igor Ryzhov wrote: > >>> Starting with kernel version 4.10, there are new min/max MTU values i= n > >>> net_device structure, which are set to ETH_MIN_MTU and ETH_DATA_LEN b= y > >>> default. We should be able to change these values to allow MTU more t= han > >>> 1500 to be set on KNI. > >>> > >>> Signed-off-by: Igor Ryzhov > >> > >> Acked-by: Ferruh Yigit > > > > I intend to change the title as "kni: fix mtu setting with kernels >=3D= 4.10". > > Does it sound ok to you? > > I am not quite sure it is a fix, this patch enables application to pass m= in/max > MTU values for kni netdev but existing code is not doing anything wrong. To me, starting 4.10, we can't set the mtu to something greater than 1500 on a kni netdev, since netdev uses the ETH_DATA_LEN default value and will refuse a bigger mtu before even calling the change mtu ndo. Did I understand something wrong? --=20 David Marchand