From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4011A00C2; Wed, 5 Oct 2022 21:41:42 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B3CCB40DFB; Wed, 5 Oct 2022 21:41:42 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id BF1DD40DDC for ; Wed, 5 Oct 2022 21:41:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664998900; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mtUPQOMXICg4krAMRcg2UbKYKesf+Ia2ZxEuzSTs1Cg=; b=gXgPtQN+xnv+xGugK9wtrPlDtFlHJ/UchaarhktXtmiUhLRl+2MFD/+3SSFIybwf0pbomN inqjssorR5JY16PgkKDLcj74JMWMqutLg1CP3DRgMtmRWn8uyLEfDdTsQGA7hh7Qh7MJsm A5scQM+9qhFwscLTYx77rbg8Q6Iwkh8= Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-623-YKenWtKXPeqOP7HVZ_SfCw-1; Wed, 05 Oct 2022 15:41:39 -0400 X-MC-Unique: YKenWtKXPeqOP7HVZ_SfCw-1 Received: by mail-pj1-f69.google.com with SMTP id w9-20020a17090a780900b002093deb1701so1373307pjk.0 for ; Wed, 05 Oct 2022 12:41:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=mtUPQOMXICg4krAMRcg2UbKYKesf+Ia2ZxEuzSTs1Cg=; b=jy3isHtzYd7FcLj+VGdgyfeoocatDi0PxRmdHXZ+7ApzPxqUN0PmHHzYmJPUeATET9 PeIvNrciPpSPmh+BnKwhhSoZate+oCiv+Azyc3syEY1Dl1rwwwSSHtjBWDbqPUHL53sm KbZaLoO9Fo6WXZEJkUScaGcUJdAi3tZqfVcWoy7FCrb5NM1quEk5C+O4HH5QSjz1A2jG BQWURW2nToFv6Adc6BHJyHPAOG73FKRP1RtU7IG4Eyr0MT3KA/bJcqFWWslcTUqE1Rf7 pkiGm6RFrIO/A80IE2b9PTzanPIaLvO5C8CglXI83nHGiBQGbV5EtONevH95Kpa9oLid F/TQ== X-Gm-Message-State: ACrzQf2WvA92gzbxMnBYd3k+eSP9Yr8KnxMzH5GwdUe2JKPP0EZNod6k LbNojkxb+QRI/iADXbA5UVke6wFM3G5qbYVum7tzm38X/VZ3gV1Q38xVg97Br7v/mFkgqTWAE+B gwHfL7uq61q822Z9VQk4= X-Received: by 2002:aa7:86cf:0:b0:561:4b7b:4745 with SMTP id h15-20020aa786cf000000b005614b7b4745mr1359194pfo.29.1664998898407; Wed, 05 Oct 2022 12:41:38 -0700 (PDT) X-Google-Smtp-Source: AMsMyM56tpdHZARmASV4BMMmUFkFr1ry19Wgs2D1+aoaeTM0UXVVN6J+FVaIBMBonbMQVVwsXVYo77MUybzRHafXsoY= X-Received: by 2002:aa7:86cf:0:b0:561:4b7b:4745 with SMTP id h15-20020aa786cf000000b005614b7b4745mr1359182pfo.29.1664998898122; Wed, 05 Oct 2022 12:41:38 -0700 (PDT) MIME-Version: 1.0 References: <22501102.ssLaC8jLEa@thomas> <20221005154036.4187143-1-thomas@monjalon.net> In-Reply-To: <20221005154036.4187143-1-thomas@monjalon.net> From: David Marchand Date: Wed, 5 Oct 2022 21:41:26 +0200 Message-ID: Subject: Re: [PATCH] eal: fix return type of bsf safe functions To: Thomas Monjalon Cc: dev@dpdk.org, Stephen Hemminger , Tyler Retzlaff , =?UTF-8?Q?Morten_Br=C3=B8rup?= X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 5, 2022 at 5:41 PM Thomas Monjalon wrote: > > In a recent commit, changing return type from int to uint32_t, > I did a last minute change to functions rte_bsf32_safe and rte_bsf64_safe, > because thought they were forgotten. > Actually these functions are returning 0 or 1, so it should be int. > The return type is reverted to the original type for these 2 functions. > > Fixes: 4b81c145ae37 ("eal: change return type of bsf/fls functions") > > Signed-off-by: Thomas Monjalon Reviewed-by: David Marchand -- David Marchand