From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0AD35A04FB; Tue, 17 Dec 2019 09:15:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EE72E2C17; Tue, 17 Dec 2019 09:15:17 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 2D251330 for ; Tue, 17 Dec 2019 09:15:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576570515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0OoFBjYAalP96cA4EbIcU07V6ASKbPe3iH5y7G3MlKI=; b=NGxZYcHIsvisy1PJAaaLujxQgMr7LkGXPUCAWe7Y3s/2osUT8fcK/ZS1XjnmKktAFx6dNO od7Q6OPz9HXZfr5gWmW+FFsB78OBrYn+TtLfdNqnSG8S1bwgCzw0rVd2vHB6+s1Omur4ai 7hQaUNld9J6Tsx4ItmIa/iP8GZbf1dk= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-383-DG6vqjLGMrmaVpjdunJf4w-1; Tue, 17 Dec 2019 03:15:13 -0500 Received: by mail-ua1-f69.google.com with SMTP id z2so928160uar.13 for ; Tue, 17 Dec 2019 00:15:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+41BP4cKYYyCRXwSmr49UKl/Y30Kw0dfvACZMzDsOLc=; b=XH43/vDnLTdGKVW4tFJDF02B8d9EamZz8rETmp4YoWP9CoqRsVU7L4rckJ4TrCFh+7 IsuYG0frwLnI9NcvTjwvL1VEsjYg1C6qYcuplSQGaSqzZTvvtduaME3vy/L2Pg/OG9rn LMBQI9+n2Mg4lG9ZsROx3RR3obKgNC7WyE/ZA8aLw9R+h3aSVOQNJ/Lx5Bj1Q4EnIM6m /h87ZpNDLOaBFM0lHOX5D39nGfiJUhsDiW1Rn1YL1wbd/+OtotV16gfQ3oRr/9fc2Ppk j58y6HaQtMA0rVzi/FYxQggglPD5zoYbYan3R39RgJ97Ftdx+qbL2YrGcgkJcropJd+F k7bg== X-Gm-Message-State: APjAAAW5QZEfNvDghI++Ld/4agn0X3La2hhZvkPzWFfTin7PreuyEegn hmMU161HeVKF+5fLHO9344nUFrSKgMcCe5qlBfbfFytTC6X0xEo7csJsCnlKEub5isRJtbKmOqS hHCINs+XH4ZqZjgOFTVY= X-Received: by 2002:a9f:372c:: with SMTP id z41mr2295615uad.87.1576570512811; Tue, 17 Dec 2019 00:15:12 -0800 (PST) X-Google-Smtp-Source: APXvYqzsVUk8W/rUD2JBqLfdOpNn4lN7Rmysyg3u7N0LhYiURbdxuyoa07ji8PP2cw/rJzCD+lmGZNkRVP+fdQAUlh8= X-Received: by 2002:a9f:372c:: with SMTP id z41mr2295600uad.87.1576570512466; Tue, 17 Dec 2019 00:15:12 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Tue, 17 Dec 2019 09:15:01 +0100 Message-ID: To: Liron Himi , Cristian Dumitrescu Cc: dpdk-dev , Thomas Monjalon , "nhorman@tuxdriver.com" , "stephen@networkplumber.org" X-MC-Unique: DG6vqjLGMrmaVpjdunJf4w-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] checkpatch failing on map change X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello, On Tue, Dec 17, 2019 at 8:36 AM Liron Himi wrote: > One of our drivers is using the rte_cfgfile and meson is failing on 'rte_= cfgfile_section_num_entries_by_index' which is undefined. > > After a few debug cycles, I found out that this function is missing from = the .map file. > > So I added it and created a patch but checkpatch is failing with > ERROR: symbol rte_cfgfile_section_num_entries_by_index is added in the DP= DK_20.0 section, but is expected to be added in the EXPERIMENTAL section of= the version map > > Do you know what it means and how to fix it? The function is not defined = as experimental so I don't understand what is the problem Liron, The script can't tell that the symbol that was added in the map file is already part of the stable ABI: so it complains that a new symbol should first be marked experimental. But in this specific case, we can ignore the check. You can send your patch to amend the map file. Cristian, Can you double check this library symbols to catch other unexported symbols= ? A quick grep shows that rte_cfgfile_section_num_entries_by_index() is not called in the current tree, we have no UT on it. Maybe something to add. Thanks. --=20 David Marchand