From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 243E6A0547; Fri, 29 Oct 2021 16:50:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0BD5B411DD; Fri, 29 Oct 2021 16:50:51 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id E52B24111F for ; Fri, 29 Oct 2021 16:50:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635519049; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=uSJsJzjUfB4V3GrsHyqECuwCx+AuxpqHr0v71kTZd7I=; b=emm4iOd/199iYH0+q7rWICZKhI6/yK625yJtWFa4ICZKgIqXgdX+156+QcTabKtrpKrm7f vV6yElkE2HK/KBumPYrqYk6bDWJcb4zszPl4SD9f63JeM384QG1FHxInRsVkV7uwmrKBma G7qWg16ZK1mbhkjr4lCOG9R+ydoiCV8= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-49-_ELqXrB8N9O2Qfevu0jLBA-1; Fri, 29 Oct 2021 10:50:47 -0400 X-MC-Unique: _ELqXrB8N9O2Qfevu0jLBA-1 Received: by mail-lf1-f70.google.com with SMTP id y40-20020a0565123f2800b003fded085638so4233813lfa.0 for ; Fri, 29 Oct 2021 07:50:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uSJsJzjUfB4V3GrsHyqECuwCx+AuxpqHr0v71kTZd7I=; b=5LxLqzIIDBAJJnmID3bxeTKZur5c5Si/jqQ2k+y5M2JMnoscE0bhXujDe9vaprTSAO yC/Et6E88D0tgSPvwXxQKjLo5J64eBb7sL4zIZdTuuv22PWJ8SdxnY4GNgy9Ft5Jyehe jster6/anyJ6U9nZKLyyHyWLP37sBGlZasEOegc7asduev02sBHN064I22PC5rSeOLsv +gllYYUOMhOyGaTPccJUAIVyJSIurDfbXcrIh3X8kjop+U3Rn7IasbtsSxf9bZtHFtoT fMjDO1QJAjG9hPVePK0MdeeO3zofQ11ZEwQgVO/KwqjrEXhIZK8xwnH9VxQSsFJy8Ntu GkCA== X-Gm-Message-State: AOAM530kwEnxGq+86FkubUZgR8J/KaaYh9VDpDv4dJGDGqXHJy/+3JEy mCwAKwe6LeDE9Bt7nwDHjNUTv7pxkFzrC/AYoDJC6HdpvTHqZ0+4kLiYLvddIAmU/CfgmI/ohgp bbfdBUSkFfu+D2bZbKv4= X-Received: by 2002:a2e:9018:: with SMTP id h24mr12541318ljg.477.1635519046398; Fri, 29 Oct 2021 07:50:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx1Y5W9SL9hZnRjgELfEdMz1QeojFCg0u4c6gibtBLfEo7RAqOraSrSilOIp+QTOhRWemaJcTCUvvTgN1IcD6k= X-Received: by 2002:a2e:9018:: with SMTP id h24mr12541303ljg.477.1635519046222; Fri, 29 Oct 2021 07:50:46 -0700 (PDT) MIME-Version: 1.0 References: <20211019151524.2005442-4-zhihongx.peng@intel.com> <20211020074643.3004385-1-zhihongx.peng@intel.com> In-Reply-To: From: David Marchand Date: Fri, 29 Oct 2021 16:50:35 +0200 Message-ID: To: Zhihong Peng Cc: Thomas Monjalon , "Burakov, Anatoly" , "Ananyev, Konstantin" , Stephen Hemminger , Cristian Dumitrescu , "Mcnamara, John" , Bruce Richardson , dev , Xueqin Lin Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v13 1/4] enable ASan AddressSanitizer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 29, 2021 at 11:21 AM David Marchand wrote: > > Replying on this patch since there is no cover letter. > > This series looks acceptable to me for rc2. > > Patch 3 and 4 will be merged first, since they fix issues that would > be hit with ASan enabled. > > I have comments mainly on rewording in commitlogs and documentation. > > If you are fine with those comments, I'll fix them before pushing this series. > Series applied with suggestions. ASan is a really interesting tool, but there are still issues in some components. I caught a few and opened bugs. We should work on fixing them so that we can have ASan enabled in the CI. The sooner, the better. Thanks. -- David Marchand