From: David Marchand <david.marchand@redhat.com>
To: Joyce Kong <joyce.kong@arm.com>
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"Ruifeng Wang (Arm Technology China)" <ruifeng.wang@arm.com>,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
dev <dev@dpdk.org>, nd <nd@arm.com>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v1] eal/arm: fix gcc build for 128-bit atomic compare exchange
Date: Wed, 27 Jan 2021 11:22:34 +0100 [thread overview]
Message-ID: <CAJFAV8x4NhsxkjnJ2==-Y5Km=jS7+_dwO7XFcJNdGPXwT8O76w@mail.gmail.com> (raw)
In-Reply-To: <20210115095821.42721-1-joyce.kong@arm.com>
On Fri, Jan 15, 2021 at 10:58 AM Joyce Kong <joyce.kong@arm.com> wrote:
>
> Compiling with "meson build -Dbuildtype=debug --cross-file
> config/arm/arm64_thunderx2_linux_gcc" shows the warnings
> "function returns an aggregate [-Waggregate-return]":
> ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h: In
> function ‘__cas_128_relaxed’:
> ../../dpdk/lib/librte_eal/arm/include/rte_atomic_64.h:81:20:
> error: function returns an aggregate [-Werror=aggregate-return]
> __ATOMIC128_CAS_OP(__cas_128_relaxed, "casp")
> ^~~~~~~~~~~~~~~~~
>
> Fix the compiling issue by defining __ATOMIC128_CAS_OP as a void
> function and passing the address pointer into it.
>
> Fixes: 7e2c3e17fe2c ("eal/arm64: add 128-bit atomic compare exchange")
> Cc: stable@dpdk.org
>
> Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2021-01-27 10:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 9:58 Joyce Kong
2021-01-15 15:55 ` David Marchand
2021-01-21 9:36 ` Joyce Kong
2021-01-27 3:36 ` Ruifeng Wang
2021-01-27 9:56 ` Jerin Jacob
2021-01-27 10:22 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8x4NhsxkjnJ2==-Y5Km=jS7+_dwO7XFcJNdGPXwT8O76w@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=jerinj@marvell.com \
--cc=joyce.kong@arm.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).