DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] bus/ifpga: remove dead code
@ 2023-12-18 15:45 David Marchand
  2023-12-18 15:47 ` Bruce Richardson
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: David Marchand @ 2023-12-18 15:45 UTC (permalink / raw)
  To: dev; +Cc: Rosen Xu, Tianfei Zhang, Qi Zhang

This macro was never used.

Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/bus/ifpga/ifpga_logs.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/bus/ifpga/ifpga_logs.h b/drivers/bus/ifpga/ifpga_logs.h
index 873e0a4f2f..248bccba5d 100644
--- a/drivers/bus/ifpga/ifpga_logs.h
+++ b/drivers/bus/ifpga/ifpga_logs.h
@@ -9,10 +9,6 @@
 
 extern int ifpga_bus_logtype;
 
-#define IFPGA_LOG(level, fmt, args...) \
-	rte_log(RTE_LOG_ ## level, ifpga_bus_logtype, "%s(): " fmt "\n", \
-		__func__, ##args)
-
 #define IFPGA_BUS_LOG(level, fmt, args...) \
 	rte_log(RTE_LOG_ ## level, ifpga_bus_logtype, "%s(): " fmt "\n", \
 		__func__, ##args)
-- 
2.43.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] bus/ifpga: remove dead code
  2023-12-18 15:45 [PATCH] bus/ifpga: remove dead code David Marchand
@ 2023-12-18 15:47 ` Bruce Richardson
  2023-12-19  1:18 ` Xu, Rosen
  2024-01-19 11:08 ` David Marchand
  2 siblings, 0 replies; 4+ messages in thread
From: Bruce Richardson @ 2023-12-18 15:47 UTC (permalink / raw)
  To: David Marchand; +Cc: dev, Rosen Xu, Tianfei Zhang, Qi Zhang

On Mon, Dec 18, 2023 at 04:45:26PM +0100, David Marchand wrote:
> This macro was never used.
> 
> Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  drivers/bus/ifpga/ifpga_logs.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH] bus/ifpga: remove dead code
  2023-12-18 15:45 [PATCH] bus/ifpga: remove dead code David Marchand
  2023-12-18 15:47 ` Bruce Richardson
@ 2023-12-19  1:18 ` Xu, Rosen
  2024-01-19 11:08 ` David Marchand
  2 siblings, 0 replies; 4+ messages in thread
From: Xu, Rosen @ 2023-12-19  1:18 UTC (permalink / raw)
  To: Marchand, David, dev; +Cc: Tianfei Zhang, Zhang, Qi Z

Hi

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Monday, December 18, 2023 11:45 PM
> To: dev@dpdk.org
> Cc: Xu, Rosen <rosen.xu@intel.com>; Tianfei Zhang
> <tianfei.zhang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [PATCH] bus/ifpga: remove dead code
> 
> This macro was never used.
> 
> Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  drivers/bus/ifpga/ifpga_logs.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/bus/ifpga/ifpga_logs.h b/drivers/bus/ifpga/ifpga_logs.h
> index 873e0a4f2f..248bccba5d 100644
> --- a/drivers/bus/ifpga/ifpga_logs.h
> +++ b/drivers/bus/ifpga/ifpga_logs.h
> @@ -9,10 +9,6 @@
> 
>  extern int ifpga_bus_logtype;
> 
> -#define IFPGA_LOG(level, fmt, args...) \
> -	rte_log(RTE_LOG_ ## level, ifpga_bus_logtype, "%s(): " fmt "\n", \
> -		__func__, ##args)
> -
>  #define IFPGA_BUS_LOG(level, fmt, args...) \
>  	rte_log(RTE_LOG_ ## level, ifpga_bus_logtype, "%s(): " fmt "\n", \
>  		__func__, ##args)
> --
> 2.43.0

Acked-by: Rosen Xu <rosen.xu@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] bus/ifpga: remove dead code
  2023-12-18 15:45 [PATCH] bus/ifpga: remove dead code David Marchand
  2023-12-18 15:47 ` Bruce Richardson
  2023-12-19  1:18 ` Xu, Rosen
@ 2024-01-19 11:08 ` David Marchand
  2 siblings, 0 replies; 4+ messages in thread
From: David Marchand @ 2024-01-19 11:08 UTC (permalink / raw)
  To: dev; +Cc: Rosen Xu, Tianfei Zhang, Qi Zhang, Bruce Richardson

On Mon, Dec 18, 2023 at 4:45 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> This macro was never used.
>
> Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Applied, thanks.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-01-19 11:08 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-18 15:45 [PATCH] bus/ifpga: remove dead code David Marchand
2023-12-18 15:47 ` Bruce Richardson
2023-12-19  1:18 ` Xu, Rosen
2024-01-19 11:08 ` David Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).