From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 76C4842D7F; Wed, 28 Jun 2023 12:19:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E51B406B3; Wed, 28 Jun 2023 12:19:24 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D5A99400EF for ; Wed, 28 Jun 2023 12:19:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687947562; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K4Jjj2LMHHoZIEd6xzl8sF/avjY7E4MV3PKiD1pE5Es=; b=AA4S/3YA7afo54UKBe7olh0ywcB1wpOKBZXaMTmS0FmNxIjJx8YJJJIG4CO3opMw0K2GZB xdOOgVAcbVoTbaSnARAhPSL08TNnVw14/mWOCXNR4mxD98N7Cz2t6fBbkq6uHBToegyr+I EglERLyI69O9tv7Ss7S18oG5un23vN0= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-280-lI4gzWrEPCWvRCLlOfcrFg-1; Wed, 28 Jun 2023 06:19:21 -0400 X-MC-Unique: lI4gzWrEPCWvRCLlOfcrFg-1 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-262e04a6fd1so1957369a91.3 for ; Wed, 28 Jun 2023 03:19:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687947560; x=1690539560; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K4Jjj2LMHHoZIEd6xzl8sF/avjY7E4MV3PKiD1pE5Es=; b=bpq6NeeXz4wxka+hvLSx+AqfQdFT45Kbt9ZA3JPqqz7m17l9XOhTd2U0T7ve3K/clL 40Qzr5ymCDSTJXTKeFrEGh1SDjmhLmZGPP5aWFx8So/U/8YxxCxMqj1fBLahx04+etXd g1uXl3w2i4+PnhTiDzKTmYzD+OmkGHlVzFiol8GUkZL/GBCm35ZUzEin75vVJ6Wiu1Oq ZHZCqKg7nJfjLO8jcP/ejfNcIOI+HMNgbNRmOcnakTPld5qKllwApzpZSMzm1LQ2CcOn YtXzBgMDsAul6vkcpBt2Ji2/gY9QPK2YpoOkF4rFYCKPU9FqEUzFsgBQY7r5InguNAQq Nvcg== X-Gm-Message-State: AC+VfDxWxN1gYWD/Zbgumv4qxqE+7Sk0XiQdfdxXpTDa68DokItD07F5 OrLgHJx0Cf09NscN0YyiBbb6xfpTZQKIdVPTH8YwDdAhS+oVaVM6idOQaBddM1p4m62Skj/DmCf BcedVr6b1vwSVeqn4rcg= X-Received: by 2002:a17:90a:f0cc:b0:253:266a:3b00 with SMTP id fa12-20020a17090af0cc00b00253266a3b00mr25356066pjb.37.1687947560087; Wed, 28 Jun 2023 03:19:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4Jc27VGYjrO9dzRrBNwdbVIBMXejrybHV6O1aVSfdtRILH2OmAyDgLr2NSUrZRdN6Y0hwwAw54iMMVUlkCX34= X-Received: by 2002:a17:90a:f0cc:b0:253:266a:3b00 with SMTP id fa12-20020a17090af0cc00b00253266a3b00mr25356057pjb.37.1687947559841; Wed, 28 Jun 2023 03:19:19 -0700 (PDT) MIME-Version: 1.0 References: <20230622134840.3225975-1-bruce.richardson@intel.com> <20230623150708.2203918-1-bruce.richardson@intel.com> <20230623150708.2203918-3-bruce.richardson@intel.com> In-Reply-To: <20230623150708.2203918-3-bruce.richardson@intel.com> From: David Marchand Date: Wed, 28 Jun 2023 12:19:08 +0200 Message-ID: Subject: Re: [PATCH v4 2/9] event/dlb2: skip configuration if no eventdev lib To: Bruce Richardson Cc: dev@dpdk.org, Timothy McDaniel X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jun 23, 2023 at 5:07=E2=80=AFPM Bruce Richardson wrote: > > While the build system will skip building most libs and drivers when a > dependency is missing for a component, for DLB2 driver, the > "static_rte_eventdev" object is referenced inside the meson.build file > itself, which will cause crashes if it doesn't exist i.e. if eventdev is > disabled. Prevent this issue by skipping processing the file if no > eventdev. [The build system will still report missing dependency, as the > dependency is set by default for all eventdev drivers] > > Signed-off-by: Bruce Richardson Could we evaluate the class "std_deps" before jumping to each driver meson.build? --=20 David Marchand