From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45EE045C9E; Wed, 6 Nov 2024 21:35:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 346D742EA7; Wed, 6 Nov 2024 21:35:41 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 24B6742E54 for ; Wed, 6 Nov 2024 21:35:40 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730925339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gaFojhW6i1DtSfkzRm1cc6syv/vPfZhUSvZ/z7ccOqA=; b=VeTZX7PAWLgiLC9dlnSoMiGYnIM1d3MyMdLiNJvUSOyPb2KnErzhbXbMoR9/AYqxW8jcyh N7m7eKMqyAVA/8QcRyOyFXaO/rBFOA88rn+j8Q/UuX0zllZO7b3k2wbyP+xd5C3Rk8qeqR mD98/peZ881CLhbpOpXd3pzBQL92tMs= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-534-CzCFynrCNm2Zy_7DIGbqwg-1; Wed, 06 Nov 2024 15:35:38 -0500 X-MC-Unique: CzCFynrCNm2Zy_7DIGbqwg-1 X-Mimecast-MFC-AGG-ID: CzCFynrCNm2Zy_7DIGbqwg Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-539f49f23ddso78985e87.1 for ; Wed, 06 Nov 2024 12:35:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730925337; x=1731530137; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gaFojhW6i1DtSfkzRm1cc6syv/vPfZhUSvZ/z7ccOqA=; b=m/FPxrCS+TYEQPp+gwbFqlS2yybmeslw1MIYjnHe/svlgd7+r6HyLngkbTVXeZxUdm SpzXu+law6J9thZ8cXdZATrMheIHSbZQaid+UrMpQ2aJevTs6Tcn+Zg5C+rXagNODAEu JPKlUW4Gr0qPepSSRCWtPo567tr3H63M5eCi5rzI21GO83Y7Bm16OalGua6R/E6F2SNi 5TmtOrG6EqAlwZqX1YPYG/xPB+Pp09eIHxJ8PlgenG8MeJrJg2L5K59wrx0iN5ZOhta4 uSWSFJ5yaBTT0lTwqJlaFuN4XRhgqI2GM3ZdG+3+cJIseMm4zkSaLN7/uOYMD1KegmNk BY8g== X-Gm-Message-State: AOJu0YxjghoUX8KtGHK8ioS63wy2MOdvt3ak8cz41jsgSMwzty9TFR/X fHLoueD/iC0U5bqrdW/TwaRp8QgW+OMyPEnJx3KaWcLOQwNubAZtlOxU7k0UMwRRXB80FjoRbbT m+lPKxly0ec1e0FXo+mKEGYs3YlFYsyKITokIHNkkaMAJAFKnNTme/nwFSPZNVS87LQHIdmAbfP Wo5VvWoE0n+jLFSDc= X-Received: by 2002:a05:6512:ac3:b0:536:56d8:24b4 with SMTP id 2adb3069b0e04-53c79e15746mr11869865e87.5.1730925336949; Wed, 06 Nov 2024 12:35:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IEly95rGszFwIeHs31lnGjcQ9dnZXUMz6y61lIYt1uIgYYVkABHWslSKKD9gHWwyWJOEZfSjEQtF58OipKo9Ac= X-Received: by 2002:a05:6512:ac3:b0:536:56d8:24b4 with SMTP id 2adb3069b0e04-53c79e15746mr11869854e87.5.1730925336514; Wed, 06 Nov 2024 12:35:36 -0800 (PST) MIME-Version: 1.0 References: <20241105112721.373285-1-bruce.richardson@intel.com> <20241106101836.0f66c457@hermes.local> In-Reply-To: <20241106101836.0f66c457@hermes.local> From: David Marchand Date: Wed, 6 Nov 2024 21:35:25 +0100 Message-ID: Subject: Re: [PATCH] app/dumpcap: remove unused struct array To: Bruce Richardson Cc: dev@dpdk.org, stable@dpdk.org, Stephen Hemminger X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: na4lx2y6lAvjtOU3Vjl8VQSVd9xNbpaf2VdhZptf2aQ_1730925337 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 6, 2024 at 7:18=E2=80=AFPM Stephen Hemminger wrote: > > On Tue, 5 Nov 2024 11:27:21 +0000 > Bruce Richardson wrote: > > > The callbacks(rx_cb) member of struct interface was unused inside > > dumpcap, but was taking up a lot of memory space, since it was scaled > > according to RTE_MAX_QUEUES_PER_PORT, which is 1k by default. Save > > memory by removing the whole array. > > > > Fixes: cbb44143be74 ("app/dumpcap: add new packet capture application") > > Cc: stable@dpdk.org > > > > Suggested-by: Stephen Hemminger > > Signed-off-by: Bruce Richardson > Acked-by: Stephen Hemminger Applied, thanks. --=20 David Marchand