From: David Marchand <david.marchand@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v2 08/10] app/test: add some unattached tests to fast-test suite
Date: Fri, 5 Dec 2025 13:50:03 +0100 [thread overview]
Message-ID: <CAJFAV8x5fScFgdSzH91-L+M6KTdYXP-NaMWPd5CaeG8L08QbSw@mail.gmail.com> (raw)
In-Reply-To: <aTLTj4uppv01kT7T@bricha3-mobl1.ger.corp.intel.com>
On Fri, 5 Dec 2025 at 13:44, Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> On Fri, Dec 05, 2025 at 01:37:06PM +0100, David Marchand wrote:
> > On Thu, 4 Dec 2025 at 19:22, Bruce Richardson
> > <bruce.richardson@intel.com> wrote:
> > > diff --git a/app/test/test_red.c b/app/test/test_red.c
> > > index 7f38ed1469..4b17173999 100644
> > > --- a/app/test/test_red.c
> > > +++ b/app/test/test_red.c
> > > @@ -1872,6 +1872,6 @@ test_red_all(void)
> > >
> > > #endif /* !RTE_EXEC_ENV_WINDOWS */
> > >
> > > -REGISTER_TEST_COMMAND(red_autotest, test_red);
> > > +REGISTER_FAST_TEST(red_autotest, NOHUGE_OK, ASAN_OK, test_red);
> > > REGISTER_PERF_TEST(red_perf, test_red_perf);
> > > REGISTER_PERF_TEST(red_all, test_red_all);
> >
> > The commit 50823f30f0c8 ("test: build using per-file dependencies")
> > removed some context on why some tests were not part of a testsuite.
> > -# Tests known to have issues or which don't belong in other tests lists.
> > -extra_test_names = [
> > - 'alarm_autotest', # ee00af60170b ("test: remove strict timing
> > requirements some tests")
> > - 'red_autotest', # https://bugs.dpdk.org/show_bug.cgi?id=826
> > -]
> >
> > I would prefer we don't put an unreliable test in fast-tests.
> >
> Agreed, but for many cases for developers running these on their systems,
> it's probably worth having them in. What would you think about having
> checks in the tests themselves to detect if they are running in github CI
> and to skip themselves in that case?
rte_red API has been left without tests for years.
I would prefer we remove the library completely rather than having to
work more on it.
IIRC, the issue was seen at UNH, not in GHA and it was quite random.
If the goal is just about removing a build warning, let's put this
test in a "attic" testsuite.
--
David Marchand
next prev parent reply other threads:[~2025-12-05 12:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-02 15:49 [PATCH 0/2] improve fast-tests suite Bruce Richardson
2025-12-02 15:49 ` [PATCH 1/2] app/test: add some unattached tests to fast-test suite Bruce Richardson
2025-12-02 15:49 ` [PATCH 2/2] app/test: make parameters clearer when adding fast tests Bruce Richardson
2025-12-02 16:53 ` Marat Khalili
2025-12-02 18:16 ` Bruce Richardson
2025-12-04 18:20 ` [PATCH v2 00/10] Assign all unit tests to suites Bruce Richardson
2025-12-04 18:20 ` [PATCH v2 01/10] app/test: make parameters clearer when adding fast tests Bruce Richardson
2025-12-05 10:10 ` Marat Khalili
2025-12-05 10:17 ` Bruce Richardson
2025-12-04 18:20 ` [PATCH v2 02/10] app/test: fix undefined behaviour in red autotest Bruce Richardson
2025-12-05 10:25 ` Marat Khalili
2025-12-04 18:20 ` [PATCH v2 03/10] app/test: reduce duration of secondary timer test Bruce Richardson
2025-12-04 18:20 ` [PATCH v2 04/10] app/test: fix timer loop hang on secondary process failure Bruce Richardson
2025-12-04 18:20 ` [PATCH v2 05/10] eal: add internal APIs to query loaded driver paths Bruce Richardson
2025-12-04 18:20 ` [PATCH v2 06/10] app/test: pass loaded driver info to secondary procs Bruce Richardson
2025-12-04 18:20 ` [PATCH v2 07/10] app/test: skip power capabilities test if unsupported Bruce Richardson
2025-12-04 18:20 ` [PATCH v2 08/10] app/test: add some unattached tests to fast-test suite Bruce Richardson
2025-12-05 12:37 ` David Marchand
2025-12-05 12:43 ` Bruce Richardson
2025-12-05 12:50 ` David Marchand [this message]
2025-12-05 12:53 ` Bruce Richardson
2025-12-05 13:08 ` David Marchand
2025-12-04 18:20 ` [PATCH v2 09/10] app/test: add tests to driver test suite Bruce Richardson
2025-12-04 18:20 ` [PATCH v2 10/10] buildtools/get-test-suites: suppress empty output Bruce Richardson
2025-12-05 10:29 ` Marat Khalili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8x5fScFgdSzH91-L+M6KTdYXP-NaMWPd5CaeG8L08QbSw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).